Repository navigation
Repair wp/6.8 branch Actions: Reset preferences after navigable toolbar e2e tests - #83723
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
September 28, 2026 23:17
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 7, 2026 13:44
7acbb91 to
7628d80
Compare
desrosj
removed this pull request from stack #83414
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.8/fix-flaky-site-editor-url-navigation
to
wp/6.8
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 7, 2026 18:16
7628d80 to
d40462d
Compare
desrosj
changed the base branch from
wp/6.8
to
fix-actions-6.8/fix-flaky-site-editor-url-navigation
October 7, 2026 18:18
desrosj
added this pull request to stack #84189
October 7, 2026 18:18
desrosj
removed this pull request from stack #84189
October 8, 2026 21:19
desrosj
changed the base branch from
fix-actions-6.8/fix-flaky-site-editor-url-navigation
to
wp/6.8
October 8, 2026 21:21
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 8, 2026 21:21
d40462d to
bb0e030
Compare
desrosj
changed the base branch from
wp/6.8
to
fix-actions-6.8/fix-flaky-site-editor-url-navigation
October 8, 2026 21:23
desrosj
added this pull request to stack #84349
October 8, 2026 21:23
desrosj
removed this pull request from stack #84349
October 9, 2026 23:36
desrosj
changed the base branch from
fix-actions-6.8/fix-flaky-site-editor-url-navigation
to
wp/6.8
October 9, 2026 23:37
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 9, 2026 23:38
bb0e030 to
6bdbd93
Compare
desrosj
changed the base branch from
wp/6.8
to
fix-actions-6.8/fix-flaky-site-editor-url-navigation
October 9, 2026 23:39
desrosj
added this pull request to stack #84472
October 9, 2026 23:40
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 19, 2026 17:05
6bdbd93 to
bf56468
Compare
desrosj
removed this pull request from stack #84472
October 21, 2026 18:32
desrosj
added this pull request to stack #85322
October 21, 2026 18:33
desrosj
force-pushed
the
fix-actions-6.8/reset-preferences-after-navigable-toolbar-tests
branch
from
October 23, 2026 17:35
bf56468 to
a56d1cc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82786.
What?
Resets preferences through the REST API after every test in
test/e2e/specs/editor/various/navigable-toolbar.spec.js, instead of turning the fixed ("Top") toolbar back off at the end of two of its tests.Why?
The "Block toolbar will scroll to reveal hidden buttons with fixed toolbar" test turns the fixed toolbar on and, as its last step, off again. Preferences are saved to the server with a 2.5-second debounce, so when the test finishes quickly the page closes before the "off" is saved, and the server keeps
fixedToolbar: true. Every later post-editor test in the same shard then loads with the top toolbar on: the floating block toolbar and the editor top bar's "Back"/"Options" buttons aren't where those tests expect them, so they fail on every retry. This branch has the same test and the same debounced preference saving, so the fix is included for consistency.requestUtils.resetPreferences()writes the preferences directly over REST from the test runner, so it doesn't depend on the page staying open, and it also runs after a failed test.Upstream
A straight cherry-pick of
2e877e9(#78115) fromtrunk.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code