Repository navigation
Repair wp/6.3 branch Actions: Run Playwright on ubuntu-22.04 to fix browser-install failures - #83712
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
74a6d8a to
d4908c4
Compare
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
d4908c4 to
cbb07fe
Compare
cbb07fe to
19bafa9
Compare
19bafa9 to
c059c76
Compare
c059c76 to
a01dcf8
Compare
Part of #82930.
What?
Runs the
e2e-playwrightjob inend2end-test.ymlonubuntu-22.04instead ofubuntu-24.04. Every other job stays onubuntu-24.04(set by #83704).Why?
This branch pins
@playwright/testat1.32.0, and its.nvmrcis Node.js 14, so Playwright can't be upgraded without a Node.js upgrade. Playwright1.32.0predates Ubuntu 24.04 support (added in1.45), which breaks the job onubuntu-24.04in two ways:npx playwright install chromium firefox webkit --with-depsfails before downloading anything, because it tries to install Ubuntu 22.04 package names that 24.04 doesn't have (E: Package 'libasound2' has no installation candidate,E: Unable to locate package libffi7,E: Unable to locate package libx264-163).--with-deps, WebKit can't run at all (libsoup2.4-1andlibvpx7aren't available on 24.04), and Firefox crashes partway through every run withbrowserContext.newPage: Page closed, failing every Firefox test queued after it.On
ubuntu-22.04,--with-depsinstalls everything and all three browsers pass.wp/6.4solves the same problem differently (#83685): its stack moves to Node.js 20, so it upgrades Playwright to1.49.1instead.GitHub will retire the
ubuntu-22.04image at some point after Ubuntu 26.04 runners became generally available (September 2026). When that happens, this job will need either a Playwright upgrade (which needs a Node.js upgrade) or to go back to installing browsers without--with-depsand excluding WebKit and Firefox.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.