Skip to content

Repair wp/6.4 branch Actions: Retry Puppeteer plugin activation/deactivation on timeout - #83690

Open
desrosj wants to merge 3 commits into
fix-actions-6.4/fix-wp-bind-esc-url-testfrom
fix-actions-6.4/retry-plugin-activation-timeout
Open

desrosj wants to merge 3 commits into
fix-actions-6.4/fix-wp-bind-esc-url-testfrom
fix-actions-6.4/retry-plugin-activation-timeout

Conversation

@desrosj

@desrosj desrosj commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Part of #82929.

What?

Fixes Puppeteer end-to-end tests failing on timeouts in activatePlugin/deactivatePlugin (Puppeteer - 1, - 2 and - 3), in two steps:

  1. Raises the wait after clicking "Activate"/"Deactivate" from Puppeteer's 30-second default to 60 seconds, since the plugins screen can take longer than that to render under CI load.
  2. Retries the click-and-wait once if even the 60-second wait times out.

A 60-second wait alone isn't enough; for example, allowed-patterns.test.js's beforeAll hook still timed out calling activatePlugin( 'gutenberg-test-allowed-patterns' ):

TimeoutError: waiting for selector `tr[data-slug="gutenberg-test-allowed-patterns"] .deactivate a` failed: timeout 60000ms exceeded
    at ... activate-plugin.js:33:13
    at Object.<anonymous> (specs/editor/various/allowed-patterns.test.js:31:3)

Why?

Unlike an it()-level failure, a beforeAll/afterAll hook failure doesn't get a second chance from Jest's own jest.retryTimes(2) safety net (packages/e2e-tests/config/setup-test-framework.js) — that only re-runs test bodies, not hooks. So when the one-shot 60-second wait in activatePlugin/deactivatePlugin times out under CI resource contention, the entire describe block fails at once with no fallback, which is exactly what's observed (a single beforeAll timeout cascades into every it() in the file being reported as failed).

This PR wraps the click-and-wait sequence in both helpers in a bounded retry loop (2 attempts): on a timeout it re-visits plugins.php and tries again, rather than failing immediately. The retry first checks whether the previous attempt actually succeeded server-side and only the render wait timed out (in which case the "Activate"/"Deactivate" link is already gone), so it never tries to click a link that no longer exists.

The loop stops at 2 attempts because these helpers usually run in a hook, and Jest stops a hook after 100 seconds on this branch (jest.setTimeout( PUPPETEER_TIMEOUT || 100000 ) in setup-test-framework.js; CI does not set PUPPETEER_TIMEOUT). A first attempt that times out uses about 60 seconds, which leaves roughly 40 seconds for the second, so a third attempt would never start. That second attempt still covers the most common case: the plugin was activated or deactivated server-side and only the page was slow to render, which the reload shows right away.

Upstream

There is no trunk change to port. Trunk never changed these helpers; it moved its end-to-end tests from Puppeteer to Playwright instead (the allowed patterns tests in #57399) and later removed @wordpress/e2e-test-utils entirely in #72880. Playwright's requestUtils.activatePlugin() activates plugins through the REST API rather than the plugins screen, so it has no equivalent wait.

wp/6.5 and newer have no Puppeteer tests that call these helpers. wp/6.3 and older have the same helpers, but none of their recent CI runs hit this timeout.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 28, 2026
@desrosj desrosj self-assigned this Sep 28, 2026
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2df950b1-f739-42a5-8c36-cec347ed426a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.63 MB

ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 951 B
build/annotations/index.min.js 2.67 kB
build/api-fetch/index.min.js 2.27 kB
build/autop/index.min.js 2.12 kB
build/blob/index.min.js 450 B
build/block-directory/index.min.js 7.04 kB
build/block-directory/style-rtl.css 1.01 kB
build/block-directory/style.css 1.01 kB
build/block-editor/content-rtl.css 4.27 kB
build/block-editor/content.css 4.26 kB
build/block-editor/default-editor-styles-rtl.css 380 B
build/block-editor/default-editor-styles.css 380 B
build/block-editor/index.min.js 219 kB
build/block-editor/style-rtl.css 15.5 kB
build/block-editor/style.css 15.5 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 149 B
build/block-library/blocks/audio/editor.css 151 B
build/block-library/blocks/audio/style-rtl.css 125 B
build/block-library/blocks/audio/style.css 125 B
build/block-library/blocks/audio/theme-rtl.css 126 B
build/block-library/blocks/audio/theme.css 126 B
build/block-library/blocks/avatar/editor-rtl.css 115 B
build/block-library/blocks/avatar/editor.css 115 B
build/block-library/blocks/avatar/style-rtl.css 104 B
build/block-library/blocks/avatar/style.css 104 B
build/block-library/blocks/block/editor-rtl.css 302 B
build/block-library/blocks/block/editor.css 302 B
build/block-library/blocks/button/editor-rtl.css 583 B
build/block-library/blocks/button/editor.css 582 B
build/block-library/blocks/button/style-rtl.css 627 B
build/block-library/blocks/button/style.css 626 B
build/block-library/blocks/buttons/editor-rtl.css 336 B
build/block-library/blocks/buttons/editor.css 336 B
build/block-library/blocks/buttons/style-rtl.css 328 B
build/block-library/blocks/buttons/style.css 328 B
build/block-library/blocks/calendar/style-rtl.css 240 B
build/block-library/blocks/calendar/style.css 240 B
build/block-library/blocks/categories/editor-rtl.css 113 B
build/block-library/blocks/categories/editor.css 112 B
build/block-library/blocks/categories/style-rtl.css 124 B
build/block-library/blocks/categories/style.css 124 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 122 B
build/block-library/blocks/code/theme.css 122 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 420 B
build/block-library/blocks/columns/style.css 420 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 124 B
build/block-library/blocks/comment-author-avatar/editor.css 124 B
build/block-library/blocks/comment-content/style-rtl.css 90 B
build/block-library/blocks/comment-content/style.css 90 B
build/block-library/blocks/comment-template/style-rtl.css 200 B
build/block-library/blocks/comment-template/style.css 199 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 221 B
build/block-library/blocks/comments-pagination/editor.css 211 B
build/block-library/blocks/comments-pagination/style-rtl.css 234 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 832 B
build/block-library/blocks/comments/editor.css 832 B
build/block-library/blocks/comments/style-rtl.css 632 B
build/block-library/blocks/comments/style.css 631 B
build/block-library/blocks/cover/editor-rtl.css 647 B
build/block-library/blocks/cover/editor.css 649 B
build/block-library/blocks/cover/style-rtl.css 1.69 kB
build/block-library/blocks/cover/style.css 1.68 kB
build/block-library/blocks/details/editor-rtl.css 65 B
build/block-library/blocks/details/editor.css 65 B
build/block-library/blocks/details/style-rtl.css 97 B
build/block-library/blocks/details/style.css 97 B
build/block-library/blocks/embed/editor-rtl.css 292 B
build/block-library/blocks/embed/editor.css 292 B
build/block-library/blocks/embed/style-rtl.css 411 B
build/block-library/blocks/embed/style.css 411 B
build/block-library/blocks/embed/theme-rtl.css 126 B
build/block-library/blocks/embed/theme.css 126 B
build/block-library/blocks/file/editor-rtl.css 315 B
build/block-library/blocks/file/editor.css 315 B
build/block-library/blocks/file/style-rtl.css 278 B
build/block-library/blocks/file/style.css 279 B
build/block-library/blocks/file/view.min.js 316 B
build/block-library/blocks/footnotes/style-rtl.css 198 B
build/block-library/blocks/footnotes/style.css 197 B
build/block-library/blocks/freeform/editor-rtl.css 2.6 kB
build/block-library/blocks/freeform/editor.css 2.6 kB
build/block-library/blocks/gallery/editor-rtl.css 946 B
build/block-library/blocks/gallery/editor.css 949 B
build/block-library/blocks/gallery/style-rtl.css 1.52 kB
build/block-library/blocks/gallery/style.css 1.52 kB
build/block-library/blocks/gallery/theme-rtl.css 108 B
build/block-library/blocks/gallery/theme.css 108 B
build/block-library/blocks/group/editor-rtl.css 647 B
build/block-library/blocks/group/editor.css 647 B
build/block-library/blocks/group/style-rtl.css 58 B
build/block-library/blocks/group/style.css 58 B
build/block-library/blocks/group/theme-rtl.css 79 B
build/block-library/blocks/group/theme.css 79 B
build/block-library/blocks/heading/style-rtl.css 188 B
build/block-library/blocks/heading/style.css 188 B
build/block-library/blocks/html/editor-rtl.css 335 B
build/block-library/blocks/html/editor.css 337 B
build/block-library/blocks/image/editor-rtl.css 834 B
build/block-library/blocks/image/editor.css 831 B
build/block-library/blocks/image/style-rtl.css 1.59 kB
build/block-library/blocks/image/style.css 1.58 kB
build/block-library/blocks/image/theme-rtl.css 126 B
build/block-library/blocks/image/theme.css 126 B
build/block-library/blocks/image/view.min.js 2 kB
build/block-library/blocks/latest-comments/style-rtl.css 355 B
build/block-library/blocks/latest-comments/style.css 354 B
build/block-library/blocks/latest-posts/editor-rtl.css 213 B
build/block-library/blocks/latest-posts/editor.css 212 B
build/block-library/blocks/latest-posts/style-rtl.css 477 B
build/block-library/blocks/latest-posts/style.css 476 B
build/block-library/blocks/list/style-rtl.css 91 B
build/block-library/blocks/list/style.css 91 B
build/block-library/blocks/media-text/editor-rtl.css 264 B
build/block-library/blocks/media-text/editor.css 264 B
build/block-library/blocks/media-text/style-rtl.css 504 B
build/block-library/blocks/media-text/style.css 503 B
build/block-library/blocks/more/editor-rtl.css 427 B
build/block-library/blocks/more/editor.css 427 B
build/block-library/blocks/navigation-link/editor-rtl.css 663 B
build/block-library/blocks/navigation-link/editor.css 664 B
build/block-library/blocks/navigation-link/style-rtl.css 103 B
build/block-library/blocks/navigation-link/style.css 103 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 295 B
build/block-library/blocks/navigation-submenu/editor.css 294 B
build/block-library/blocks/navigation/editor-rtl.css 2.24 kB
build/block-library/blocks/navigation/editor.css 2.25 kB
build/block-library/blocks/navigation/style-rtl.css 2.24 kB
build/block-library/blocks/navigation/style.css 2.23 kB
build/block-library/blocks/navigation/view.min.js 1.06 kB
build/block-library/blocks/nextpage/editor-rtl.css 392 B
build/block-library/blocks/nextpage/editor.css 392 B
build/block-library/blocks/page-list/editor-rtl.css 398 B
build/block-library/blocks/page-list/editor.css 399 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 236 B
build/block-library/blocks/paragraph/editor.css 236 B
build/block-library/blocks/paragraph/style-rtl.css 335 B
build/block-library/blocks/paragraph/style.css 335 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 506 B
build/block-library/blocks/post-comments-form/style.css 506 B
build/block-library/blocks/post-date/style-rtl.css 62 B
build/block-library/blocks/post-date/style.css 62 B
build/block-library/blocks/post-excerpt/editor-rtl.css 71 B
build/block-library/blocks/post-excerpt/editor.css 71 B
build/block-library/blocks/post-excerpt/style-rtl.css 141 B
build/block-library/blocks/post-excerpt/style.css 141 B
build/block-library/blocks/post-featured-image/editor-rtl.css 582 B
build/block-library/blocks/post-featured-image/editor.css 580 B
build/block-library/blocks/post-featured-image/style-rtl.css 341 B
build/block-library/blocks/post-featured-image/style.css 341 B
build/block-library/blocks/post-navigation-link/style-rtl.css 215 B
build/block-library/blocks/post-navigation-link/style.css 214 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 437 B
build/block-library/blocks/post-template/style.css 436 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-time-to-read/style-rtl.css 70 B
build/block-library/blocks/post-time-to-read/style.css 70 B
build/block-library/blocks/post-title/style-rtl.css 100 B
build/block-library/blocks/post-title/style.css 100 B
build/block-library/blocks/preformatted/style-rtl.css 125 B
build/block-library/blocks/preformatted/style.css 125 B
build/block-library/blocks/pullquote/editor-rtl.css 134 B
build/block-library/blocks/pullquote/editor.css 134 B
build/block-library/blocks/pullquote/style-rtl.css 334 B
build/block-library/blocks/pullquote/style.css 334 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 121 B
build/block-library/blocks/query-pagination-numbers/editor.css 118 B
build/block-library/blocks/query-pagination/editor-rtl.css 220 B
build/block-library/blocks/query-pagination/editor.css 208 B
build/block-library/blocks/query-pagination/style-rtl.css 298 B
build/block-library/blocks/query-pagination/style.css 295 B
build/block-library/blocks/query-title/style-rtl.css 64 B
build/block-library/blocks/query-title/style.css 64 B
build/block-library/blocks/query/editor-rtl.css 485 B
build/block-library/blocks/query/editor.css 484 B
build/block-library/blocks/query/style-rtl.css 312 B
build/block-library/blocks/query/style.css 308 B
build/block-library/blocks/query/view.min.js 633 B
build/block-library/blocks/quote/style-rtl.css 223 B
build/block-library/blocks/quote/style.css 223 B
build/block-library/blocks/quote/theme-rtl.css 221 B
build/block-library/blocks/quote/theme.css 225 B
build/block-library/blocks/read-more/style-rtl.css 131 B
build/block-library/blocks/read-more/style.css 131 B
build/block-library/blocks/rss/editor-rtl.css 148 B
build/block-library/blocks/rss/editor.css 148 B
build/block-library/blocks/rss/style-rtl.css 288 B
build/block-library/blocks/rss/style.css 287 B
build/block-library/blocks/search/editor-rtl.css 177 B
build/block-library/blocks/search/editor.css 177 B
build/block-library/blocks/search/style-rtl.css 603 B
build/block-library/blocks/search/style.css 603 B
build/block-library/blocks/search/theme-rtl.css 113 B
build/block-library/blocks/search/theme.css 113 B
build/block-library/blocks/search/view.min.js 466 B
build/block-library/blocks/separator/editor-rtl.css 145 B
build/block-library/blocks/separator/editor.css 145 B
build/block-library/blocks/separator/style-rtl.css 234 B
build/block-library/blocks/separator/style.css 234 B
build/block-library/blocks/separator/theme-rtl.css 195 B
build/block-library/blocks/separator/theme.css 195 B
build/block-library/blocks/shortcode/editor-rtl.css 322 B
build/block-library/blocks/shortcode/editor.css 322 B
build/block-library/blocks/site-logo/editor-rtl.css 752 B
build/block-library/blocks/site-logo/editor.css 752 B
build/block-library/blocks/site-logo/style-rtl.css 204 B
build/block-library/blocks/site-logo/style.css 204 B
build/block-library/blocks/site-tagline/editor-rtl.css 87 B
build/block-library/blocks/site-tagline/editor.css 87 B
build/block-library/blocks/site-title/editor-rtl.css 116 B
build/block-library/blocks/site-title/editor.css 116 B
build/block-library/blocks/site-title/style-rtl.css 57 B
build/block-library/blocks/site-title/style.css 57 B
build/block-library/blocks/social-link/editor-rtl.css 183 B
build/block-library/blocks/social-link/editor.css 183 B
build/block-library/blocks/social-links/editor-rtl.css 677 B
build/block-library/blocks/social-links/editor.css 676 B
build/block-library/blocks/social-links/style-rtl.css 1.44 kB
build/block-library/blocks/social-links/style.css 1.43 kB
build/block-library/blocks/spacer/editor-rtl.css 345 B
build/block-library/blocks/spacer/editor.css 345 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 432 B
build/block-library/blocks/table/editor.css 432 B
build/block-library/blocks/table/style-rtl.css 640 B
build/block-library/blocks/table/style.css 639 B
build/block-library/blocks/table/theme-rtl.css 145 B
build/block-library/blocks/table/theme.css 145 B
build/block-library/blocks/tag-cloud/style-rtl.css 253 B
build/block-library/blocks/tag-cloud/style.css 253 B
build/block-library/blocks/template-part/editor-rtl.css 400 B
build/block-library/blocks/template-part/editor.css 400 B
build/block-library/blocks/template-part/theme-rtl.css 102 B
build/block-library/blocks/template-part/theme.css 102 B
build/block-library/blocks/term-description/style-rtl.css 108 B
build/block-library/blocks/term-description/style.css 108 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 165 B
build/block-library/blocks/text-columns/style.css 165 B
build/block-library/blocks/verse/style-rtl.css 98 B
build/block-library/blocks/verse/style.css 98 B
build/block-library/blocks/video/editor-rtl.css 553 B
build/block-library/blocks/video/editor.css 554 B
build/block-library/blocks/video/style-rtl.css 186 B
build/block-library/blocks/video/style.css 186 B
build/block-library/blocks/video/theme-rtl.css 126 B
build/block-library/blocks/video/theme.css 126 B
build/block-library/classic-rtl.css 179 B
build/block-library/classic.css 179 B
build/block-library/common-rtl.css 1.1 kB
build/block-library/common.css 1.09 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 12.2 kB
build/block-library/editor.css 12.1 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/index.min.js 207 kB
build/block-library/reset-rtl.css 470 B
build/block-library/reset.css 470 B
build/block-library/style-rtl.css 14.2 kB
build/block-library/style.css 14.2 kB
build/block-library/theme-rtl.css 683 B
build/block-library/theme.css 688 B
build/block-serialization-default-parser/index.min.js 1.12 kB
build/block-serialization-spec-parser/index.min.js 2.87 kB
build/blocks/index.min.js 51.6 kB
build/commands/index.min.js 15.5 kB
build/commands/style-rtl.css 922 B
build/commands/style.css 918 B
build/components/index.min.js 256 kB
build/components/style-rtl.css 11.7 kB
build/components/style.css 11.7 kB
build/compose/index.min.js 12.7 kB
build/core-commands/index.min.js 2.73 kB
build/core-data/index.min.js 70.4 kB
build/customize-widgets/index.min.js 12 kB
build/customize-widgets/style-rtl.css 1.48 kB
build/customize-widgets/style.css 1.48 kB
build/data-controls/index.min.js 641 B
build/data/index.min.js 8.81 kB
build/date/index.min.js 18 kB
build/deprecated/index.min.js 458 B
build/dom-ready/index.min.js 325 B
build/dom/index.min.js 4.64 kB
build/edit-post/classic-rtl.css 547 B
build/edit-post/classic.css 547 B
build/edit-post/index.min.js 35.7 kB
build/edit-post/style-rtl.css 7.83 kB
build/edit-post/style.css 7.82 kB
build/edit-site/index.min.js 186 kB
build/edit-site/style-rtl.css 14 kB
build/edit-site/style.css 14 kB
build/edit-widgets/index.min.js 17 kB
build/edit-widgets/style-rtl.css 4.78 kB
build/edit-widgets/style.css 4.78 kB
build/editor/index.min.js 45.8 kB
build/editor/style-rtl.css 3.51 kB
build/editor/style.css 3.51 kB
build/element/index.min.js 4.82 kB
build/escape-html/index.min.js 537 B
build/format-library/index.min.js 7.8 kB
build/format-library/style-rtl.css 553 B
build/format-library/style.css 553 B
build/hooks/index.min.js 1.54 kB
build/html-entities/index.min.js 445 B
build/i18n/index.min.js 3.58 kB
build/interactivity/index.min.js 11.4 kB
build/is-shallow-equal/index.min.js 526 B
build/keyboard-shortcuts/index.min.js 1.72 kB
build/keycodes/index.min.js 1.86 kB
build/list-reusable-blocks/index.min.js 2.2 kB
build/list-reusable-blocks/style-rtl.css 832 B
build/list-reusable-blocks/style.css 832 B
build/media-utils/index.min.js 2.9 kB
build/notices/index.min.js 946 B
build/nux/index.min.js 1.99 kB
build/nux/style-rtl.css 736 B
build/nux/style.css 731 B
build/patterns/index.min.js 3.72 kB
build/patterns/style-rtl.css 543 B
build/patterns/style.css 543 B
build/plugins/index.min.js 1.79 kB
build/preferences-persistence/index.min.js 1.83 kB
build/preferences/index.min.js 1.24 kB
build/primitives/index.min.js 975 B
build/priority-queue/index.min.js 1.54 kB
build/private-apis/index.min.js 961 B
build/react-i18n/index.min.js 614 B
build/react-refresh-entry/index.min.js 9.48 kB
build/react-refresh-runtime/index.min.js 7.28 kB
build/redux-routine/index.min.js 2.69 kB
build/reusable-blocks/index.min.js 2.75 kB
build/reusable-blocks/style-rtl.css 242 B
build/reusable-blocks/style.css 242 B
build/rich-text/index.min.js 10.2 kB
build/router/index.min.js 1.78 kB
build/server-side-render/index.min.js 1.93 kB
build/shortcode/index.min.js 1.4 kB
build/style-engine/index.min.js 1.97 kB
build/token-list/index.min.js 579 B
build/url/index.min.js 3.84 kB
build/vendors/inert-polyfill.min.js 2.47 kB
build/vendors/react-dom.min.js 41.8 kB
build/vendors/react.min.js 4.01 kB
build/viewport/index.min.js 959 B
build/warning/index.min.js 250 B
build/widgets/index.min.js 7.23 kB
build/widgets/style-rtl.css 1.15 kB
build/widgets/style.css 1.15 kB
build/wordcount/index.min.js 1.03 kB

compressed-size-action

@desrosj
desrosj marked this pull request as ready for review September 28, 2026 19:59
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #83694 September 28, 2026 23:46
@desrosj
desrosj added this pull request to stack #83741 September 28, 2026 23:46
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from e1c6ca2 to fe5cdc6 Compare October 2, 2026 20:00
@desrosj
desrosj removed this pull request from stack #83741 October 7, 2026 18:11
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-wp-bind-esc-url-test to wp/6.4 October 7, 2026 18:12
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from fe5cdc6 to 9e88777 Compare October 7, 2026 18:14
@github-actions github-actions Bot added [Tool] WP Scripts /packages/scripts [Tool] Env /packages/env labels Oct 7, 2026
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-wp-bind-esc-url-test October 7, 2026 18:20
@desrosj
desrosj added this pull request to stack #84191 October 7, 2026 18:20
@desrosj
desrosj removed this pull request from stack #84191 October 8, 2026 21:38
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-wp-bind-esc-url-test to wp/6.4 October 8, 2026 21:39
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from 9e88777 to c2696e9 Compare October 8, 2026 21:40
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-wp-bind-esc-url-test October 8, 2026 21:41
@desrosj
desrosj added this pull request to stack #84353 October 8, 2026 21:42
@github-actions github-actions Bot removed [Tool] WP Scripts /packages/scripts [Tool] Env /packages/env labels Oct 8, 2026
@desrosj
desrosj removed this pull request from stack #84353 October 9, 2026 23:54
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-wp-bind-esc-url-test to wp/6.4 October 9, 2026 23:55
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from c2696e9 to 1b2d390 Compare October 9, 2026 23:56
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/fix-wp-bind-esc-url-test October 9, 2026 23:58
@desrosj
desrosj added this pull request to stack #84480 October 9, 2026 23:58
@desrosj desrosj closed this Oct 13, 2026
@desrosj desrosj reopened this Oct 13, 2026
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from 1b2d390 to c06b3f6 Compare October 13, 2026 01:54
@desrosj desrosj changed the title Repair wp/6.4 branch Actions: retry Puppeteer plugin activation/deactivation on timeout Repair wp/6.4 branch Actions: Retry Puppeteer plugin activation/deactivation on timeout Oct 16, 2026
@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from c06b3f6 to 6abd11f Compare October 19, 2026 17:06
@desrosj
desrosj removed this pull request from stack #84480 October 21, 2026 19:42
@desrosj
desrosj added this pull request to stack #85340 October 21, 2026 19:43

@andrewserong andrewserong left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me here. A couple of non-blocking notes:

  • I'd probably skip adding the changelog entry unless we're intending to publish an update to the package? (I assume not)
  • While this adds additional attempts and ups the timeout on each to 60000, the overall test run might still reach the runner's timeout? E.g. on this branch I think it has a cap at 100000 if I'm reading this right:
    // The Jest timeout is increased because these tests are a bit slow.
    jest.setTimeout( PUPPETEER_TIMEOUT || 100000 );

For that second point above, I very much relied on Claude to help me locate the line and I haven't verified that this actual run really uses that timeout value, but it looks legit enough.

The consequence would be that we mightn't ever get the full 3 retries that this PR attempts. Not a reason to block this PR (it can still manage a second attempt), but just noting in case you were expecting the full 3 retries and it doesn't quite make it.

In any case, LGTM (I wouldn't worry about tweaking this PR further, especially given its place in the stack)

@desrosj
desrosj force-pushed the fix-actions-6.4/retry-plugin-activation-timeout branch from 15d9714 to 874a225 Compare October 23, 2026 18:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants