Skip to content

Repair wp/6.4 branch Actions: Upgrade Node.js from 16 to 20 - #83678

Open
desrosj wants to merge 1 commit into
fix-actions-6.4/pin-runner-imagesfrom
fix-actions-6.4/upgrade-node-to-20
Open

Repair wp/6.4 branch Actions: Upgrade Node.js from 16 to 20#83678
desrosj wants to merge 1 commit into
fix-actions-6.4/pin-runner-imagesfrom
fix-actions-6.4/upgrade-node-to-20

Conversation

@desrosj

@desrosj desrosj commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82929.

What?

Upgrades this branch from Node.js 16 to 20:

  • .nvmrc: 16 → 20.
  • engines in package.json and package-lock.json: node >=20.10.0, npm >=10.2.3.
  • The Node.js version mentioned in getting-started-with-code-contribution.md and platform-docs/docs/intro.md.

These match trunk's own upgrade in #56331 (December 2023, shortly after this branch was cut). No dependencies needed updating, and every workflow already reads the version from .nvmrc.

Why?

Node.js 16 is end-of-life, and later layers in this stack need a newer version, including the Playwright upgrade to fix browser installs on Ubuntu 24.04 runners.

Testing

  • trunk's upgrade changed no dependencies, and neither does this one: the package-lock.json change is only the root engines field.
  • The only dependencies with native install steps (@parcel/watcher, @swc/core, esbuild) install and load under both Node.js 16 and 20.
  • Published packages aren't affected: their build targets browsers, not the Node.js version running the build.

The Compressed Size check is expected to fail on this PR. It builds the base branch with this PR's Node.js 20, and the base branch's engines field only allows npm 8. PRs above this one are not affected.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 28, 2026
@desrosj desrosj self-assigned this Sep 28, 2026
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58ef7a97-a299-4a6f-beb9-a6cc8b868b49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #83694 September 28, 2026 19:40
This was referenced Sep 28, 2026
Closed
Open
@desrosj
desrosj marked this pull request as ready for review September 28, 2026 19:55
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #83694 September 28, 2026 23:46
@desrosj
desrosj added this pull request to stack #83741 September 28, 2026 23:46
@desrosj
desrosj removed this pull request from stack #83741 October 7, 2026 18:11
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 October 7, 2026 18:12
@desrosj
desrosj force-pushed the fix-actions-6.4/upgrade-node-to-20 branch from 5b1da4e to 1c8c0ea Compare October 7, 2026 18:14
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images October 7, 2026 18:20
@desrosj
desrosj added this pull request to stack #84191 October 7, 2026 18:20
@desrosj
desrosj removed this pull request from stack #84191 October 8, 2026 21:38
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 October 8, 2026 21:38
@desrosj
desrosj force-pushed the fix-actions-6.4/upgrade-node-to-20 branch from 1c8c0ea to a341766 Compare October 8, 2026 21:40
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images October 8, 2026 21:41
@desrosj
desrosj added this pull request to stack #84353 October 8, 2026 21:42
@desrosj
desrosj removed this pull request from stack #84353 October 9, 2026 23:54
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 October 9, 2026 23:54
@desrosj
desrosj force-pushed the fix-actions-6.4/upgrade-node-to-20 branch from a341766 to 3ff8b88 Compare October 9, 2026 23:56
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images October 9, 2026 23:58
@desrosj
desrosj added this pull request to stack #84480 October 9, 2026 23:58
This was referenced Oct 15, 2026
Open
Open
ramonjd
ramonjd approved these changes Oct 21, 2026
View reviewed changes

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches trunk's #56331. Everything red here passes at the top of this stack (#85134).

@desrosj
desrosj removed this pull request from stack #84480 October 21, 2026 19:42
@desrosj
desrosj added this pull request to stack #85340 October 21, 2026 19:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ramonjd