Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.63 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
b779822 to
b7db9b3
Compare
b7db9b3 to
89110ab
Compare
89110ab to
ed099cb
Compare
wp/6.4 branch Actions: Update third-party actions to their latest releaseswp/6.4 branch Actions: Update GitHub Actions to their latest versions
ntsekouras
left a comment
There was a problem hiding this comment.
LGTM, thanks! This fixes the jobs that were auto-failing because of the retired actions/cache v3 and upload-artifact/download-artifact v3, so Create Block, Mobile, PHPCS and the flaky tests report pass now, with no Node.js 20 warnings left. Playwright and Puppeteer now actually run, and their failures are fixed further up the stack (all pass in #85134).
Moving to upload-artifact v7 brings the artifact name conflicts for the e2e shards, which I think should be a follow-up row on top of the stack: #84853 (comment).
Part of #82929.
What?
Bumps every third-party GitHub Action used on
wp/6.4to its current latest release, pinned to a full-length commit SHA with a version comment:actions/checkoutv4.0.0v7.0.1actions/setup-nodev3.8.1(workflows) /v3.6.0(.github/setup-node/action.yml)v7.0.0actions/upload-artifactv3.1.3v7.0.1actions/cachev3.3.2(workflows) /v3.3.1(.github/setup-node/action.yml)v6.1.0ramsey/composer-installv2.2.04.0.0shivammathur/setup-phpv2.25.52.37.2preactjs/compressed-size-actionv2.5.02.10.0actions/download-artifact@v3(unpinned tag)v8.0.1actions/setup-nodeandactions/cacheeach had their own separately stale pin inside.github/setup-node/action.yml, the composite action most workflows call into to install Node.js and cache dependencies, in addition to the pins used directly in workflow files that don't go through it. Noactions/upload-artifact/mergesub-action reference exists on this branch.actions/download-artifactwas referenced by an unpinned major-version tag (@v3) in a workflow instead of a commit SHA; that reference is now pinned to a full-length SHA like the rest.Why?
These pins were several major releases behind current, missing security fixes, bug fixes, and compatibility updates (including, for
actions/checkoutandactions/upload-artifact, changes required for continued compatibility with GitHub's runner infrastructure going forward). Some references also relied on an unpinned tag rather than a commit SHA, which is a supply-chain risk since a tag can be moved to point at different code after the fact.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.