Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83694
September 28, 2026 19:40
This was referenced Sep 28, 2026
desrosj
marked this pull request as ready for review
September 28, 2026 19:49
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #83694
September 28, 2026 23:46
desrosj
added this pull request to stack #83741
September 28, 2026 23:46
desrosj
removed this pull request from stack #83741
October 7, 2026 18:11
desrosj
changed the base branch from
fix-actions-6.4/remove-rn-workflows
to
wp/6.4
October 7, 2026 18:12
desrosj
force-pushed
the
fix-actions-6.4/disable-cache-for-release-builds
branch
from
October 7, 2026 18:14
c0ab343 to
a11e7a8
Compare
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/remove-rn-workflows
October 7, 2026 18:20
desrosj
added this pull request to stack #84191
October 7, 2026 18:20
desrosj
removed this pull request from stack #84191
October 8, 2026 21:38
desrosj
changed the base branch from
fix-actions-6.4/remove-rn-workflows
to
wp/6.4
October 8, 2026 21:38
desrosj
force-pushed
the
fix-actions-6.4/disable-cache-for-release-builds
branch
from
October 8, 2026 21:40
a11e7a8 to
2074bfa
Compare
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/remove-rn-workflows
October 8, 2026 21:41
desrosj
added this pull request to stack #84353
October 8, 2026 21:42
desrosj
removed this pull request from stack #84353
October 9, 2026 23:54
desrosj
changed the base branch from
fix-actions-6.4/remove-rn-workflows
to
wp/6.4
October 9, 2026 23:54
desrosj
force-pushed
the
fix-actions-6.4/disable-cache-for-release-builds
branch
from
October 9, 2026 23:56
2074bfa to
77eb817
Compare
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/add-job-timeouts
October 9, 2026 23:58
desrosj
added this pull request to stack #84480
October 9, 2026 23:58
|
Size Change: 0 B Total Size: 1.63 MB ℹ️ View Unchanged
|
lucatume
approved these changes
Oct 20, 2026
desrosj
removed this pull request from stack #84480
October 21, 2026 19:42
desrosj
added this pull request to stack #85340
October 21, 2026 19:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82929.
What?
Sets
package-manager-cache: falseexplicitly on everyactions/setup-nodestep inpublish-npm-packages.yml(2 steps).publish-npm-packages.ymlreleasepublish-npm-packages.ymlreleaseWhy?
Cache poisoning is an attack in which a release workflow picks up build state cached by an earlier, less-trusted workflow run. A job that produces a published npm package should install from the lockfile every time.
actions/setup-node'spackage-manager-cacheinput defaults totrue. It currently engages only whenpackage.jsondeclarespackageManager(ordevEngines.packageManager) naming npm — which this branch does not. That means these jobs are uncached by accident, not by intent: adding that field later would silently switch caching back on in the release path with no visible change to any workflow file. Stating it explicitly removes that dependency on unrelated packaging metadata.How?
Ports WordPress/gutenberg#79835, "Disable caching when publishing built assets", adapted for this branch. Upstream routes these jobs through the composite
.github/setup-nodeaction and threads a newcacheinput through to.github/setup-npm; this branch has nosetup-npmcomposite and its release jobs callactions/setup-nodedirectly, so the equivalent input is set on each step instead.build-plugin-zip.yml, which #79835 also changes, is removed from this branch in #83667.This branch's
actions/setup-nodepin inpublish-npm-packages.yml(v3.8.1) predates thepackage-manager-cacheinput, so the setting takes effect once #83669 updates it tov7.0.0.The composite
.github/setup-nodeon this branch is deliberately left alone: it is only ever called by test and automation workflows, none of which publish a release artifact.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code