Skip to content

Repair wp/7.1 branch Actions: Remove the redundant Install NVM step - #83659

Open
desrosj wants to merge 1 commit into
fix-actions-7.1/fix-flaky-router-navigate-testfrom
fix-actions-7.1/remove-install-nvm-step
Open

Repair wp/7.1 branch Actions: Remove the redundant Install NVM step#83659
desrosj wants to merge 1 commit into
fix-actions-7.1/fix-flaky-router-navigate-testfrom
fix-actions-7.1/remove-install-nvm-step

Conversation

@desrosj

@desrosj desrosj commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82781.

What?

Removes the Install NVM step from .github/workflows/performance.yml.

Why?

nvm is already installed on GitHub-hosted Ubuntu runners, in $HOME/.nvm. The step's own output says so (=> nvm is already installed in /home/runner/.nvm, trying to update using git), so on every run it only downloads and re-runs the nvm v0.39.1 install script over the existing copy.

Nothing else in the workflow uses the step: the performance CLI loads nvm itself with source $HOME/.nvm/nvm.sh, which the preinstalled copy provides.

Upstream

trunk no longer has this step. It was removed in #82160 ("Performance tests: Build once and shard the suites across parallel CI jobs") as part of a larger rework of the workflow, which isn't ported here.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 28, 2026
@desrosj desrosj self-assigned this Sep 28, 2026
@desrosj
desrosj added this pull request to stack #83629 September 28, 2026 18:42
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b35e9530-6d21-4ef1-94bc-be49fc0903e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj desrosj mentioned this pull request Sep 28, 2026
Open
@desrosj
desrosj marked this pull request as ready for review September 28, 2026 18:55
@github-actions

github-actions Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from 4487269 to 1b140c1 Compare October 7, 2026 13:42
@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from 1b140c1 to b002c3c Compare October 7, 2026 15:55
@desrosj
desrosj removed this pull request from stack #83629 October 8, 2026 21:07
@desrosj
desrosj changed the base branch from fix-actions-7.1/fix-flaky-router-navigate-test to wp/7.1 October 8, 2026 21:08
@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from b002c3c to 7f25bd9 Compare October 8, 2026 21:08
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/fix-flaky-router-navigate-test October 8, 2026 21:09
@desrosj
desrosj added this pull request to stack #84346 October 8, 2026 21:10
@github-actions

github-actions Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 7.75 MB

From 767f8ca, not the current head. Run

@desrosj
desrosj removed this pull request from stack #84346 October 9, 2026 23:21
@desrosj
desrosj changed the base branch from fix-actions-7.1/fix-flaky-router-navigate-test to wp/7.1 October 9, 2026 23:21
@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from 7f25bd9 to 767f8ca Compare October 9, 2026 23:22
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/fix-flaky-router-navigate-test October 9, 2026 23:23
@desrosj
desrosj added this pull request to stack #84466 October 9, 2026 23:23
@desrosj desrosj mentioned this pull request Oct 15, 2026
Open
@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from 767f8ca to acabdd8 Compare October 19, 2026 17:02
@desrosj
desrosj removed this pull request from stack #84466 October 21, 2026 18:35
@desrosj
desrosj added this pull request to stack #85326 October 21, 2026 18:36
@desrosj
desrosj force-pushed the fix-actions-7.1/remove-install-nvm-step branch from acabdd8 to 7ae776d Compare October 24, 2026 18:02
@desrosj
desrosj removed this pull request from stack #85326 October 24, 2026 18:04
@desrosj
desrosj added this pull request to stack #85508 October 24, 2026 18:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@desrosj