Repository navigation
Repair wp/6.6 branch Actions: Fix flaky Font Library font deletion e2e test - #83656
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.73 MB ℹ️ View Unchanged
|
ee92ab5 to
72df464
Compare
72df464 to
94c56c0
Compare
94c56c0 to
cee5e14
Compare
cee5e14 to
2ffdef0
Compare
2ffdef0 to
5b0506d
Compare
5b0506d to
ba98486
Compare
ba98486 to
275a4a4
Compare
Part of #82784.
What?
Makes the "should allow user to add and remove multiple local font files" test in
test/e2e/specs/site-editor/font-library.spec.jswait for the delete confirmation dialog before clicking its "Delete" button.Why?
The test clicked "Delete" twice in a row. The confirmation dialog opens asynchronously, so the second click could find the first "Delete" button again; the dialog's overlay then covers that button and every retry times out. This branch has the same back-to-back clicks, so the fix is included for consistency with the
wp/6.9andwp/6.8stacks.Upstream
Ports the wait added in
01c3469(#74067) ontrunk. That change also moved this test totest/e2e/specs/admin/font-library.spec.jsalong with a new wp-admin Font Library screen, which this branch doesn't have, so only the wait is ported.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code