Repository navigation
Repair wp/6.9 branch Actions: Fix flaky Font Library font deletion e2e test - #83649
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83631
September 28, 2026 18:15
desrosj
marked this pull request as ready for review
September 28, 2026 18:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
2 times, most recently
from
October 7, 2026 16:00
25ba0cd to
6f309cf
Compare
desrosj
removed this pull request from stack #83631
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-navigate-test
to
wp/6.9
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
from
October 7, 2026 18:16
6f309cf to
5f8e609
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-navigate-test
October 7, 2026 18:18
desrosj
added this pull request to stack #84190
October 7, 2026 18:19
desrosj
removed this pull request from stack #84190
October 8, 2026 21:14
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-navigate-test
to
wp/6.9
October 8, 2026 21:15
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
from
October 8, 2026 21:16
5f8e609 to
0f052e8
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-navigate-test
October 8, 2026 21:18
desrosj
added this pull request to stack #84348
October 8, 2026 21:18
desrosj
removed this pull request from stack #84348
October 9, 2026 23:31
desrosj
changed the base branch from
fix-actions-6.9/fix-flaky-router-navigate-test
to
wp/6.9
October 9, 2026 23:32
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
from
October 9, 2026 23:33
0f052e8 to
5026537
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/fix-flaky-router-navigate-test
October 9, 2026 23:35
desrosj
added this pull request to stack #84470
October 9, 2026 23:35
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
from
October 19, 2026 17:05
5026537 to
ba13caf
Compare
desrosj
removed this pull request from stack #84470
October 21, 2026 18:33
desrosj
added this pull request to stack #85323
October 21, 2026 18:34
ntsekouras
approved these changes
Oct 23, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Same wait as trunk's #74067.
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-font-library-delete-test
branch
from
October 23, 2026 18:20
ba13caf to
afc61f8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Makes the "should allow user to add and remove multiple local font files" test in
test/e2e/specs/site-editor/font-library.spec.jswait for the delete confirmation dialog before clicking its "Delete" button.Why?
The test clicked "Delete" twice in a row. The confirmation dialog opens asynchronously, so the second click could find the first "Delete" button again; the dialog's overlay then covers that button and every retry times out. It failed this way in 7 earlier runs on this stack, on all retries each time.
Upstream
Ports the wait added in
01c3469(#74067) ontrunk. That change also moved this test totest/e2e/specs/admin/font-library.spec.jsalong with a new wp-admin Font Library screen, which this branch doesn't have, so only the wait is ported.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code