Repository navigation
Repair wp/7.0 branch Actions: Fix flaky interactivity router navigate e2e test - #83647
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
marked this pull request as ready for review
September 28, 2026 18:19
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 7, 2026 13:42
e9e1466 to
4e05801
Compare
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 7, 2026 15:58
4e05801 to
70ee637
Compare
desrosj
removed this pull request from stack #83630
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
to
wp/7.0
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 7, 2026 18:16
70ee637 to
90a4319
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
October 7, 2026 18:17
desrosj
added this pull request to stack #84187
October 7, 2026 18:18
desrosj
removed this pull request from stack #84187
October 8, 2026 21:10
desrosj
changed the base branch from
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
to
wp/7.0
October 8, 2026 21:11
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 8, 2026 21:12
90a4319 to
363182f
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
October 8, 2026 21:13
desrosj
added this pull request to stack #84347
October 8, 2026 21:13
desrosj
removed this pull request from stack #84347
October 9, 2026 23:27
desrosj
changed the base branch from
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
to
wp/7.0
October 9, 2026 23:28
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 9, 2026 23:28
363182f to
7a74230
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-dataviews-list-keyboard-tests
October 9, 2026 23:30
desrosj
added this pull request to stack #84468
October 9, 2026 23:30
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 19, 2026 17:04
7a74230 to
0572abe
Compare
desrosj
removed this pull request from stack #84468
October 21, 2026 18:35
desrosj
added this pull request to stack #85325
October 21, 2026 18:35
ntsekouras
approved these changes
Oct 23, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Same as trunk's #80178. The Playwright 4 failure here is the navigable toolbar tests, fixed by AY.
desrosj
force-pushed
the
fix-actions-7.0/fix-flaky-router-navigate-test
branch
from
October 23, 2026 17:27
0572abe to
8d672a3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82782.
What?
Makes the "should update the HTML only for the latest navigation" test in
test/e2e/specs/interactivity/router-navigate.spec.tswait until the browser has requested both linked pages before letting either request through.Why?
The test holds each page request in a
page.route()handler, and the functions that let a request through (resolveLink1andresolveLink2) are only assigned once those handlers run. The test only waited for the page's own navigation counter, which can reach 2 before Playwright has run the handlers, so callingresolveLink2()could fail withTypeError: resolveLink2 is not a function. It failed this way 3 times on this stack, on all retries each time.Upstream
A straight cherry-pick of
e693c18(#80178) fromtrunk.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code