Repair `wp/7.1` branch Actions: Fix flaky interactivity router navigate e2e test by desrosj · Pull Request #83646 · WordPress/gutenberg

desrosj · 2026-09-28T18:13:37Z

Part of #82781.

What?

Makes the "should update the HTML only for the latest navigation" test in test/e2e/specs/interactivity/router-navigate.spec.ts wait until the browser has requested both linked pages before letting either request through.

Why?

The test holds each page request in a page.route() handler, and the functions that let a request through (resolveLink1 and resolveLink2) are only assigned once those handlers run. The test only waited for the page's own navigation counter, which can reach 2 before Playwright has run the handlers, so calling resolveLink2() could fail with TypeError: resolveLink2 is not a function. It hasn't been seen failing on this stack, but this branch has the same test, so the fix is included for consistency.

Upstream

A straight cherry-pick of e693c18 (#80178) from trunk.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

coderabbitai · 2026-09-28T18:13:46Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c74713e9-1e1e-4c04-be7f-65c8fa3ee2fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-28T18:19:04Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

@propsbot add <username> to give props to a GitHub user. Requires write access.
@propsbot remove <username> to leave a user out of the props. Requires write access.
@propsbot refresh to refresh this list. Adding the props-bot label works too.

github-actions · 2026-09-28T18:23:00Z

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 7.75 MB

_{d5b89d0 Run}

🏁 Flaky tests

Show the failures

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Should save the changes in /test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js, passed after 2 failed attempts.

TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js:37:14
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('role=button[name="Visual"i]')

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js:36:55

can be replaced by dragging-and-dropping images from the inserter in /test/e2e/specs/editor/blocks/image.spec.js, passed after 2 failed attempts.

TimeoutError: locator.dragTo: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('region', { name: 'Block Library' }).getByRole('listbox', { name: 'Media List' }).getByRole('option').first()

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:359:5
TimeoutError: locator.dragTo: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('region', { name: 'Block Library' }).getByRole('listbox', { name: 'Media List' }).getByRole('option').first()

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:359:5

should update the URL from the last navigation if only varies in the URL fragment in /test/e2e/specs/interactivity/router-navigate.spec.ts, passed after 1 failed attempt.

Error: expect(locator).toHaveText(expected) failed

Locator:  getByTestId('title')
Expected: "Link 1"
Received: "Main"
Timeout:  5000ms

Call log:
  - Expect "toHaveText" with timeout 5000ms
  - waiting for getByTestId('title')
    14 × locator resolved to <h2 data-testid="title">Main</h2>
       - unexpected value "Main"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigate.spec.ts:163:25

_{d5b89d0 Run}

ntsekouras

LGTM, thanks! Same change as trunk's #80178.

desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 28, 2026

desrosj self-assigned this Sep 28, 2026

desrosj added this pull request to stack #83629 September 28, 2026 18:13

desrosj marked this pull request as ready for review September 28, 2026 18:18

desrosj mentioned this pull request Sep 28, 2026

wp/7.1 branch: Restore automated testing capabilities and GitHub Actions workflows #82781

Open

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from 74cebda to b18f4ca Compare October 7, 2026 13:42

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from b18f4ca to c31c0ef Compare October 7, 2026 15:55

desrosj removed this pull request from stack #83629 October 8, 2026 21:07

desrosj changed the base branch from fix-actions-7.1/update-php-test-matrix to wp/7.1 October 8, 2026 21:08

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from c31c0ef to cb67e1c Compare October 8, 2026 21:08

desrosj changed the base branch from wp/7.1 to fix-actions-7.1/update-php-test-matrix October 8, 2026 21:09

desrosj added this pull request to stack #84346 October 8, 2026 21:10

desrosj removed this pull request from stack #84346 October 9, 2026 23:21

desrosj changed the base branch from fix-actions-7.1/update-php-test-matrix to wp/7.1 October 9, 2026 23:21

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from cb67e1c to 4d8f9ec Compare October 9, 2026 23:22

desrosj changed the base branch from wp/7.1 to fix-actions-7.1/update-php-test-matrix October 9, 2026 23:23

desrosj added this pull request to stack #84466 October 9, 2026 23:23

desrosj mentioned this pull request Oct 15, 2026

Reviewing PR stacks aimed at restoring automated testing capabilities and GitHub Actions workflows for wp/X.Y branches #84853

Open

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from 4d8f9ec to 4fefba4 Compare October 19, 2026 17:02

desrosj removed this pull request from stack #84466 October 21, 2026 18:35

desrosj added this pull request to stack #85326 October 21, 2026 18:36

ntsekouras approved these changes Oct 23, 2026

View reviewed changes

Wait for both navigation requests in the router navigate e2e test.

d5b89d0

desrosj force-pushed the fix-actions-7.1/fix-flaky-router-navigate-test branch from 4fefba4 to d5b89d0 Compare October 24, 2026 18:02

desrosj removed this pull request from stack #85326 October 24, 2026 18:04

desrosj added this pull request to stack #85508 October 24, 2026 18:04

Navigation Menu

Repository navigation

Repair `wp/7.1` branch Actions: Fix flaky interactivity router navigate e2e test - #83646

Repair `wp/7.1` branch Actions: Fix flaky interactivity router navigate e2e test#83646
desrosj wants to merge 1 commit into
fix-actions-7.1/update-php-test-matrixfrom
fix-actions-7.1/fix-flaky-router-navigate-test

desrosj commented Sep 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

ntsekouras left a comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

desrosj commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

Upstream

Use of AI Tools

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR meta 🤖

📦 Bundle size

🏁 Flaky tests

Uh oh!

ntsekouras left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

desrosj commented Sep 28, 2026 •

edited

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

github-actions Bot commented Sep 28, 2026 •

edited

Loading

github-actions Bot commented Sep 28, 2026 •

edited

Loading