Repository navigation
Repair wp/6.7 branch Actions: Fix flaky DataViews list-layout keyboard e2e tests - #83641
Open
desrosj wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83418
September 28, 2026 17:06
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
September 28, 2026 17:44
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 7, 2026 14:18
f6512ae to
8105150
Compare
desrosj
removed this pull request from stack #83418
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.7/stabilize-site-editor-perf-tests
to
wp/6.7
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 7, 2026 18:15
8105150 to
58e1496
Compare
github-actions
Bot
added
[Tool] E2E Test Utils
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/stabilize-site-editor-perf-tests
October 7, 2026 18:18
desrosj
added this pull request to stack #84188
October 7, 2026 18:18
desrosj
removed this pull request from stack #84188
October 8, 2026 21:24
desrosj
changed the base branch from
fix-actions-6.7/stabilize-site-editor-perf-tests
to
wp/6.7
October 8, 2026 21:25
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 8, 2026 21:25
58e1496 to
8e97a08
Compare
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/fix-flaky-metabox-tinymce-race
October 8, 2026 21:27
desrosj
added this pull request to stack #84350
October 8, 2026 21:27
github-actions
Bot
removed
[Tool] E2E Test Utils
desrosj
removed this pull request from stack #84350
October 9, 2026 23:40
desrosj
changed the base branch from
fix-actions-6.7/fix-flaky-metabox-tinymce-race
to
wp/6.7
October 9, 2026 23:41
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 9, 2026 23:42
8e97a08 to
70efb65
Compare
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/fix-flaky-metabox-tinymce-race
October 9, 2026 23:44
desrosj
added this pull request to stack #84474
October 9, 2026 23:44
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 19, 2026 17:05
70efb65 to
c483082
Compare
desrosj
removed this pull request from stack #84474
October 21, 2026 18:31
desrosj
added this pull request to stack #85321
October 21, 2026 18:32
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-dataviews-list-keyboard-tests
branch
from
October 23, 2026 17:41
c483082 to
2b58d20
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82783.
What?
Stabilizes
test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.jswith two upstream fixes:beforeEachfor the Pages list to finish loading (the "Add filter" button and the grid) before any keyboard input, and drops the per-test grid waits this replaces.Why?
This spec hasn't failed in the last 65 end-to-end runs on this stack, but it has the same setup as on
wp/7.0, where it failed 8 of 100 runs. It's included here for consistency.The Pages list on this branch sorts by date, not title (upstream never had to address that, because
trunksorts by title). So the spec gives its two pages explicit dates, as onwp/6.6's #83627, so their order doesn't depend on creation timing. It also deletes existing pages in itsbeforeAll, because pages left behind by earlier specs (such as the draftsmeta-attribute-block.spec.jssaves) would otherwise sort above both.Upstream
Ports
99043f7(#78054) andbdb1750(#78503) fromtrunk, one commit each. On this branchbeforeEachcomes afterafterAll, so the wait is added there, and #78503's renames in the "Search input retains focus while typing" test are left out because this branch doesn't have that test.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code