Repository navigation
Repair wp/6.8 branch Actions: Fix flaky DataViews list-layout keyboard e2e tests - #83640
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
0f56bfc to
3a08108
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3a08108 to
3f3e0f0
Compare
3f3e0f0 to
9f64be5
Compare
9f64be5 to
8dac0dc
Compare
8dac0dc to
8263273
Compare
8263273 to
ac00651
Compare
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! Template hierarchy change makes sense in context.
ac00651 to
ad1bb06
Compare
Part of #82786.
What?
Stabilizes
test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.jswith two upstream fixes, plus a third upstream fix that the second one needs on this branch:beforeEachfor the Pages list to finish loading (the "Add filter" button and the grid) before any keyboard input, and drops the per-test grid waits this replaces.test/e2e/specs/site-editor/template-hierarchy.spec.jscreate its own front page instead of using page ID 2, the "Sample Page" WordPress creates on install.Why?
This spec hasn't failed in the last 48 end-to-end runs on this stack, but it has the same setup as on
wp/7.0, where it failed 8 of 100 runs. It's included here for consistency.Upstream
Ports
99043f7(#78054) andbdb1750(#78503) fromtrunk, one commit each. On this branchbeforeEachcomes afterafterAll, so the wait is added there, and #78503's renames in the "Search input retains focus while typing" test are left out because this branch doesn't have that test.The Template hierarchy change ports
9ebe4c6(#69692), which landed ontrunklong before #78503. Upstream also switched that test to check the editor's document bar, a change from #69690 that this branch doesn't have, so the branch's existing Title block check is kept.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code