Repository navigation
Repair wp/6.5 branch Actions: Fix flaky block switcher columns-range e2e test - #83623
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
e73c816 to
e29534e
Compare
e29534e to
de5a174
Compare
de5a174 to
7d16db2
Compare
7d16db2 to
e3b3890
Compare
e3b3890 to
58c374d
Compare
58c374d to
4245043
Compare
4245043 to
4ba0770
Compare
tellthemachines
left a comment
There was a problem hiding this comment.
Comparing with previous PRs on this stack where this test is failing, this is looking pretty good with the fix! It also matches the current state of the test on trunk (minus the delay).
4ba0770 to
9c3a38a
Compare
Part of #82928.
What?
Changes how
test/e2e/specs/editor/various/block-switcher.spec.js's "Should show Columns block only if selected blocks are between limits (1-6)" test makes its multi-block selection: instead of holdingShiftand pressingArrowUp, it pressesprimary+atwice with a short delay, the same way the neighboring "Should NOT show…" test does.Why?
Shift+ArrowUpextends the text selection into a multi-block selection asynchronously, and the test clicked the toolbar's "Multiple blocks selected" button immediately afterwards. That could race the selection update and time out waiting for the button. Theprimary+adouble press reliably reaches the same multi-block state, and the delay avoids thepressKeys()race fixed for the neighboring test in the PR directly below this one.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code