Repository navigation
Repair wp/6.5 branch Actions: Fix flaky block switcher max-columns e2e test - #83622
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
added this pull request to stack #83624
September 28, 2026 15:22
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
September 28, 2026 17:09
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #83624
September 28, 2026 18:01
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.5
September 28, 2026 18:01
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
September 28, 2026 18:02
d23b9cc to
af93200
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
September 28, 2026 18:03
desrosj
added this pull request to stack #83645
September 28, 2026 18:03
desrosj
removed this pull request from stack #83645
September 28, 2026 23:45
desrosj
added this pull request to stack #83740
September 28, 2026 23:45
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 2, 2026 20:00
af93200 to
689a410
Compare
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 7, 2026 14:19
689a410 to
705a788
Compare
desrosj
removed this pull request from stack #83740
October 7, 2026 18:12
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.5
October 7, 2026 18:13
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 7, 2026 18:15
705a788 to
b3aa279
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
October 7, 2026 18:17
desrosj
added this pull request to stack #84186
October 7, 2026 18:17
desrosj
removed this pull request from stack #84186
October 8, 2026 18:31
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.5
October 8, 2026 18:32
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
October 8, 2026 18:40
desrosj
added this pull request to stack #84338
October 8, 2026 18:40
desrosj
removed this pull request from stack #84338
October 8, 2026 21:33
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.5
October 8, 2026 21:34
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 8, 2026 21:35
b3aa279 to
a9e8a5a
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
October 8, 2026 21:36
desrosj
added this pull request to stack #84352
October 8, 2026 21:37
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
removed this pull request from stack #84352
October 9, 2026 23:49
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
to
wp/6.5
October 9, 2026 23:50
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 9, 2026 23:51
a9e8a5a to
a7deccc
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-openverse-image-drag-and-drop-test
October 9, 2026 23:53
desrosj
added this pull request to stack #84478
October 9, 2026 23:53
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 19, 2026 17:06
a7deccc to
abebe58
Compare
tellthemachines
approved these changes
Oct 20, 2026
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
I was unable to get the e2e to run locally on the wp/6.5 branch but that might not be too relevant as often these flakies only manifest on CI. I haven't seen this particular test failing on previous PRs from this stack such as #83002, but the fixed test is still passing after a re-run so at least it's not making it worse 😅
Be interesting to know why it's only flaky on the 6.5 branch though, because later branches (up until trunk) don't have this delay.
Member
Author
Can you share a bit of how you went about this? If you were using this PR, then it is missing some changes that are required for the necessary tooling to function (thay come further up in the stack).
Looking back through my notes and session logs, it seems that this was eventually ruled out as a true flaky test, even though there were a few instances where it failed. However, because of it's place in the stack (removing it would require pushing many rebased branches), the fact that it defensively guards against a potential issue, and that it touches test files only, I chose to leave it. |
Contributor
Worse, I was trying on the wp/6.5 branch 😅 that explains it! |
desrosj
removed this pull request from stack #84478
October 21, 2026 19:41
desrosj
added this pull request to stack #85338
October 21, 2026 19:42
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-block-switcher-max-columns-test
branch
from
October 23, 2026 17:51
abebe58 to
f705c9f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82928.
What?
Passes a
delayto the repeatedprimary+akey press intest/e2e/specs/editor/various/block-switcher.spec.js's "Should NOT show Columns transform only if selected blocks are more than max limit(6)" test:pageUtils.pressKeys( 'primary+a', { times: 2, delay: 50 } ).Why?
The test selects all seven blocks by pressing
primary+atwice: the first press selects the text in the current block, and the second expands that to a multi-block selection.pressKeys()only waits between repeated presses when adelayis passed, so without one the two presses fire back to back, and the second can arrive before the block editor has applied the first: the block editor'suseSelectAllhandler only expands a selection the browser has already made. The multi-block selection then never happens and the test fails intermittently. A short delay lets the second press see the first one's effect.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code