Skip to content

Tests: Use strict assertions in layout, template registry, and theme.json tests #83619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lancewillett merged 1 commit into from
Sep 28, 2026
Merged

Tests: Use strict assertions in layout, template registry, and theme.json tests #83619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpunit/block-supports/layout-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ public function test_layout_support_flag_renders_consistent_container_hash( $blo
}
}

$this->assertEquals(
$this->assertSame(
$expected_class,
$actual_class,
'Expected class not found in the rendered output, probably because of a different hash.'
Expand Down
2 changes: 1 addition & 1 deletion phpunit/class-wp-block-templates-registry-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function test_unregister() {

$unregistered_template = self::$registry->unregister( $template_name );

$this->assertEquals( $template, $unregistered_template, 'Unregistered template should be the same as the registered one.' );
$this->assertSame( $template, $unregistered_template, 'Unregistered template should be the same as the registered one.' );
$this->assertFalse( self::$registry->is_registered( $template_name ), 'Template should not be registered after unregistering.' );
}
}
4 changes: 2 additions & 2 deletions phpunit/class-wp-theme-json-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8021,7 +8021,7 @@ public function test_return_block_node_paths() {
),
);

$this->assertEquals( $expected, $block_nodes );
$this->assertSame( $expected, $block_nodes );
}

/**
Expand Down Expand Up @@ -8100,7 +8100,7 @@ public function test_return_block_node_paths_with_variations() {
),
);

$this->assertEquals( $expected, $block_nodes );
$this->assertSame( $expected, $block_nodes );
}

public function test_merge_incoming_data_duotone_presets_with_block_level_default_disabled() {
Expand Down
Loading