Skip to content

Combobox: Label popup dialogs in stories #83476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 1 commit into from
Sep 24, 2026
Merged

Combobox: Label popup dialogs in stories #83476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/ui/src/form/primitives/combobox/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const Default: Story = {
items: ITEMS,
children: [
<Combobox.Trigger aria-label="Fruit" key="trigger" />,
<Combobox.Popup key="popup">
<Combobox.Popup aria-label="Fruit" key="popup">
<div style={ inputWrapperStyle }>
<Combobox.Input aria-label="Search" placeholder="Search" />
</div>
Expand Down Expand Up @@ -92,7 +92,7 @@ export const Compact: Story = {
aria-label="Fruit"
key="trigger"
/>,
<Combobox.Popup key="popup">
<Combobox.Popup aria-label="Fruit" key="popup">
<div style={ inputWrapperStyle }>
<Combobox.Input aria-label="Search" placeholder="Search" />
</div>
Expand Down Expand Up @@ -208,7 +208,7 @@ export const Creatable: Story = {
}
>
<Combobox.Trigger aria-label="Fruit" />
<Combobox.Popup>
<Combobox.Popup aria-label="Fruit">
<div style={ inputWrapperStyle }>
<Combobox.Input
aria-label="Search"
Expand Down Expand Up @@ -301,7 +301,7 @@ export const AsyncItems: Story = {
} }
>
<Combobox.Trigger aria-label="Fruit" />
<Combobox.Popup>
<Combobox.Popup aria-label="Fruit">
<div style={ inputWrapperStyle }>
<Combobox.Input
aria-label="Search"
Expand Down Expand Up @@ -374,7 +374,7 @@ export const WithCustomTriggerAndItem: Story = {
</span>
) }
</Combobox.Trigger>,
<Combobox.Popup key="popup">
<Combobox.Popup aria-label="Fruit" key="popup">
<div style={ inputWrapperStyle }>
<Combobox.Input aria-label="Search" placeholder="Search" />
</div>
Expand Down Expand Up @@ -422,7 +422,7 @@ export const Grouped: Story = {
items: GROUPED_ITEMS,
children: [
<Combobox.Trigger aria-label="Fruit" key="trigger" />,
<Combobox.Popup key="popup">
<Combobox.Popup aria-label="Fruit" key="popup">
<div style={ inputWrapperStyle }>
<Combobox.Input aria-label="Search" placeholder="Search" />
</div>
Expand Down Expand Up @@ -480,6 +480,7 @@ export const WithCustomZIndex: Story = {
children: [
<Combobox.Trigger aria-label="Fruit" key="trigger" />,
<Combobox.Popup
aria-label="Fruit"
positioner={
<Combobox.Positioner
style={ {
Expand Down
Loading