Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83413
September 23, 2026 21:51
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
September 28, 2026 15:14
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
desrosj
removed this pull request from stack #83413
September 28, 2026 15:44
desrosj
changed the base branch from
fix-actions-6.9/ignore-browserslist-old-data
to
wp/6.9
September 28, 2026 15:45
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
September 28, 2026 15:46
60bc6ba to
cd3b55c
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/ignore-browserslist-old-data
September 28, 2026 15:46
desrosj
added this pull request to stack #83631
September 28, 2026 15:46
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 7, 2026 13:43
cd3b55c to
e313441
Compare
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 7, 2026 16:00
e313441 to
ef252b2
Compare
desrosj
removed this pull request from stack #83631
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.9/ignore-browserslist-old-data
to
wp/6.9
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 7, 2026 18:16
ef252b2 to
cebb2c5
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/ignore-browserslist-old-data
October 7, 2026 18:18
desrosj
added this pull request to stack #84190
October 7, 2026 18:19
desrosj
removed this pull request from stack #84190
October 8, 2026 21:14
desrosj
changed the base branch from
fix-actions-6.9/ignore-browserslist-old-data
to
wp/6.9
October 8, 2026 21:15
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 8, 2026 21:16
cebb2c5 to
ec0374f
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/ignore-browserslist-old-data
October 8, 2026 21:18
desrosj
added this pull request to stack #84348
October 8, 2026 21:18
desrosj
removed this pull request from stack #84348
October 9, 2026 23:31
desrosj
changed the base branch from
fix-actions-6.9/ignore-browserslist-old-data
to
wp/6.9
October 9, 2026 23:31
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 9, 2026 23:33
ec0374f to
5ff115c
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/ignore-browserslist-old-data
October 9, 2026 23:35
desrosj
added this pull request to stack #84470
October 9, 2026 23:35
desrosj
added
[Type] Build Tooling
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 19, 2026 17:05
5ff115c to
863658f
Compare
desrosj
removed this pull request from stack #84470
October 21, 2026 18:33
desrosj
added this pull request to stack #85323
October 21, 2026 18:34
desrosj
force-pushed
the
fix-actions-6.9/fix-flaky-metabox-tinymce-init-race
branch
from
October 23, 2026 18:20
863658f to
9b64d8f
Compare
ntsekouras
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Replaces the meta box E2E test's iframe-presence wait with a wait on TinyMCE's own
initializedflag, and adds the same wait after switching back to Visual mode. No change to what the test asserts.Why?
test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.jsswitches the meta box's TinyMCE instance out of Visual mode and types into the textarea. It guarded that switch with:That waits for the editor iframe element to be attached, which happens early in TinyMCE's startup — not at the end of it. The comment above it already claimed the intent was to wait "for it to initialize"; this makes the code actually do that.
When the mode switch lands inside that window, two things can go wrong: TinyMCE flips the editor back to Visual once initialization completes, discarding the typed text, and
getSelection()can return null while TinyMCE restores the cursor position. Both surface as intermittent failures inend2end-test.yml.Waiting on
window.tinyMCE.get( 'test_tinymce_id' ).initializedcloses the window, because that flag is set only after startup finishes. The bundled TinyMCE is 4.9.11 on every WordPress version these branches pin, and it defineswindow.tinyMCE, returns the instance fromEditorManager.get( id ), and sets.initializedon it.This is a straight port of
631bcb2(#78631) fromtrunk. The mode-switch button name is branch-specific — WordPress renamed that tab fromTexttoCodein WordPress 6.8, and this branch pins its test WordPress accordingly — so the selector is deliberately left alone.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code