Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4ef8b48 to
c58763b
Compare
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
c58763b to
67e04ed
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
67e04ed to
eeb98ab
Compare
eeb98ab to
04f2d49
Compare
04f2d49 to
f81cac9
Compare
f81cac9 to
25cdb18
Compare
wp/6.8 branch Actions: remove the mobile-unit-js jobwp/6.8 branch Actions: Remove the mobile-unit-js job
25cdb18 to
e595d2d
Compare
tellthemachines
left a comment
There was a problem hiding this comment.
React Native mobile testing is not something a frozen wp/X.Y release branch needs to carry.
This makes perfect sense. Change LGTM!
Part of #82786.
What?
Removes the
mobile-unit-jsjob (job nameMobile) from.github/workflows/unit-test.yml.To be clear: this job is not broken on this branch. Unlike
wp/7.0andwp/6.9, where the same job is hardcoded toif: false, here it still carries the ordinaryif: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}condition, and it runs and passes. It is being removed for scope and consistency, not because it fails.Why?
The job exists only to run
npm run test:native— the React Native mobile unit test suite. The bottom of this stack (#82881) already removed the other React Native CI content from this branch (rnmobile-ios-runner.yml,rnmobile-android-runner.yml, and thegradle-wrapper-validation.ymlworkflow that supported the Android build) on the grounds that React Native mobile testing is not something a frozenwp/X.Yrelease branch needs to carry. This job is the last remaining piece of that same surface, and leaving it behind means this branch keeps maintaining a React Native toolchain — its dependencies, its Jest native config, and thelerna run buildstep it needs — for a mobile app that is never released from this branch.Removing it also brings
unit-test.ymlhere in line withwp/7.0(#82810) andwp/6.9(#82875), where the same job was removed, so the three branches' unit test workflows now have the same job list.What was removed
Only the
mobile-unit-jsjob block. There were no dangling references to clean up:needs:entry naming it (unit-phpneedstest-phpandphpcs;test-phpneedsbuild-assets).outputs:existed solely to feed it.mobile-unit-js.The remaining jobs (
unit-js,unit-js-date,compute-previous-wordpress-version,build-assets,test-php,phpcs,unit-php) and all workflow-level keys are byte-for-byte unchanged.Testing Instructions
CI on this PR should run the
Unit Testsworkflow with theMobilejob no longer present, and all remaining jobs should pass as before.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code