Repository navigation
Repair wp/6.5 branch Actions: fix two flaky e2e tests (Openverse drag-and-drop, block-switcher multi-select race) - #83004
Closed
desrosj wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83006
September 16, 2026 00:34
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #83006
September 21, 2026 15:45
desrosj
added this pull request to stack #83283
September 21, 2026 15:45
desrosj
removed this pull request from stack #83283
September 21, 2026 18:44
desrosj
changed the base branch from
fix-actions-6.5/fix-docker-compose-v2-debug-step
to
wp/6.5
September 21, 2026 18:45
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-e2e-tests
branch
from
September 21, 2026 18:52
bff353f to
3da4904
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-docker-compose-v2-debug-step
September 21, 2026 18:53
desrosj
added this pull request to stack #83288
September 21, 2026 18:53
desrosj
removed this pull request from stack #83288
September 21, 2026 23:45
desrosj
changed the base branch from
fix-actions-6.5/fix-docker-compose-v2-debug-step
to
wp/6.5
September 21, 2026 23:46
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-e2e-tests
branch
from
September 21, 2026 23:48
3da4904 to
43ca9d8
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-docker-compose-v2-debug-step
September 21, 2026 23:52
desrosj
added this pull request to stack #83302
September 21, 2026 23:52
desrosj
removed this pull request from stack #83302
September 22, 2026 17:11
desrosj
changed the base branch from
fix-actions-6.5/fix-docker-compose-v2-debug-step
to
wp/6.5
September 22, 2026 17:12
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-e2e-tests
branch
from
September 22, 2026 17:15
43ca9d8 to
9319fd4
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-activate-theme-navigation-race
September 22, 2026 17:16
desrosj
added this pull request to stack #83397
September 22, 2026 17:16
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
removed this pull request from stack #83397
September 22, 2026 23:10
desrosj
changed the base branch from
fix-actions-6.5/fix-activate-theme-navigation-race
to
wp/6.5
September 22, 2026 23:11
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-e2e-tests
branch
from
September 22, 2026 23:37
9319fd4 to
21509e9
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-activate-theme-navigation-race
September 22, 2026 23:38
desrosj
added this pull request to stack #83416
September 22, 2026 23:38
desrosj
removed this pull request from stack #83416
September 24, 2026 16:33
desrosj
changed the base branch from
fix-actions-6.5/fix-activate-theme-navigation-race
to
wp/6.5
September 24, 2026 16:34
desrosj
force-pushed
the
fix-actions-6.5/fix-flaky-e2e-tests
branch
from
September 24, 2026 16:45
21509e9 to
e73c816
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-activate-theme-navigation-race
September 24, 2026 16:46
desrosj
added this pull request to stack #83503
September 24, 2026 16:46
desrosj
removed this pull request from stack #83503
September 28, 2026 14:45
This was referenced Sep 28, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82928.
What?
Fixes three flaky/unreliable e2e tests on this branch:
test/e2e/specs/editor/blocks/image.spec.js—can be replaced by dragging-and-dropping images from the insertertest/e2e/specs/editor/various/block-switcher.spec.js—Should NOT show Columns transform only if selected blocks are more than max limit(6)test/e2e/specs/editor/various/block-switcher.spec.js—Should show Columns block only if selected blocks are between limits (1-6)Why?
1. Openverse drag-and-drop — The inserter's Openverse media tab (
useMediaResults()inpackages/block-editor/src/components/inserter/media-tab/hooks.js) fetches live from the real, external Openverse API with no local fallback. Combined with Playwright'sdragTo(), any network variability (latency, rate limiting, a transient outage) could make the drag source slow to appear, causing a timeout unrelated to any bug in Gutenberg. Mocked both the search request and the returned images viapage.route(), the same pattern already used for WordPress.org's block directory API intest/e2e/specs/editor/plugins/block-directory.spec.js.2 & 3. Multi-select race (
block-switcher.spec.js) — Both tests select multiple blocks and immediately click a toolbar button that only appears once the editor re-renders into its multi-select state, without waiting for that re-render:pressKeys( 'primary+a', { times: 2 } ), which only waits between repeated presses when an explicitdelayis passed (packages/e2e-test-utils-playwright/src/page-utils/press-keys.ts) — addeddelay: 50.Shift+ArrowUpsequence with no wait at all. Trunk hit and fixed this exact race in this exact test via44cccd6("Upgrade Playwright to v1.42 (Upgrade Playwright to v1.42 #59339)"), replacing it with the samepressKeys( 'primary+a', { times: 2 } )+ delay mechanism as test 2. Ported that fix here.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.