Repository navigation
Repair wp/6.8 branch Actions: Remove SimenB/github-actions-cpu-cores dependency - #82890
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
d037239 to
0c7ad2a
Compare
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
0c7ad2a to
7a1bf0d
Compare
7a1bf0d to
10ad9b0
Compare
10ad9b0 to
ad34608
Compare
ad34608 to
09b8b58
Compare
09b8b58 to
54047db
Compare
wp/6.8 branch Actions: remove SimenB/github-actions-cpu-cores dependencywp/6.8 branch Actions: Remove SimenB/github-actions-cpu-cores dependency
54047db to
2550fea
Compare
Part of #82786.
What?
Removes the
SimenB/github-actions-cpu-coresthird-party action dependency from all three ofunit-test.yml's jobs that use it —unit-js,unit-js-date, andmobile-unit-js— replacing its output with a direct call tonprocin each.Why?
Trunk removed this same dependency from the JS unit test jobs in commit 4d02abd (#78593), reasoning that
nproc(available on every GitHub-hosted Linux runner) reports the same CPU core count directly, without needing an extra third-party action. That commit's diff never touched themobile-unit-jsjob's own copy of the same pattern — trunk'smobile-unit-jsjob had already been removed by an unrelated cleanup (1079391, #76503, two months before #78593 merged), so it never got the same fix. Sincewp/6.8is frozen and still carries that job, its copy of the pattern needed the same treatment applied here: delete theSimenB/github-actions-cpu-coresstep and itsidfrom each of the three jobs, and callnprocdirectly in place ofsteps.cpu-cores.outputs.count.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.