Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ee52c81 to
db2c90d
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed workflow changes are consistent and introduce no blocking issues.
Pull request overview
Removes the third-party CPU-counting action from the unit-test workflow and uses nproc directly.
Changes:
- Removes CPU-core action steps and
MAXWORKERSconfiguration. - Updates affected test commands to use
--maxWorkers="$(nproc)".
File summaries
| File | Summary |
|---|---|
.github/workflows/unit-test.yml |
Replaces CPU-count action usage across all affected jobs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
db2c90d to
ed31c41
Compare
ed31c41 to
809aaba
Compare
809aaba to
07ba93f
Compare
07ba93f to
f3b1755
Compare
f3b1755 to
133b9fe
Compare
133b9fe to
3ea30a3
Compare
3ea30a3 to
b1188c4
Compare
b1188c4 to
019f7a7
Compare
wp/6.9 branch Actions: remove SimenB/github-actions-cpu-cores dependencywp/6.9 branch Actions: Remove SimenB/github-actions-cpu-cores dependency
Part of #82785.
What?
Removes the
SimenB/github-actions-cpu-coresdependency from all three of.github/workflows/unit-test.yml's jobs that use it —unit-js,unit-js-date, andmobile-unit-js(the last one disabled withif: false) — replacing its output with a direct call tonprocin each.Why?
Trunk removed this dependency in 4d02abd (#78593, "Remove dependency used for counting available CPUs") from the
unit-js/unit-js-datejobs. Trunk had already removedmobile-unit-jsin #76503, so that commit never needed to touch it. GitHub-hosted runners already expose the number of available CPU cores directly vianproc, so the extra third-party action and its output plumbing are unnecessary in any of the three jobs. This PR deletes each job'scpu-coresstep/id andMAXWORKERSenv var, and switches each test invocation to--maxWorkers="$(nproc)"directly, matching the pattern trunk already uses elsewhere in this file.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.