Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration and workflow changes are internally consistent and match the stated maintenance-branch objective.
Pull request overview
Pins wp-env to WordPress 6.9 and aligns PHP CI with the maintenance branch’s supported scope.
Changes:
- Uses the WordPress
6.9-branchsource. - Removes obsolete previous-version PHP test matrix logic.
File summaries
| File | Description |
|---|---|
.wp-env.json |
Pins Core to the WordPress 6.9 branch. |
.github/workflows/unit-test.yml |
Simplifies PHP testing to use the pinned Core version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
71e6d21 to
e088649
Compare
e088649 to
55d6fae
Compare
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
55d6fae to
5a6c08c
Compare
5a6c08c to
220c49e
Compare
220c49e to
7ccf667
Compare
7ccf667 to
28393f6
Compare
28393f6 to
a6ef9e2
Compare
a6ef9e2 to
91c88d4
Compare
91c88d4 to
acfba50
Compare
acfba50 to
7b30022
Compare
7b30022 to
f7aeff4
Compare
Part of #82785.
What?
This pins
.wp-env.json's"core"value toWordPress/WordPress#6.9-branch, and removes thewordpresstest matrix dimension, theWP_ENV_COREenvironment variable override, and thecompute-previous-wordpress-versionjob fromunit-test.yml'stest-phpjob.Why?
.wp-env.jsonpinned the wrong release (WordPress/WordPress#6.8.3), and CI overrode it with an unpinnedWP_ENV_CORE: WordPress/WordPress, which tracks Core's trunk. This caused the PHPUnit tests (the "PHP 8.3 on Linux" job) on thewp/6.9branch to fail in a number of places due to significant code divergence between 6.9-era core and current trunk.When
WP_ENV_COREis not set,@wordpress/envfalls back to the value specified within the.wp-env.jsonfile.The
wordpressmatrix dimension existed to test the previous major WordPress version, which is useful for active development but pointless on an outdated branch that is only eligible for security fixes.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.