Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
🟡 Changes recommended
Add action paths to the lint triggers and resolve the failing mobile-unit-js condition.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates wp/6.9 Actions to use trunk’s reusable workflow-lint implementation and removes unsupported composite-action metadata.
Changes:
- References trunk’s remote reusable lint workflow.
- Removes the duplicated local lint workflow.
- Removes the unsupported
typeinput property.
File summaries
| File | Summary |
|---|---|
.github/workflows/workflow-lint.yml |
Updates the lint workflow reference and triggers; action paths remain uncovered, and the remote lint job currently fails on mobile-unit-js’s if: false. |
.github/workflows/reusable-workflow-lint.yml |
Removes the duplicated local reusable workflow. |
.github/setup-node/action.yml |
Removes the unsupported input type declaration. |
Review details
Suppressed comments (1)
.github/workflows/workflow-lint.yml:38
- This caller still triggers only for changes under
.github/workflows/**, so a future change limited to.github/setup-node/action.ymlor one of the packageaction.ymlfiles will not run the remote lint job at all. The trunk lint workflow explicitly includes these action paths, and this PR changes the composite action metadata as well; add the relevant action paths to both thepushandpull_requestpath filters so the lint contract is preserved onwp/6.9.
uses: WordPress/gutenberg/.github/workflows/reusable-workflow-lint.yml@trunk
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Increasing the surface area for linting is not in scope for this PR. |
17891f4 to
aa8aa7f
Compare
aa8aa7f to
ad435bd
Compare
ad435bd to
14ac51a
Compare
14ac51a to
21df8ab
Compare
21df8ab to
d028163
Compare
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
adimoldovan
left a comment
There was a problem hiding this comment.
Approving. The lint failure is fixed by #82875 later in the stack, and the unit test failures also occur on the base PR.
Part of #82785.
What?
.github/workflows/reusable-workflow-lint.ymland pointsworkflow-lint.ymlatWordPress/gutenberg/.github/workflows/reusable-workflow-lint.yml@trunkinstead.wp/X.Ybranches.Why?
This follows the reusable workflow pattern used in https://github.com/WordPress/wordpress-develop/, which significantly decreases the maintenance burden with the actual linting logic always running from trunk's current, maintained version, which eliminates the need to keep the same file updated in older branches.
This also removes the
typekey, which is unsupported for inputs (see #76503).Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.