Skip to content

Repair wp/7.1 branch Actions: Pin wp-env to the correct WordPress Core version - #82791

Open
desrosj wants to merge 2 commits into
fix-actions-7.1/archive-bullseye-security-apt-sourcefrom
fix-actions-7.1/pin-wp-env-core-version
Open

desrosj wants to merge 2 commits into
fix-actions-7.1/archive-bullseye-security-apt-sourcefrom
fix-actions-7.1/pin-wp-env-core-version

Conversation

@desrosj

@desrosj desrosj commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Part of #82781.

What?

Pins .wp-env.json and .wp-env.test.json's WordPress Core source to WordPress/WordPress#7.1-branch, and removes the compute-previous-wordpress-version job, the wordpress test matrix dimension, and the WP_ENV_CORE env var override from unit-test.yml's test-php job entirely.

Why?

Without a pin, wp-env's default WordPress Core source silently tracks Core trunk, meaning this frozen branch's PHP unit tests run against a constantly-moving, unrelated version of WordPress instead of the version this branch is actually meant to be tested against. Pinning to 7.1-branch makes CI deterministic and actually representative of what this branch ships against.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

Summary by CodeRabbit

  • Tests

    • Updated automated PHP testing to run consistently against a single WordPress core version.
    • Simplified the test matrix by removing version-specific variations.
  • Chores

    • Development and test environments now use the WordPress 7.1 branch, providing a consistent core version across local and automated testing.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6af380e-e67c-4593-9e44-6607a5c99093

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f7444ab2-fb80-4f3b-9ddf-c81ea4bf48a7

📥 Commits

Reviewing files that changed from the base of the PR and between 5cd76bd and 68bb56d.

📒 Files selected for processing (3)
  • .github/workflows/unit-test.yml
  • .wp-env.json
  • .wp-env.test.json

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The test environments now use the WordPress 7.1 branch. The PHP test workflow no longer computes or selects a previous WordPress version and depends only on built assets.

Changes: WordPress test alignment

Layer / File(s) Summary
Pin test environments to WordPress 7.1
.wp-env.json, .wp-env.test.json
Both configurations now set core to WordPress/WordPress#7.1-branch.
Simplify PHP test workflow
.github/workflows/unit-test.yml
The workflow removes previous-version computation, the WordPress matrix dimension, related exclusions, and WP_ENV_CORE. The test-php job now depends only on build-assets.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 68bb5

The test setup consistently uses WordPress 7.1, with no remaining merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the primary changes: repairing the wp/7.1 branch workflow and pinning wp-env to the WordPress 7.1 branch.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-actions-7.1/pin-wp-env-core-version
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration and workflow changes consistently implement the intended branch-specific Core pin without unresolved issues.

Pull request overview

Pins local and CI PHP environments on wp/7.1 to the matching WordPress Core branch.

Changes:

  • Pins both wp-env configurations to WordPress/WordPress#7.1-branch.
  • Removes obsolete previous-version calculation and PHP test matrix entries.
  • Runs PHP tests solely against the pinned Core branch.
File summaries
File Description
.wp-env.test.json Pins the test environment to WordPress 7.1.
.wp-env.json Pins the development environment to WordPress 7.1.
.github/workflows/unit-test.yml Simplifies PHP CI to use the pinned configuration.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@desrosj
desrosj marked this pull request as ready for review September 14, 2026 00:21
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 68bb56d to 98398a0 Compare September 14, 2026 00:28
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 98398a0 to dd0bdd5 Compare September 14, 2026 01:27
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 7.75 MB

46bf97b Run

🏁 Flaky tests

Show the failures

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

passes the search value in the main inserter when clicking `Browse all` in /test/e2e/specs/editor/various/inserting-blocks.spec.js, passed after 1 failed attempt.
TimeoutError: locator.fill: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('searchbox', { name: 'Search' }).first()

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/inserting-blocks.spec.js:672:5

46bf97b Run

@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from dd0bdd5 to 72266ad Compare September 14, 2026 02:37
@desrosj
desrosj removed this pull request from stack #82796 September 22, 2026 16:26
@desrosj
desrosj changed the base branch from fix-actions-7.1/single-node-version-testing to wp/7.1 September 22, 2026 16:26
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 72266ad to 350a81f Compare September 22, 2026 16:28
Comment thread .github/workflows/build-plugin-zip.yml Fixed
Comment thread .github/workflows/build-plugin-zip.yml Fixed
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/pin-runner-images September 22, 2026 16:28
@desrosj
desrosj added this pull request to stack #83383 September 22, 2026 16:29
@desrosj
desrosj removed this pull request from stack #83383 September 22, 2026 23:50
@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-runner-images to wp/7.1 September 22, 2026 23:50
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 350a81f to f213b61 Compare September 22, 2026 23:52
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/pin-runner-images September 22, 2026 23:52
@desrosj
desrosj added this pull request to stack #83417 September 22, 2026 23:52
@desrosj
desrosj removed this pull request from stack #83417 September 28, 2026 15:31
@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-runner-images to wp/7.1 September 28, 2026 15:31
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 1a77c1d to acbf603 Compare October 7, 2026 13:42
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from acbf603 to a469d15 Compare October 7, 2026 15:55
@desrosj
desrosj removed this pull request from stack #83629 October 8, 2026 21:07
@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-runner-images to wp/7.1 October 8, 2026 21:08
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from a469d15 to 7b47180 Compare October 8, 2026 21:08
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/pin-runner-images October 8, 2026 21:09
@desrosj
desrosj added this pull request to stack #84346 October 8, 2026 21:10
@desrosj
desrosj removed this pull request from stack #84346 October 9, 2026 23:21
@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-runner-images to wp/7.1 October 9, 2026 23:21
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 7b47180 to ceb9f58 Compare October 9, 2026 23:22
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/pin-runner-images October 9, 2026 23:23
@desrosj
desrosj added this pull request to stack #84466 October 9, 2026 23:23
@desrosj desrosj added the [Tool] Env /packages/env label Oct 16, 2026
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from ceb9f58 to 1e379a5 Compare October 19, 2026 17:02
@github-actions github-actions Bot removed the [Tool] Env /packages/env label Oct 19, 2026
@desrosj
desrosj removed this pull request from stack #84466 October 21, 2026 18:35
@desrosj
desrosj added this pull request to stack #85326 October 21, 2026 18:36

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing checks pass at the top of this stack (#85318).

@desrosj
desrosj force-pushed the fix-actions-7.1/pin-wp-env-core-version branch from 1e379a5 to 46bf97b Compare October 24, 2026 18:02
@github-actions github-actions Bot added the [Tool] Env /packages/env label Oct 24, 2026
@desrosj
desrosj removed this pull request from stack #85326 October 24, 2026 18:04
@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-runner-images to fix-actions-7.1/archive-bullseye-security-apt-source October 24, 2026 18:04
@desrosj
desrosj added this pull request to stack #85508 October 24, 2026 18:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] Env /packages/env [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants