Skip to content

Block Parser: Document \WP_Block_Parser::$stack as a list #82695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 6 commits into from
Sep 25, 2026
Merged

Block Parser: Document \WP_Block_Parser::$stack as a list #82695

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
608a292
Replace stack access with array_last function
mukeshpanchal27 Sep 9, 2026
27090fe
Refactor add_inner_block to use array_key_last
mukeshpanchal27 Sep 15, 2026
cedbc15
Merge branch 'trunk' into fix/use-modern-function
mukeshpanchal27 Sep 15, 2026
02eadbb
Update changelog link for pull request 13487
mukeshpanchal27 Sep 15, 2026
966ed5a
Merge branch 'trunk' into fix/use-modern-function
mukeshpanchal27 Sep 25, 2026
9f58340
Restore count()-based stack access and narrow $stack type to a list
mukeshpanchal27 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor add_inner_block to use array_key_last
  • Loading branch information
@mukeshpanchal27
mukeshpanchal27 authored Sep 15, 2026
commit 27090fea9efcbee057d6f376748cf67a8b77ba8a
9 changes: 8 additions & 1 deletion packages/block-serialization-default-parser/class-wp-block-parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,14 @@ public function add_freeform( $length = null ) {
* @param int|null $last_offset Last byte offset into document if continuing form earlier output.
*/
public function add_inner_block( WP_Block_Parser_Block $block, $token_start, $token_length, $last_offset = null ) {
$parent = array_last( $this->stack );
/*
* Note: `array_last()` is intentionally not used here. It returns `null` for an
* empty array, which makes static analysis flag the property accesses below.
* Guarding against that is not possible without changing behavior: both callers
* already ensure the stack is not empty, so the guard would be unreachable, and
* this is a public method on a class that can be replaced via `block_parser_class`.
*/
$parent = $this->stack[ array_key_last( $this->stack ) ];
$parent->block->innerBlocks[] = (array) $block;
$html = substr( $this->document, $parent->prev_offset, $token_start - $parent->prev_offset );

Expand Down
Loading