Skip to content

Block Fields: Fix video not rendering when added from the inspector panel - #82541

Closed
im3dabasia wants to merge 1 commit into
WordPress:trunkfrom
im3dabasia:try/block-fields-media-type-normalisation
Closed

im3dabasia wants to merge 1 commit into
WordPress:trunkfrom
im3dabasia:try/block-fields-media-type-normalisation

Conversation

@im3dabasia

@im3dabasia im3dabasia commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

What?

See #66563

Fixes video selected from the inspector panel not rendering in Cover and Media & Text.

Why?

Adding a video from the inspector panel doesn't work, the video never shows. The same video added from the toolbar works fine. Affects Cover and Media & Text.

How

  • The panel now recognises what kind of file was picked, so videos are treated as videos.
  • Cover now correctly records that its background is a video.

Testing Instructions

  1. Enable Experiments → Data Views → "Block fields: Show dataform driven inspector fields on blocks that support them", then reload.
  2. Insert a Cover block, add a video from the inspector panel, it renders as a video.
  3. Repeat with Media & Text.

Screenshots or screencast

Before

Screen.Recording.2026-09-07.at.6.40.32.PM.mov

After

Screen.Recording.2026-09-07.at.6.38.48.PM.mov

Use of AI Tools

Claude Code

@im3dabasia im3dabasia self-assigned this Sep 7, 2026
@im3dabasia im3dabasia added [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Media & Text Affects the Media & Text Block [Type] Experimental Experimental feature or API. labels Sep 7, 2026
@github-actions github-actions Bot added [Package] Block library /packages/block-library [Package] Block editor /packages/block-editor labels Sep 7, 2026
@im3dabasia im3dabasia changed the title [WIP] Block Fields: Fix video not rendering when added from the inspector panel Block Fields: Fix video not rendering when added from the inspector panel Sep 7, 2026
@im3dabasia
im3dabasia marked this pull request as ready for review September 7, 2026 13:12
@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia

Copy link
Copy Markdown
Contributor Author

The inspector panel and block toolbar don't produce the same result on Cover. This PR fixes the biggest one , video not rendering at all. Remaining differences when adding media from the panel:

  • Overlay stays fully opaque, hiding the media
  • No overlay colour picked up from the media
  • Title isn't centered
  • Image size isn't chosen the same way

Keeping these out to stay scoped, they share one cause, so I'll open a follow-up issue.

@ciampo
ciampo requested review from jorgefilipecosta, ntsekouras and oandregal and removed request for ciampo September 7, 2026 13:16
@oandregal
oandregal requested review from talldan and removed request for oandregal September 7, 2026 14:29
@talldan

talldan commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for working on the PR.

At the moment it looks like this experiment is going to be removed - Remove the content-only inspector fields (block fields) experiment, so unfortunately the changes would be unnecessary.

@im3dabasia

Copy link
Copy Markdown
Contributor Author

Thanks @talldan, closing this since the experiment is on its way out.

I've opened #82593 instead, which addresses the original issue (#66563) directly using the same pattern the Image block already uses. Would appreciate a look when you get a chance.

@im3dabasia im3dabasia closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Media & Text Affects the Media & Text Block [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Type] Experimental Experimental feature or API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants