Repository navigation
Excerpt and description fields: Use the regular layout in the DataForm post summary - #82444
ntsekouras wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe change renders excerpt fields inline for default post forms and blocks, updates excerpt value handling, reduces textarea heights, and changes PHP and end-to-end tests to verify direct textbox interaction. ChangesInline summary fields
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This update documents the inline summary-field behavior without introducing implementation changes in the reviewed increment. No merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 7 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
🤖 PR meta 🤖⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsShow the failuresSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. should override reset styles and library styles in
|
|
Thanks for trying this. When he's able to catch up, I'd love @jameskoster's thoughts on this. Two things in the meantime:
|
What?
Part of: #76076 (the excerpt field item under "Design tweaks")
Alternative to: #82423 (see #82423 (comment))
With the DataForm inspector, the excerpt field renders
Add an excerptas if it were a value when the excerpt is empty, with the same styling as a real excerpt. This is also problematic in cases theexcerptfield would be rendered in DataViews, although that's not the case right now. The description fields of templates and patterns render nothing when empty, for the use case I mentioned, as it's also used in the site editor (DataViews).#82423 keeps the panel layout and always shows the pencil. This PR tries the other option from that discussion and renders the
excerptand the templatedescriptionfields inline with the regular layout, so what users see is the textarea with its placeholder. Per Joen's feedback the textareas start at 2 rows instead of 4.The
excerptfield also renders nothing when there is no value, same as #82423, sincerenderis what DataViews would use.Notes - Needs design feedback
Learn more about manual excerpts↗link to make the 'work' for users to understand this is the excerpt field? 🤔 I'm sharing a screenshot for that below:This PR
Trunk
Testing Instructions
Add an excerptplaceholder.Use of AI Tools
Generated with Fable 5 and adjusted/reviewed manually.
Summary by CodeRabbit