Address feedback

jasmussen · Oct 1, 2026 · Aug 28, 2026 · Aug 28, 2026 · Aug 28, 2026 · Sep 3, 2026
commit 79dc2f898add706432f728bb8809709802de1d00
@@ -160,10 +160,17 @@
 		background: var(--wpds-color-background-interactive-brand-weak-active);
 	}
 
-	/* Hide the border while pressed, keeping its width so nothing shifts. */
+	/*
+	 * Pressed takes the same border as hover. `@wordpress/ui` Button drives
+	 * hover, active and focus from one `border-color-active` custom property,
+	 * and the persistent `.active` rule below already uses that value, so an
+	 * earlier `border-color: transparent` here was the only state in this file
+	 * that dropped the edge — the button appeared to lose its outline for as
+	 * long as the pointer was down.
+	 */
 	.wp-core-ui .button:active,
 	.wp-core-ui .button-secondary:active {
-		border-color: transparent;
+		border-color: var(--wpds-color-stroke-interactive-brand-active);
 		background: var(--wpds-color-background-interactive-brand-weak-active);
 	}
 
@@ -178,6 +185,27 @@
 		background: var(--wpds-color-background-interactive-brand-weak-active);
 	}
 
+	/* -----------------------------------------------------------------------
+	   The page title action — appearance only
+
+	   "Add Post" and its siblings are `<a class="page-title-action">` with no
+	   `button` class, so none of the rules above reach them. They still look
+	   like our buttons, because WordPress draws them with
+	   `var(--wp-admin-theme-color)` and the scheme tokens now feed that — but
+	   the weight stays WordPress's 500 while every real button is at the emphasis
+	   token, which is the difference you see side by side in a list table header.
+
+	   Only the weight is taken. WordPress gives this control `min-height: 40px`,
+	   `line-height: 2.71428571` and `top: -3px` to sit it against the page
+	   title, and adopting it properly means taking on that geometry — which is
+	   the contextual sizing this experiment leaves alone on purpose. Covering
+	   the control fully is a separate question; matching the weight is not.
+	   ----------------------------------------------------------------------- */
+
+	.wrap .page-title-action {
+		font-weight: var(--wpds-typography-font-weight-emphasis);
+	}
+
 	/* -----------------------------------------------------------------------
 	   Primary — `@wordpress/ui` Button, brand tone, solid. The border takes
 	   the background colour, as it does there.

@@ -55,7 +55,22 @@
 		 * know what those contexts are. WordPress also handles the mobile case, raising
 		 * inputs to 16px below 782px so iOS does not zoom on focus.
 		 */
-		line-height: 1;
+
+		/*
+		 * `normal`, not `1`. The `@wordpress/ui` input primitive uses `line-height: 1`,
+		 * but it sets it on a wrapper that lays out a separate inner `<input>`, where
+		 * the text has room regardless. wp-admin has no wrapper: the declaration lands
+		 * on the bare control, and a line box exactly as tall as the font is shorter
+		 * than the font's own ascender-plus-descender, so descenders are clipped by the
+		 * control's chrome — visibly on `<select>` in Firefox, and on number fields in
+		 * Settings > Media.
+		 *
+		 * `normal` lets the font's metrics size the line box, which cannot clip, and
+		 * unlike a pixel value it does not compete with the contextual heights
+		 * WordPress sets per control. Worth raising against the primitive too: `1` is
+		 * only safe there because of the markup around it.
+		 */
+		line-height: normal;
 	}
 
 	/* -----------------------------------------------------------------------