Skip to content

Framework: Error on npm versions older than the required floor #82320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 1 commit into from
Sep 2, 2026
Merged

Framework: Error on npm versions older than the required floor #82320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/setup-npm/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ runs:
- name: Install npm
run: |
NPM_VERSION="$(jq -r '.devEngines.packageManager.version' package.json)"
npm install --global "npm@$NPM_VERSION"
# Contributors need the floor; CI stays on that major's newest release.
npm install --global "npm@${NPM_VERSION/>=/^}"
echo "Required npm version: $NPM_VERSION"
echo "Installed npm version: $(npm --version)"
working-directory: ${{ inputs.working-directory }}
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
},
"packageManager": {
"name": "npm",
"version": "^10.2.3",
"onFail": "warn"
"version": ">=10.2.3",
Comment thread
ciampo marked this conversation as resolved.
"onFail": "error"
}
},
"wpPlugin": {
Expand Down
6 changes: 3 additions & 3 deletions tools/release/commands/performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ const ARTIFACTS_PATH =
const RAW_RESULTS_FILE_SUFFIX = '.performance-results.raw.json';
const RESULTS_FILE_SUFFIX = '.performance-results.json';
/*
* Read from the CLI's own checkout, so every branch under test builds with the
* npm version trunk requires rather than whichever npm the runner happens to ship.
* Read from the CLI's own checkout so every branch under test builds with the npm
* version trunk requires, narrowed to that major so a new one cannot land mid-run.
*/
const NPM_VERSION = devEngines.packageManager.version;
const NPM_VERSION = devEngines.packageManager.version.replace( '>=', '^' );

/**
* @typedef WPPerformanceCommandOptions
Expand Down
Loading