Repository navigation
Conversation
|
Hi |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
c59b625 to
1bf2259
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Search block now renders a responsive mobile overlay for button-only searches. It adds mobile-specific styling, overlay positioning, resize handling, and focus management. ChangesMobile Search overlay
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Button-only Search blocks gain a mobile overlay that expands without shifting surrounding layout while desktop behavior remains unchanged. No concrete current-head merge risk remains. Sequence Diagram(s)sequenceDiagram
participant SearchBlockRenderer
participant SearchView
participant MobileOverlay
SearchBlockRenderer->>MobileOverlay: render mobile fields and submit control
SearchView->>MobileOverlay: update position and background when opening
SearchView->>MobileOverlay: recalculate position on resize
SearchView->>SearchBlockRenderer: restore focus after closing
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Sure, added example video to show what I mean.
I don't think there is an issue and there was no design feedback. I created a draft PR to show the problem and an option to fix it but it doesn't mean it has to be the solution. I'm open to other ideas! |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. 📦 Bundle sizeSize Change: +2.26 kB (+0.03%) Total Size: 8.01 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
1bf2259 to
d96d4fa
Compare
|
A few thoughts:
|
What?
Give button-only Search an opinionated mobile overlay (≤600px):
Desktop behavior stays unchanged.
How?
Keep the original button in flow and show a copied submit button inside an absolutely positioned full width overlay.
Why?
When button-only search is used among other elements, it squeezes and pushes out surrounding elements. When expanded, it leads to broken, unnatural layout.
Example use case is when used in header which I consider pretty common placement for search. In this case my page name is squeezed, content on the right is pushed out of the view and search itself exceeds the screen width.
Screen.Capture.on.2026-09-03.at.10-30-33.mp4
Testing Instructions
Keyboard
Tab to Search → Enter opens and focuses the input → Tab reaches submit. Check submission, Escape closes and restores focus, and tabbing outside closes without stealing focus. Resize while submit is focused.
Build, lint, PHP checks, and local Chrome checks passed. Automated regression tests and native-mobile coverage remain pending. Background images/gradients and translucent-background compositing are not handled.
Videos
Screen.Capture.on.2026-08-28.at.17-12-10.mp4
Screen.Capture.on.2026-08-28.at.17-09-04.mp4
Use of AI Tools
OpenAI Codex assisted with implementation, local checks, and this description under the author's direction and review.
Summary by CodeRabbit