Repository navigation
Resolve SVG through Icon Registry - #82062
Open
Vrishabhsk wants to merge 3 commits into
Open
Vrishabhsk wants to merge 3 commits into
Vrishabhsk wants to merge 3 commits into
Conversation
Vrishabhsk
requested review from
ajitbohra,
fabiankaegy and
spacedmonkey
as code owners
August 26, 2026 09:58
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
1 of 13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
::beforepseudo-elements.How?
Exposed icon identifiers for theme override:
core/searchcore/navigation-submenucore/navigation-menu-togglecore/menucore/closecore/chevron-left/core/chevron-rightKey implementation details:
stroke,stroke-width,stroke-linecap,stroke-linejoin, andfillattributes — needed for the stroked submenu chevron.core/navigation-submenuandcore/navigation-menu-togglevia inline content ingutenberg_register_default_icons()since their SVGs don't fit the icon library's 24×24 /fill="currentColor"convention.core/closepublic in the icon manifest.wp_get_icon()with fallback to the original hardcoded SVG.useIcon()hook that fetches icons from the registry viacore-data, with fallback to the original React SVGs.Theme override example:
Works in both editor and frontend.
Testing Instructions
functions.php:npm run wp-env-test run -- phpunit --filter Tests_Blocks_Render_IconsUse of AI Tools
This PR was implemented with assistance from GLM-5.2 via Ollama (
ollama/glm-5.2:cloud).