Repository navigation
Media: Attach unattached media to the current post on save/publish - #81977
Merged
Merged
Conversation
andrewserong
added
[Type] Enhancement
github-actions
Bot
added
[Package] Editor
|
Size Change: +587 B (+0.01%) Total Size: 7.91 MB 📦 View Changed
|
andrewserong
force-pushed
the
try/attach-media-from-blocks-on-save
branch
from
August 26, 2026 02:34
60c583f to
456fc38
Compare
|
Flaky tests detected in 19ff83f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/33367467901 Should save the changes in
|
ramonjd
reviewed
Aug 26, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
Just by the test instructions, this is working really well and exactly how I'd expect it, that is, behind the scenes with no confusing UI 😄
I just happened to find an edge case while testing multi-entity saving, but so far it's looking great.
Thanks!
| ); | ||
|
|
||
| // The likeliest failure is a 403: attaching writes to the attachment, so a | ||
| // contributor using someone else's media cannot do it. |
Member
There was a problem hiding this comment.
is that right? Or a user without edit_posts more likely? Contributors can edit some posts.
Not important 😄
andrewserong
force-pushed
the
try/attach-media-from-blocks-on-save
branch
from
August 28, 2026 05:48
8393f17 to
5544fc0
Compare
ramonjd
reviewed
Aug 28, 2026
Comment on lines
+289
to
+303
| ! error && | ||
| ! options.isAutosave && | ||
| ! options.isPreview && | ||
| ! select.isDeletingPost() && | ||
| previousRecord.status !== 'trash' && | ||
| select.getEditorSettings().autoAttachMediaEnabled | ||
| ) { | ||
| attachMediaInPost( registry, { | ||
| id: previousRecord.id, | ||
| type: previousRecord.type, | ||
| // The post's own blocks, not the ones on screen — see | ||
| // `attachMediaInPost`. Same source as the content saved above. | ||
| blocks: select.getEditorBlocks(), | ||
| } ); | ||
| } |
Member
There was a problem hiding this comment.
this is all in savePost, but any save that goes through the entities save panel never calls savePost. So if I add an image in the post, then edit a template part and save from there, the attach isn't registered.
Kapture.2026-08-28.at.17.28.40.mp4
Not sure if this is a big deal TBH
Is there a way to run attachMediaInPost in the panel or elsewhere? I dunno!
Contributor
Author
There was a problem hiding this comment.
Oh, great catch! I'll dig in further next week. Cheers!
Contributor
Author
There was a problem hiding this comment.
Thanks again for flagging. I looked into this a little further, but I think getting this running in the other multi-entity panels winds up adding a bit more complexity than it's worth.
IMO I think this behaviour is roughly comparable to anything else that will get hooked on editor.savePost directly above this call, e.g. saving meta boxes in the post editor. For the purposes of this PR, that makes the scope: when saving a post or page in isolation as a side-effect of saving or updating a post.
I think that's probably good scope for now, and we can revisit / look at expanding it further if we get feedback or requests for it. My hunch is that we likely won't as this is largely a feature to cover a parity gap between the classic and block editors, and we're kind of doing it silently, or as silently as we can.
Let me know if you think it winds up being important!
Member
There was a problem hiding this comment.
Make sense, thanks for diving in.
Scoping it to savePost makes sense the way you explain it. For me also, the change in context - saving from the other entity - helps to provide a physical gate anyway.
andrewserong
force-pushed
the
try/attach-media-from-blocks-on-save
branch
from
August 31, 2026 05:59
a0e8e07 to
640629a
Compare
andrewserong
marked this pull request as ready for review
August 31, 2026 07:37
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Alrighty, I've done some re-testing for this and it seems to be working consistently for me when saving, updating, publishing posts in the post and site editors when you're just saving the post itself. One thing I've updated since last week is that I've added a hard cap on the updates to 100 images, matching the caps we're using elsewhere for dynamic galleries, etc. My assumption is that in the majority of cases folks are updating posts and pages with well less than that number of unattached images, and if for some reason someone's doing a gigantic post, it's better to just skip this feature entirely in that case as it's more of a convenience feature than something essential. So, I think this is now at my "I'm proposing this as the scope of the feature" stage. I hesitate to say "good" explicitly as I still have misgivings about the attachment relationship behaviour itself in core, but that's a bigger question than this PR can solve 😄 For now then, my vote is to add in this save-time update for attachments to attach unattached media, and effectively call it "done" in terms of behaviour for now. Thanks again for all the reviews and help honing in on the scope for the feature. And, of course, happy to keep iterating if this doesn't feel like the right place to land it. |
ramonjd
approved these changes
Sep 1, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
Appreciate all the iterations. I think you've honed it down to the basics, and delivered the functionality without complicating things.
The feature is a hard sell and I agree it'd just be a rabbit hole to try to educate the user on it. This PR delivers it to folks who already expect it, and those who don't, probably won't care.
Just left a couple of comments. After a rebase I think 🚢
Comment on lines
+288
to
+295
| if ( | ||
| ! error && | ||
| ! options.isAutosave && | ||
| ! options.isPreview && | ||
| ! select.isDeletingPost() && | ||
| previousRecord.status !== 'trash' && | ||
| select.getEditorSettings().autoAttachMediaEnabled | ||
| ) { |
Member
There was a problem hiding this comment.
Another question - this attaches images after a save is kicked off. What happens if, says, I'm the Flash, and I add another image while the save request is still happening?
Would it hurt to hoist these checks further up, possibly also select.getEditorBlocks() so you're getting the saved post's blocks, not whatever else has been added to the screen?
Contributor
Author
There was a problem hiding this comment.
Good call, bit of an edge case, but good to be thorough here!
In terms of where we place the checks (this big if block), I chose this location because it occurs after all the hooked filters run (i.e. pre save, unstable save post, save post action, etc). If any of these stages have errored, then we want to skip this side-effect of attaching media.
But, we can place the select.getEditorBlocks() right up to the top so that we take a snapshot of the blocks early in the cycle. I've pushed that in 19c89ea, which I think gives us the best of both worlds (early snapshot, while still only attaching media late in the cycle).
| } ); | ||
|
|
||
| /** | ||
| * The lookups can reject on their own — `context=edit` on the media |
Member
There was a problem hiding this comment.
context=edit
is that still true?
I'm just looking at attachMediaInPost and surrounding code and can't see it.
// Nothing is waiting on this, so an error thrown here would go nowhere.
// Either lookup below can fail on its own: someone who can't edit other
// people's media gets a 403.ignore if irrelevant 😄
Contributor
Author
There was a problem hiding this comment.
Gah, thank you for pushing back on this and the earlier comment. While reading this over myself it looked plausible at first glance because the real request that happens in the browser when saving a post has ?context=edit injected (it's defined here in the root entities config), but the comments about editing each other's media or posts and getting a 403 is getting too specific in these comments (and inaccurate).
All we really care about here is that things can fail for a bunch of reasons, and our failing state is warning to the console.
I think where these comments went wrong is that they're conflating the lookup state (i.e. a request to read the available media) with updating media which is a different request / gating (i.e. can the user edit others' posts).
In any case, I've updated the comments. Thanks again!
Uploading a file into a post has always parented that attachment to the post. Selecting an existing file from the Media Library never has, so the same image reads as `Unattached` or not depending only on how it reached the block -- and media that is genuinely in use looks safe to delete. It also means a Dynamic Gallery misses library-sourced images, since its source is precisely "attached to this post". Fourth of four explorations, and the narrowest. Review of the previous one found the scope right and the surface wrong: exposing attachment in the UI invites the question of why an image can belong to only one post, which is a limitation of `post_parent` rather than something a panel can explain away. So this keeps that scope and drops the UI entirely, the way the Classic Editor did it. The scope comes free from reading the post's blocks on save. "Media added via an Image or Gallery block" needs no tracking, because the block is the record -- and media added then removed before saving is simply not in the tree. A featured image, a site icon, or a picker an SEO plugin renders is never this post's to claim, which is what the earlier attach-on-any-selection approach got wrong. Only an empty parent is ever filled. WordPress reports "belongs to nothing" as `null` rather than `0`, and an attachment already owned by another post is left alone: `post_parent` holds one post, so taking it would silently strip the file from wherever it came from. Hooked on `editor.savePost` rather than `savePost` itself, following the meta box save in edit-post. The handler deliberately does not return its promise -- that action is awaited, and bookkeeping must not hold up the editor reaching "Saved". Failures stay quiet, since nothing was promised and a file that fails to attach is left exactly as it already was. Saving a record does not refresh the cached queries that list media by parent, so the write is followed by an attachment cache invalidation. Without it the Dynamic Gallery and the inserter's attached-media tab keep showing the pre-save answer until reload, which is the visible half of the bug this is meant to fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`savePost` handles templates as well as posts — its own template-activation branch keys on `previousRecord.type === 'wp_template'` — so saving a template containing an Image block was attaching that media to the template. A template has no URL of its own and backs many posts, so "uploaded to" pointing at one says nothing useful. Deriving the media list at save time means the guards the earlier block-based version got free from block context have to be reimplemented, and this one was missed. `viewable` is the same signal the editor uses elsewhere for "this has a front end", and rules out wp_template, wp_template_part, wp_block, wp_navigation and wp_global_styles in one check rather than naming them. It matches what the server-side counterpart does with `is_post_type_viewable()`. Ordered after the block scan, so a post with no media at all still costs nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A synced pattern's blocks are controlled inner blocks: `core/block` passes the pattern's own content into `useInnerBlocksProps`, which syncs it into the editor's store under the pattern block's client ID. So they appear in this post's block tree without being this post's content, and the walk that collects media IDs went straight into them. The consequence is worse than a missed image. A pattern used on twenty posts would have its media claimed by whichever one saved first -- arbitrary, invisible, and not undone by saving any of the others, since only an empty parent is ever filled. Stops the walk at those blocks rather than filtering afterwards, so the rule reads as what it is: their inner blocks are another entity's content. `core/template-part` is included for the same reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Writing to someone's media library on every save deserves an off switch, even with no UI for it. An editor setting is the canonical shape: PHP reaches it through `block_editor_settings_all` and JS through `updateEditorSettings`, so a site or plugin turning this off needs to learn nothing specific to the feature. `autoAttachMediaEnabled`, defaulting to true, following the `<thing>Enabled` naming already used by `richEditingEnabled`, `codeEditingEnabled` and `fontLibraryEnabled` in the same defaults. An editor setting rather than a block editor setting: the only consumer is the editor's own save flow, and nothing in `block-editor` needs to know. Adding it there would mean threading it through the settings allowlist for no reader. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Three files spread across `hooks/` and `utils/` for one feature, two of them named `attach-media-in-post.js`, and neither util imported by anything but the hook. `push-changes-to-global-styles` is the existing answer to this shape: a hook whose implementation spans several modules lives in a directory beside its own tests. `utils/` is not a barrel -- its index exports only `mediaUpload` and `cleanForSlug` -- and the media directories in there (`media-upload`, `media-sideload`, `media-delete`) are all capabilities wired into block editor settings and consumed elsewhere. These two modules are neither, so sitting among them implied a reach they do not have. Also puts `media-ids-in-blocks` where its privacy is legible. It is the one piece that might plausibly be shared later -- something else may want "the media this post contains" -- and promoting it out of here when that happens is easier to justify than noticing it should never have been public. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Gallery entry was dead code. A modern gallery holds inner `core/image` blocks, and the legacy format that stored its own `ids` array is migrated into those inner blocks when the post is parsed -- `runV2Migration` in the Gallery block's `deprecated.js` -- so a gallery carrying `ids` never reaches the editor's block tree. Only the server-side proposal, which reads `post_content` directly, has to care about it. Dropping it takes the array handling with it: the map is now block name to a single attribute name, which is also the shape any future entry would want. Cover, Media & Text, Video, Audio and File are all one attribute each. Also tidies two docblocks: the `flattenBlocks` one had been orphaned from its function by a later insertion, and `getMediaIdsInBlocks` still described keeping a list shown before publishing in step with the list written on save. There is no such list any more. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`editor.savePost` is how another package observes a save — `edit-post` uses it to POST its meta boxes, because it has no other way in. This code is in `packages/editor` and owns `savePost` outright, so routing through that hook was indirection with three costs and no benefit. It gave the feature a second, undocumented off switch: `removeAction` on the handler name, alongside the `autoAttachMediaEnabled` setting that is meant to be the answer. It left ordering against edit-post's meta box handler unspecified. And because `doActionAsync` awaits its handlers, the "deliberately not returned" comment existed only to defend against a hazard the hook introduced; called directly, there is nothing to await. The in-package precedent was already there and pointed the other way: template activation is a post-save side effect done inline in `savePost`, guarded on `! options.isAutosave` and post type. This now sits next to it, and the autosave and preview checks live beside the other `options` checks rather than being re-derived in a separate file. Files move from `hooks/` to `store/utils/attach-media-in-post/`, beside `store/utils/notice-builder.js` — `savePost`'s other helpers. Same directory, same tests, different parent: with no hook to register, `hooks/` was no longer the right home, but the reason for grouping them still holds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…te fails Two gaps found reviewing the branch. `trashPost` deletes the post and then calls `savePost`, and `isEditedPostSaveable` checks only whether a save is in flight and whether the post has a title, excerpt or content -- there is no status check. So a post on its way to the bin was claiming media on the way out. The store still holds the pre-trash record at that point, which is why the guard is `isDeletingPost` rather than the status, with a status check alongside it for a post that was already trashed. Failed writes were also swallowed entirely. Silent to the user is the design; silent to whoever is debugging it was not a decision anyone made. The likeliest failure is a 403 -- attaching writes to the attachment, so a contributor using someone else's media cannot do it. The reason is logged without interpolation, since a rejected `apiFetch` is not reliably an `Error` and would otherwise print "[object Object]". Both are covered, and so is the editor setting, which had no test at all despite being the documented way to switch this off. The tests drive `savePost` against a real registry, which needs the attachment entity registered and Response-shaped fetch results for the two resolvers that read headers. Verified they are not vacuous: removing the trash guard fails its test, and the positive case asserts the whole chain from blocks through to the write, which is what stops the negative cases passing on an empty block list. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…em if all the ids are identical
andrewserong
force-pushed
the
try/attach-media-from-blocks-on-save
branch
from
September 1, 2026 06:00
19ff83f to
07fb062
Compare
…ck matches the post content at the time of the request to save the post
Contributor
Author
Thanks, much appreciated again for all the back-and-forth on this. I'll merge this in once the tests pass, and happily to follow-up if we wind up running into any issues with it. |
wporg-sync
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 8, 2026
This updates the pinned commit hash of the Gutenberg repository from `658c8cbe89db5d90279051d3bb816ca210fe4646 ` (version `23.8.0`) to `5a4cc502d43016f1efa66f8f6d9bd3bb4bb24d85`, which contains the latest changes up until the Node.js version was bumped from 20.x to 24.x. A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/658c8cbe89db5d90279051d3bb816ca210fe4646..5a4cc502d43016f1efa66f8f6d9bd3bb4bb24d85. - Menu: Stabilize iframe reload test (WordPress/gutenberg#82081) - Packages: Recover August 26 npm release metadata (WordPress/gutenberg#82085) - Storybook: Demonstrate light, dark, and nested themes (WordPress/gutenberg#82039) - Project Management: Add validation for missing GitHub labels configuration (WordPress/gutenberg#76263) - Automated Testing: Enforce `.tsx` for all new React files (WordPress/gutenberg#80123) - UI: Use root theme for portaled overlays (WordPress/gutenberg#82038) - Menu: Stabilize portaled iframe test (WordPress/gutenberg#82092) - Theme: Move post-release changelog entry to Unreleased (WordPress/gutenberg#82093) - Media: Refuse a multi-file drop on a placeholder that takes one file (WordPress/gutenberg#82046) - Font Library: Keep CSS custom properties unquoted in font previews (WordPress/gutenberg#82010) - Add "reading settings" link to Front Page template (WordPress/gutenberg#81987) - Docs: Fix grammar in documentation (WordPress/gutenberg#82032) - Media Editor: refactor the panel layout (WordPress/gutenberg#81840) - DataViews layout storybook: action names and primary status (WordPress/gutenberg#82104) - Make `@wordpress/reusable-blocks` a no-op compatibility package (WordPress/gutenberg#79186) - Widget Dashboard: add a Policy provider to govern what users may do (WordPress/gutenberg#81967) - Build Package: Restore Core Boot layout compatibility (WordPress/gutenberg#82112) - Edit Widgets: Guard canInsertBlockInWidgetArea against an empty block list (WordPress/gutenberg#82107) - Build: Enforce NodeNext resolution for ESM packages (WordPress/gutenberg#82088) - UI: Remove unused outset-ring--focus-within-visible class. (WordPress/gutenberg#82077) - Inserter: Keep the block preview inside the viewport (WordPress/gutenberg#82060) - Test: Enforce Vitest conventions and CI guardrails (WordPress/gutenberg#81040) - Editor: Apply the showListViewByDefault preference in the shared editor (WordPress/gutenberg#82119) - Release: Use CLI runtime for package publishing (WordPress/gutenberg#82122) - Reusable Blocks: Remove leftover merge conflict markers from the changelog (WordPress/gutenberg#82126) - chore: Update grep settings and remove comments (WordPress/gutenberg#82121) - Fix: Content Guidelines: UX/UI Accessibility issues (WordPress/gutenberg#80306) - Extensible Site Editor: Let menu items be added from the navigation screen (WordPress/gutenberg#82125) - Navigation: Change WCText to Text (WordPress/gutenberg#82130) - Storybook: Persist sidebar theme in URL (WordPress/gutenberg#82111) - Editor assets endpoint: prime the theme JSON resolver before capturing (WordPress/gutenberg#82134) - Remove unused dependencies across the monorepo (WordPress/gutenberg#82103) - Update changelog instructions for agents (WordPress/gutenberg#82097) - Build: Normalize JSX file extensions (WordPress/gutenberg#80990) - Fix pattern export filenames by normalizing special characters (WordPress/gutenberg#77033) - Site editor v2: navigation takes view config from endpoint (WordPress/gutenberg#82138) - Extensible Site Editor: Load media assets before the media fields open (WordPress/gutenberg#82135) - Site editor v2: pages take view config from endpoint (WordPress/gutenberg#82140) - Extensible site editor: Add a revisions entry point to the Styles route (WordPress/gutenberg#82142) - List: outdent an empty middle item without adding an item (WordPress/gutenberg#82011) - Extensible site editor: Fall back to the raw title in edit route document titles (WordPress/gutenberg#82143) - Blocks: Make BlockTransform a discriminated union over its type (WordPress/gutenberg#81831) - Theme: add LightningCSS WPDS token fallback plugin (WordPress/gutenberg#80401) - UI: Add popupWidth prop to item popup components (WordPress/gutenberg#82087) - Snackbar: Restart timeout when a notice is recreated (WordPress/gutenberg#81764) - Media: Report server upload failures in plain language (WordPress/gutenberg#81735) - Format library: visualise non-breaking spaces (WordPress/gutenberg#74040) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#81932) - Try adding a Grid block variation to Gallery (WordPress/gutenberg#81909) - Components: Keep foreign items out of a ToolsPanel menu (WordPress/gutenberg#82127) - Enable Gallery columns and crop controls in viewport states (WordPress/gutenberg#82003) - Query: Don't write excludeCurrent into blocks that never had it (WordPress/gutenberg#82147) - Site title: Add fit-text support. (WordPress/gutenberg#82074) - Accordion Panel: Reset padding-block when panel is hidden (WordPress/gutenberg#81782) - Replace npm-run-all with native npm script chaining (WordPress/gutenberg#82166) - Grid: per-item tile size limits (WordPress/gutenberg#81899) - Fix: Tabs block: Anchor links in tab panels are not functional (WordPress/gutenberg#81744) - Validate tsconfig references against declared dependencies (WordPress/gutenberg#82106) - Performance tests: Build once and shard the suites across parallel CI jobs (WordPress/gutenberg#82160) - Site Health widget: route the body's review link through the host (WordPress/gutenberg#82066) - Build: allow wp-theme 2.x peer deps (WordPress/gutenberg#82139) - Bundled packages: Add a check for transitive private API usage (WordPress/gutenberg#82027) - List: try to preserve indentation level of children after outdenting+merging their parent (WordPress/gutenberg#82145) - Block Library: Fix categories block handling of invalid taxonomy (WordPress/gutenberg#82153) - useViewConfig: don't request the view config twice (WordPress/gutenberg#82141) - Documentation: Remove invalid references to Babel in packages README (WordPress/gutenberg#82176) - Automated Testing: Fix failing categories test on trunk (WordPress/gutenberg#82182) - Jest: Update to 30.5.0 (WordPress/gutenberg#82181) - Fix: Retain focus and caret position after Backspace undo of a prefix block transform (WordPress/gutenberg#82116) - Scaffold e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82178) - Package lock: Deduplicate Jest dependencies (WordPress/gutenberg#82187) - Components: Migrate remaining JSX files to TypeScript (WordPress/gutenberg#82132) - Text: Use pretty wrapping by default (WordPress/gutenberg#82133) - Build Tooling: Add browserslist config for build targeting (WordPress/gutenberg#82179) - Columns: Fix appender drop zone visibility when dragging into empty column (WordPress/gutenberg#77852) - Build: Require explicit JSX file extensions (WordPress/gutenberg#82189) - Icons: Redraw 35 prominent icons with consistent stroke widths (WordPress/gutenberg#78808) - Test: Classify and enforce unit test environments by filename (WordPress/gutenberg#80991) - Test: Fix CI failures on trunk (WordPress/gutenberg#82201) - Fix editor link colour cascade order for nested blocks (WordPress/gutenberg#77833) - Add New Template: Show the design system focus ring instead of legacy box-shadow rings (WordPress/gutenberg#82164) - List View: Don’t focus the last Table cell on keyboard activation (WordPress/gutenberg#81964) - Fix spelling typos in docs and inline comments (WordPress/gutenberg#82217) - CI: Pin npm version in the private API check job (WordPress/gutenberg#82222) - Private APIs: Add back '@wordpress/dataviews' to the allowed core modules (WordPress/gutenberg#82221) - Editor: Mark __unstableSaveForPreview options as optional (WordPress/gutenberg#81858) - Docs: Explain when the Cover block's overlay controls appear (WordPress/gutenberg#82234) - Menu: Use Text for item labels and descriptions (WordPress/gutenberg#82237) - Test: Type pipe's supported array inputs (WordPress/gutenberg#82210) - Widget Dashboard: keep the plain anchor for an empty-string download (WordPress/gutenberg#82073) - CI: Read the required npm version from a single source (WordPress/gutenberg#82235) - Components: Add `defaultShown`, `onShownChange` to `ToolsPanelItem` (WordPress/gutenberg#78010) - Storybook: Drop unused support for js-as-jsx (WordPress/gutenberg#82192) - Math: Declare clientNavigation interactivity support (WordPress/gutenberg#82248) - Point to docmumentation about release assets (WordPress/gutenberg#82250) - Change stray `ubuntu-latest` to `ubuntu-24.04`. (WordPress/gutenberg#82156) - Performance tests: Reuse the plugin an earlier trunk run already built (WordPress/gutenberg#82223) - Breadcrumb: Add UI component (WordPress/gutenberg#80425) - Components: Cut the ToolsPanel render cascade (WordPress/gutenberg#82180) - Fix: alert dialog box cancel button color (WordPress/gutenberg#82261) - UI: Add Form best practices Storybook page (WordPress/gutenberg#82197) - Media: Stop claiming "Upload complete" when upload failed (WordPress/gutenberg#81397) - Boot, Site Editor: Seed content surfaces with default background color (WordPress/gutenberg#81646) - Format Library: Fix Edit as HTML crash with background-only highlight (WordPress/gutenberg#82215) - Remove the template activation experiment (WordPress/gutenberg#82241) - Packages: Add cross-version compatibility skill (WordPress/gutenberg#81890) - Show the block outline where the grab cursor shows (WordPress/gutenberg#81798) - DataViews: Scope the search field's fixed width to the default UI search row (WordPress/gutenberg#82128) - Background image: support setting the image from a URL (WordPress/gutenberg#82230) - Border Box Control: Try moving the unlink button to the label row, and rename the panel to Borders (WordPress/gutenberg#82163) - Widget Dashboard: govern Reset to default through the policy (WordPress/gutenberg#82255) - Media: Attach unattached media to the current post on save/publish (WordPress/gutenberg#81977) - Widget Dashboard: make the column count a host decision (WordPress/gutenberg#82204) - Global styles: resolve theme-relative background image URLs for display (WordPress/gutenberg#82242) - CI: Unify the automation comments into a single PR comment (WordPress/gutenberg#82249) - Core Data: Convert hooks tests to renderHook and drop JSX (WordPress/gutenberg#82276) - Release: Map [Type] Flaky Test to the Tools changelog section (WordPress/gutenberg#82078) - DateTime tests: freeze the clock in the empty-value calendar test (WordPress/gutenberg#82282) - DataForm: treat combined form fields purely as layout containers (WordPress/gutenberg#82175) - Global styles engine: return a copy from getResolvedValue instead of mutating (WordPress/gutenberg#82278) - Test: Migrate Node unit tests to Vitest (WordPress/gutenberg#82211) - Icons: Redraw 64 icons to be stroke-based. (WordPress/gutenberg#78812) - Tests: Fix Vitest setup and stale jest types under non-hoisting installs (WordPress/gutenberg#82290) - UI: Rename Popup `popupWidth` prop to `width` (WordPress/gutenberg#82193) - Query: Replace the "Reload full page enabled" modal with a snackbar notice (WordPress/gutenberg#82246) - Project Management: Update CODEOWNERS to reflect current participation (WordPress/gutenberg#82262) - Editor: Refactor the Options menu to use the Menu component (WordPress/gutenberg#81564) - UI: Add Field.VisualLabel (WordPress/gutenberg#82095) - Update Stylelint to v17 and related packages (WordPress/gutenberg#80738) - Media: keep indexed PNG sub-sizes indexed (WordPress/gutenberg#81884) - UI: Add Combobox and Autocomplete Status (WordPress/gutenberg#82195) - UI: Drop Status and Empty live region test assertions (WordPress/gutenberg#82300) - Project Management: Remove empty entries from CODEOWNERS (WordPress/gutenberg#82292) - Documentation: Add recommended bulk suppressions configuration for ESLint (WordPress/gutenberg#82303) - UI: Hide Input field ring when a slot control is focused (WordPress/gutenberg#82257) - Widgets: Surface debugging details in the ErrorBoundary (WordPress/gutenberg#82099) - TypeScript: Migrate format-library package to TS (WordPress/gutenberg#79486) - BorderBoxControl: Make sure the group of controls is associated with the label (WordPress/gutenberg#82279) - Image block cropping: Sync image size and link destination settings (WordPress/gutenberg#82316) - Menu: Support multiple item descriptions (WordPress/gutenberg#81825) - CI: Do not fail the type label check on a newly opened pull request (WordPress/gutenberg#82322) - UI: Align overlay Trigger props with Base UI (WordPress/gutenberg#81824) - Gallery block: Fix 'Crop images to fit' broken in editor (WordPress/gutenberg#82318) - Widget Dashboard: enforce the policy on the staging layer for every instance operation (WordPress/gutenberg#82256) - DataForm: Communicate the timezone in the datetime control (WordPress/gutenberg#82291) - Add more e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82239) - Framework: Error on npm versions older than the required floor (WordPress/gutenberg#82320) - Document every type for DataViews/DataForm/Field API (WordPress/gutenberg#82326) - ESLint plugin: remove usage of Babel parser (WordPress/gutenberg#82144) - DataViews: remove the rich text options from the control config type (WordPress/gutenberg#82330) - Meta Boxes: Move meta box markup with moveBefore to keep classic editors alive (WordPress/gutenberg#82243) - Add more e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82327) - Test: Enforce JavaScript test runner ownership (WordPress/gutenberg#82299) - DataViews: clamp page after delete (WordPress/gutenberg#82244) - Stylelint tools: Resolve test config extends from the workspace (WordPress/gutenberg#82336) - Editor: Deprecate the `as` prop of the plugin menu item components (WordPress/gutenberg#82319) - Icons: Convert Search icon to strokes (WordPress/gutenberg#82338) - DataViews: Document that table column styles do not apply to the primary column (WordPress/gutenberg#82238) - DataViews: add hierarchical levels story (WordPress/gutenberg#82344) - CI: Add "Required changes from trunk" PR check (WordPress/gutenberg#82272) - feat: Improve TypeScript definitions in the getEntityRecord function (WordPress/gutenberg#81863) - Framework: Update Node.js to v24 LTS and npm to v11 (WordPress/gutenberg#80395) - Revert "Framework: Update Node.js to v24 LTS and npm to v11 (WordPress/gutenberg#80395)" (WordPress/gutenberg#82355) - UI: Remove ValidityIndicator outer margin (WordPress/gutenberg#82267) - Span the writing flow focus capture elements over the canvas (WordPress/gutenberg#82354) - Fields: Hide the slug field for posts without a permalink (WordPress/gutenberg#82341) - Fix: Responsive horizontal orientation does not override a vertical layout. (WordPress/gutenberg#82364) - View Config: Move the table column style descriptions to the 7.2 compat layer (WordPress/gutenberg#82372) - Block Library: Allow themes to override the padding added via background color (WordPress/gutenberg#82024) - DataViews: Append an ellipsis to action labels that open a dialog (WordPress/gutenberg#81994) - Pages: require authentication and a capability to render generated standalone pages (WordPress/gutenberg#82254) - Build/Test Tools: Replace npx with npm exec --no (WordPress/gutenberg#82331) - Navigation: restore flex-grow on container when accessible label is present (WordPress/gutenberg#78447) - DOM Ready: Exclude src from published package files (WordPress/gutenberg#77302) - UI: Support custom targets on Link and Menu.LinkItem (WordPress/gutenberg#82347) - Escape HTML: Exclude src from published package files (WordPress/gutenberg#77304) - keycodes: Exclude src from published files (WordPress/gutenberg#77306) - Packages: Exclude src from block-serialization-default-parser published package (WordPress/gutenberg#77307) - A11y: Exclude src from published package files (WordPress/gutenberg#77309) - Packages: Exclude src from autop published package (WordPress/gutenberg#77283) - Blob: Exclude src from published package files (WordPress/gutenberg#77289) - Packages: Exclude src from deprecated published package (WordPress/gutenberg#77303) - fix(list-reusable-blocks): exclude src from published files (WordPress/gutenberg#77305) - Admin UI: Exclude src from published files and sideEffects (WordPress/gutenberg#77285) - Standardize 'Back' and 'Go back' labels (WordPress/gutenberg#79211) - Audio: Update autoplay help text for clarity (WordPress/gutenberg#69978) - Theme JSON: Avoid rebuilding identical block schemas during sanitization (WordPress/gutenberg#82203) - Docs: Improve setAttributes updater function wording (WordPress/gutenberg#82405) - Query Loop: Rename the "Keyword" filter to "Search terms" and add help text (WordPress/gutenberg#82387) - CI: add a per-workflow status check job and filter paths (WordPress/gutenberg#81015) - ESLint: Thin use-recommended-components tests (WordPress/gutenberg#82407) - UI: Fix enabled input placeholder contrast (WordPress/gutenberg#82304) - Tab trap escape hatch: leave/enter the canvas with Escape/Enter (WordPress/gutenberg#82314) - List: preserve client IDs on indent, just like outdent (WordPress/gutenberg#59216) - Templates REST API: prevent fatal error when a null template reaches prepare_item_for_response (WordPress/gutenberg#82374) - Editor: Refactor the View menu to use the Menu component (WordPress/gutenberg#82321) - CSS Styling: Cleanup focus outline override for grid component (WordPress/gutenberg#82337) - E2E: Run the site editor suite against the extensible site editor too (WordPress/gutenberg#82117) - Fields: Remove unused CSS rule from slug field control (WordPress/gutenberg#77961) - Fix: Footnote IDs can start with a digit and break CSS selectors (WordPress/gutenberg#82398) - feat: Introduce 'Add Media' in the block controls for media-text block (WordPress/gutenberg#82420) - fix: Audio element to have it's own name (WordPress/gutenberg#82389) - Docs: Update Playground CLI wording (WordPress/gutenberg#77579) - Upgrade React 19 to 19.2.8, read version from package.json (WordPress/gutenberg#82439) - Tab Panel: Show focus with outline instead of legacy box-shadow ring (WordPress/gutenberg#82421) - Editor: Fix disabled and link items of the more menu adapter (WordPress/gutenberg#82428) - UI: Fix Menu.LinkItem target detection (WordPress/gutenberg#82442) - SearchableSelect: Add form primitive to @wordpress/ui (WordPress/gutenberg#80961) - Validated form controls: Use design token for invalid focus rings (WordPress/gutenberg#82410) - feat: Update layout icons (WordPress/gutenberg#82025) - Widgets: Replace {TODO} placeholder with PR number in changelog entries (WordPress/gutenberg#82450) - UI: Remove ESLint ref suppressions and refactor AlertDialog state (WordPress/gutenberg#82131) - Menu: Align selection indicators and prefix icons with item labels (WordPress/gutenberg#82346) - ToggleGroupControl: Honor the root disabled prop (WordPress/gutenberg#82259) - Block Library: Remove the form blocks experiment (WordPress/gutenberg#82451) - List: indent and outdent multi-selected items with Tab (WordPress/gutenberg#82411) - CodeRabbit: Only review on request, keep PR descriptions untouched (WordPress/gutenberg#82448) - Privacy policy page badge: make it visible in Site Editor > Pages and Editor Inspector (WordPress/gutenberg#82422) - Support `isAny` and `isNone` filter operators for numeric fields. (WordPress/gutenberg#77942) - UI: Keep focus rings visible in overlay content (WordPress/gutenberg#82443) - Menu: Correct alignment documentation and changelog (WordPress/gutenberg#82455) - UI: Name unlabeled form primitive stories (WordPress/gutenberg#82311) - UI: Re-read the native validity on blur in ControlWithError (WordPress/gutenberg#82376) - Media Utils: Preserve arrays in multipart form data (WordPress/gutenberg#82353) - fix: Remove stories from performance tests (WordPress/gutenberg#82459) - Add the template e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82394) - UI: Fix Link target detection (WordPress/gutenberg#82447) - Fix privacy policy page setting unit test on multisite (WordPress/gutenberg#82467) - UI, DataViews: Give input and selection controls solid backgrounds (WordPress/gutenberg#82391) - Fix LocationPicker popover alignment with InputGroup (WordPress/gutenberg#82090) - List: indent and outdent a fully selected list item with Tab (WordPress/gutenberg#82460) - UI: Fix Minimal Select popup width (WordPress/gutenberg#82461) - Rich text: resolve owned event listeners once instead of per subscriber (WordPress/gutenberg#80605) - UI: Keep borderless InputLayout chrome when disabled (WordPress/gutenberg#82468) - Theme: Cache luminance for contrast checks (WordPress/gutenberg#82445) - Add promptfoo for testing agent development setup and skills (WordPress/gutenberg#80812) - wp-env: Fix Docker build errors with Debian Bullseye repositories (WordPress/gutenberg#82478) - Query Loop: Fall back to `post` when the query has no `postType` (WordPress/gutenberg#82465) - Block Supports: Bail early in state styles when a block has no style attribute (WordPress/gutenberg#81908) - CSS Styling: Represent focus with outline for list view component (WordPress/gutenberg#82129) - Icons: Remove the obsolete forced colors mode hack (WordPress/gutenberg#82481) - Docs: Remove invalid `@return` tag from the `block_core_social_link_get_services` hook docblock (WordPress/gutenberg#82488) - Site Editor: Add a root error boundary to prevent a blank screen (WordPress/gutenberg#82486) - Writing Flow: Bail out of Enter handling when no block is selected (WordPress/gutenberg#82424) - Docs: Remove the blank line between @PARAM and @return in test docblocks (WordPress/gutenberg#81907) - List View: Disable block icon colors while the block is selected (WordPress/gutenberg#82498) - Fix: Restore layout styles for block style variations (WordPress/gutenberg#82335) - Post slug: prefer server sanitization in the editor (WordPress/gutenberg#78135) - Media Modal Experiment: Allow filtering by attached to the post, or unattached (WordPress/gutenberg#81974) - Media editor: Lock the editing tools while a save is running (WordPress/gutenberg#82417) - DataViews: Restrict the isAll filter operator to array fields (WordPress/gutenberg#82463) - Media Fields: Pass the field's disabled state to the textarea controls (WordPress/gutenberg#82516) - Theme: Make chroma capacity caching deterministic (WordPress/gutenberg#82505) - Global Styles: Remove the color randomizer experiment (WordPress/gutenberg#82452) - DataViews: Fix Field.sort TypeScript type definition (WordPress/gutenberg#82162) - Migrate __experimentalText and __experimentalHeading to @wordpress/ui Text in Inspector Popover Header (WordPress/gutenberg#77449) - Migrate __experimentalText to @wordpress/ui Text in Block switcher bindings hint (WordPress/gutenberg#77366) - UI: Add Radio form primitive (WordPress/gutenberg#82214) - Migrate __experimentalText to @wordpress/ui Text in Allowed Blocks Modal (WordPress/gutenberg#78119) - UI: Add CheckboxControl (WordPress/gutenberg#82213) - Core Data: Scope revisionId to the entity it is provided for (WordPress/gutenberg#82517) - Migrate __experimentalText to @wordpress/ui Text in Pattern Overrides Dropdown (WordPress/gutenberg#77492) - ProgressBar: Respect reduced motion preferences (WordPress/gutenberg#82490) - Theme: Clarify color seed and warning guarantees (WordPress/gutenberg#82526) - Theme: Build default ramps before token artifacts (WordPress/gutenberg#82525) - CodeRabbit: Disable the review status comment (WordPress/gutenberg#82534) - Project Management: Restore CODEOWNERS exclusions for suppression lists (WordPress/gutenberg#82538) - Editor: merge duplicate "Enhancements" changelog sections (WordPress/gutenberg#82533) - UI: Validate compound component context (WordPress/gutenberg#82510) - Docs: Document isolated worktree setup (WordPress/gutenberg#82524) - DataForm: render untyped fields without an edit control that are read-only (WordPress/gutenberg#82514) - API Fetch: Add unregister to remove a registered middleware (WordPress/gutenberg#82408) - Editor: Show revision data in Post Title component (WordPress/gutenberg#82536) - Components: Add compound component composition diagnostics (WordPress/gutenberg#82509) - Fieldset: Fix gap token to match spec (WordPress/gutenberg#75479) - Test: Migrate deterministic JSDOM tests and harden Vitest isolation (WordPress/gutenberg#82212) - Release: Make npm publication verification resumable (WordPress/gutenberg#82089) - Block Library: Use 'useEntityProp' in Site Title and Tagline blocks (WordPress/gutenberg#82518) - Theme: Migrate Terrazzo modes to resolvers (WordPress/gutenberg#82537) - Fix auto-capitalization after Enter on iOS Safari (WordPress/gutenberg#82475) - Update navigation link block name, use a default variation for custom link (WordPress/gutenberg#82375) - API Fetch: Expose defaultFetchHandler so overrides can restore it (WordPress/gutenberg#82553) - Core Data: Return a stable record for equivalent `_fields` queries (WordPress/gutenberg#82552) - API Fetch: Rename defaultFetchHandler parameter to options (WordPress/gutenberg#82588) - Fields: remove unused custom sort from the author fields (WordPress/gutenberg#82559) - Fields: Declare the caption, alt text, description and ping status controls through the Field API (WordPress/gutenberg#82539) - Docs: Align @PARAM tag columns in phpunit/ docblocks (WordPress/gutenberg#81904) - Docs: Align @PARAM tag columns in lib/ docblocks (WordPress/gutenberg#81902) - Docs: Align @PARAM tag columns in packages/ docblocks (WordPress/gutenberg#81903) - Fix help paragraph color contrast ratio in the Connectors page. (WordPress/gutenberg#82378) - DataViews: Declare transitive dependencies imported by the ./wp bundle (WordPress/gutenberg#81843) - DataForm: Add a `showPlaceholderIfEmpty` option to the panel layout (WordPress/gutenberg#82527) - Global Styles UI: migrate revisions Active Badge to UI Badge (WordPress/gutenberg#82560) - UI: Put overflow on Select.List instead of a nested wrapper (WordPress/gutenberg#82470) - Editor: migrate post-card-panel Badge to UI Badge (WordPress/gutenberg#82500) - Fields: migrate page-title Badge to UI Badge (WordPress/gutenberg#82499) - DataViews: Skip table columns for field ids without a field definition (WordPress/gutenberg#82601) - View config: remove stale fields from the wp_template default view (WordPress/gutenberg#82602) - Rich text: restore contenteditable on pointercancel (WordPress/gutenberg#82598) - Components: Add an Emotion-to-SCSS migration skill and guide (WordPress/gutenberg#82567) See #66070. git-svn-id: https://develop.svn.wordpress.org/trunk@63538 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 8, 2026
This updates the pinned commit hash of the Gutenberg repository from `658c8cbe89db5d90279051d3bb816ca210fe4646 ` (version `23.8.0`) to `5a4cc502d43016f1efa66f8f6d9bd3bb4bb24d85`, which contains the latest changes up until the Node.js version was bumped from 20.x to 24.x. A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/658c8cbe89db5d90279051d3bb816ca210fe4646..5a4cc502d43016f1efa66f8f6d9bd3bb4bb24d85. - Menu: Stabilize iframe reload test (WordPress/gutenberg#82081) - Packages: Recover August 26 npm release metadata (WordPress/gutenberg#82085) - Storybook: Demonstrate light, dark, and nested themes (WordPress/gutenberg#82039) - Project Management: Add validation for missing GitHub labels configuration (WordPress/gutenberg#76263) - Automated Testing: Enforce `.tsx` for all new React files (WordPress/gutenberg#80123) - UI: Use root theme for portaled overlays (WordPress/gutenberg#82038) - Menu: Stabilize portaled iframe test (WordPress/gutenberg#82092) - Theme: Move post-release changelog entry to Unreleased (WordPress/gutenberg#82093) - Media: Refuse a multi-file drop on a placeholder that takes one file (WordPress/gutenberg#82046) - Font Library: Keep CSS custom properties unquoted in font previews (WordPress/gutenberg#82010) - Add "reading settings" link to Front Page template (WordPress/gutenberg#81987) - Docs: Fix grammar in documentation (WordPress/gutenberg#82032) - Media Editor: refactor the panel layout (WordPress/gutenberg#81840) - DataViews layout storybook: action names and primary status (WordPress/gutenberg#82104) - Make `@wordpress/reusable-blocks` a no-op compatibility package (WordPress/gutenberg#79186) - Widget Dashboard: add a Policy provider to govern what users may do (WordPress/gutenberg#81967) - Build Package: Restore Core Boot layout compatibility (WordPress/gutenberg#82112) - Edit Widgets: Guard canInsertBlockInWidgetArea against an empty block list (WordPress/gutenberg#82107) - Build: Enforce NodeNext resolution for ESM packages (WordPress/gutenberg#82088) - UI: Remove unused outset-ring--focus-within-visible class. (WordPress/gutenberg#82077) - Inserter: Keep the block preview inside the viewport (WordPress/gutenberg#82060) - Test: Enforce Vitest conventions and CI guardrails (WordPress/gutenberg#81040) - Editor: Apply the showListViewByDefault preference in the shared editor (WordPress/gutenberg#82119) - Release: Use CLI runtime for package publishing (WordPress/gutenberg#82122) - Reusable Blocks: Remove leftover merge conflict markers from the changelog (WordPress/gutenberg#82126) - chore: Update grep settings and remove comments (WordPress/gutenberg#82121) - Fix: Content Guidelines: UX/UI Accessibility issues (WordPress/gutenberg#80306) - Extensible Site Editor: Let menu items be added from the navigation screen (WordPress/gutenberg#82125) - Navigation: Change WCText to Text (WordPress/gutenberg#82130) - Storybook: Persist sidebar theme in URL (WordPress/gutenberg#82111) - Editor assets endpoint: prime the theme JSON resolver before capturing (WordPress/gutenberg#82134) - Remove unused dependencies across the monorepo (WordPress/gutenberg#82103) - Update changelog instructions for agents (WordPress/gutenberg#82097) - Build: Normalize JSX file extensions (WordPress/gutenberg#80990) - Fix pattern export filenames by normalizing special characters (WordPress/gutenberg#77033) - Site editor v2: navigation takes view config from endpoint (WordPress/gutenberg#82138) - Extensible Site Editor: Load media assets before the media fields open (WordPress/gutenberg#82135) - Site editor v2: pages take view config from endpoint (WordPress/gutenberg#82140) - Extensible site editor: Add a revisions entry point to the Styles route (WordPress/gutenberg#82142) - List: outdent an empty middle item without adding an item (WordPress/gutenberg#82011) - Extensible site editor: Fall back to the raw title in edit route document titles (WordPress/gutenberg#82143) - Blocks: Make BlockTransform a discriminated union over its type (WordPress/gutenberg#81831) - Theme: add LightningCSS WPDS token fallback plugin (WordPress/gutenberg#80401) - UI: Add popupWidth prop to item popup components (WordPress/gutenberg#82087) - Snackbar: Restart timeout when a notice is recreated (WordPress/gutenberg#81764) - Media: Report server upload failures in plain language (WordPress/gutenberg#81735) - Format library: visualise non-breaking spaces (WordPress/gutenberg#74040) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#81932) - Try adding a Grid block variation to Gallery (WordPress/gutenberg#81909) - Components: Keep foreign items out of a ToolsPanel menu (WordPress/gutenberg#82127) - Enable Gallery columns and crop controls in viewport states (WordPress/gutenberg#82003) - Query: Don't write excludeCurrent into blocks that never had it (WordPress/gutenberg#82147) - Site title: Add fit-text support. (WordPress/gutenberg#82074) - Accordion Panel: Reset padding-block when panel is hidden (WordPress/gutenberg#81782) - Replace npm-run-all with native npm script chaining (WordPress/gutenberg#82166) - Grid: per-item tile size limits (WordPress/gutenberg#81899) - Fix: Tabs block: Anchor links in tab panels are not functional (WordPress/gutenberg#81744) - Validate tsconfig references against declared dependencies (WordPress/gutenberg#82106) - Performance tests: Build once and shard the suites across parallel CI jobs (WordPress/gutenberg#82160) - Site Health widget: route the body's review link through the host (WordPress/gutenberg#82066) - Build: allow wp-theme 2.x peer deps (WordPress/gutenberg#82139) - Bundled packages: Add a check for transitive private API usage (WordPress/gutenberg#82027) - List: try to preserve indentation level of children after outdenting+merging their parent (WordPress/gutenberg#82145) - Block Library: Fix categories block handling of invalid taxonomy (WordPress/gutenberg#82153) - useViewConfig: don't request the view config twice (WordPress/gutenberg#82141) - Documentation: Remove invalid references to Babel in packages README (WordPress/gutenberg#82176) - Automated Testing: Fix failing categories test on trunk (WordPress/gutenberg#82182) - Jest: Update to 30.5.0 (WordPress/gutenberg#82181) - Fix: Retain focus and caret position after Backspace undo of a prefix block transform (WordPress/gutenberg#82116) - Scaffold e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82178) - Package lock: Deduplicate Jest dependencies (WordPress/gutenberg#82187) - Components: Migrate remaining JSX files to TypeScript (WordPress/gutenberg#82132) - Text: Use pretty wrapping by default (WordPress/gutenberg#82133) - Build Tooling: Add browserslist config for build targeting (WordPress/gutenberg#82179) - Columns: Fix appender drop zone visibility when dragging into empty column (WordPress/gutenberg#77852) - Build: Require explicit JSX file extensions (WordPress/gutenberg#82189) - Icons: Redraw 35 prominent icons with consistent stroke widths (WordPress/gutenberg#78808) - Test: Classify and enforce unit test environments by filename (WordPress/gutenberg#80991) - Test: Fix CI failures on trunk (WordPress/gutenberg#82201) - Fix editor link colour cascade order for nested blocks (WordPress/gutenberg#77833) - Add New Template: Show the design system focus ring instead of legacy box-shadow rings (WordPress/gutenberg#82164) - List View: Don’t focus the last Table cell on keyboard activation (WordPress/gutenberg#81964) - Fix spelling typos in docs and inline comments (WordPress/gutenberg#82217) - CI: Pin npm version in the private API check job (WordPress/gutenberg#82222) - Private APIs: Add back '@wordpress/dataviews' to the allowed core modules (WordPress/gutenberg#82221) - Editor: Mark __unstableSaveForPreview options as optional (WordPress/gutenberg#81858) - Docs: Explain when the Cover block's overlay controls appear (WordPress/gutenberg#82234) - Menu: Use Text for item labels and descriptions (WordPress/gutenberg#82237) - Test: Type pipe's supported array inputs (WordPress/gutenberg#82210) - Widget Dashboard: keep the plain anchor for an empty-string download (WordPress/gutenberg#82073) - CI: Read the required npm version from a single source (WordPress/gutenberg#82235) - Components: Add `defaultShown`, `onShownChange` to `ToolsPanelItem` (WordPress/gutenberg#78010) - Storybook: Drop unused support for js-as-jsx (WordPress/gutenberg#82192) - Math: Declare clientNavigation interactivity support (WordPress/gutenberg#82248) - Point to docmumentation about release assets (WordPress/gutenberg#82250) - Change stray `ubuntu-latest` to `ubuntu-24.04`. (WordPress/gutenberg#82156) - Performance tests: Reuse the plugin an earlier trunk run already built (WordPress/gutenberg#82223) - Breadcrumb: Add UI component (WordPress/gutenberg#80425) - Components: Cut the ToolsPanel render cascade (WordPress/gutenberg#82180) - Fix: alert dialog box cancel button color (WordPress/gutenberg#82261) - UI: Add Form best practices Storybook page (WordPress/gutenberg#82197) - Media: Stop claiming "Upload complete" when upload failed (WordPress/gutenberg#81397) - Boot, Site Editor: Seed content surfaces with default background color (WordPress/gutenberg#81646) - Format Library: Fix Edit as HTML crash with background-only highlight (WordPress/gutenberg#82215) - Remove the template activation experiment (WordPress/gutenberg#82241) - Packages: Add cross-version compatibility skill (WordPress/gutenberg#81890) - Show the block outline where the grab cursor shows (WordPress/gutenberg#81798) - DataViews: Scope the search field's fixed width to the default UI search row (WordPress/gutenberg#82128) - Background image: support setting the image from a URL (WordPress/gutenberg#82230) - Border Box Control: Try moving the unlink button to the label row, and rename the panel to Borders (WordPress/gutenberg#82163) - Widget Dashboard: govern Reset to default through the policy (WordPress/gutenberg#82255) - Media: Attach unattached media to the current post on save/publish (WordPress/gutenberg#81977) - Widget Dashboard: make the column count a host decision (WordPress/gutenberg#82204) - Global styles: resolve theme-relative background image URLs for display (WordPress/gutenberg#82242) - CI: Unify the automation comments into a single PR comment (WordPress/gutenberg#82249) - Core Data: Convert hooks tests to renderHook and drop JSX (WordPress/gutenberg#82276) - Release: Map [Type] Flaky Test to the Tools changelog section (WordPress/gutenberg#82078) - DateTime tests: freeze the clock in the empty-value calendar test (WordPress/gutenberg#82282) - DataForm: treat combined form fields purely as layout containers (WordPress/gutenberg#82175) - Global styles engine: return a copy from getResolvedValue instead of mutating (WordPress/gutenberg#82278) - Test: Migrate Node unit tests to Vitest (WordPress/gutenberg#82211) - Icons: Redraw 64 icons to be stroke-based. (WordPress/gutenberg#78812) - Tests: Fix Vitest setup and stale jest types under non-hoisting installs (WordPress/gutenberg#82290) - UI: Rename Popup `popupWidth` prop to `width` (WordPress/gutenberg#82193) - Query: Replace the "Reload full page enabled" modal with a snackbar notice (WordPress/gutenberg#82246) - Project Management: Update CODEOWNERS to reflect current participation (WordPress/gutenberg#82262) - Editor: Refactor the Options menu to use the Menu component (WordPress/gutenberg#81564) - UI: Add Field.VisualLabel (WordPress/gutenberg#82095) - Update Stylelint to v17 and related packages (WordPress/gutenberg#80738) - Media: keep indexed PNG sub-sizes indexed (WordPress/gutenberg#81884) - UI: Add Combobox and Autocomplete Status (WordPress/gutenberg#82195) - UI: Drop Status and Empty live region test assertions (WordPress/gutenberg#82300) - Project Management: Remove empty entries from CODEOWNERS (WordPress/gutenberg#82292) - Documentation: Add recommended bulk suppressions configuration for ESLint (WordPress/gutenberg#82303) - UI: Hide Input field ring when a slot control is focused (WordPress/gutenberg#82257) - Widgets: Surface debugging details in the ErrorBoundary (WordPress/gutenberg#82099) - TypeScript: Migrate format-library package to TS (WordPress/gutenberg#79486) - BorderBoxControl: Make sure the group of controls is associated with the label (WordPress/gutenberg#82279) - Image block cropping: Sync image size and link destination settings (WordPress/gutenberg#82316) - Menu: Support multiple item descriptions (WordPress/gutenberg#81825) - CI: Do not fail the type label check on a newly opened pull request (WordPress/gutenberg#82322) - UI: Align overlay Trigger props with Base UI (WordPress/gutenberg#81824) - Gallery block: Fix 'Crop images to fit' broken in editor (WordPress/gutenberg#82318) - Widget Dashboard: enforce the policy on the staging layer for every instance operation (WordPress/gutenberg#82256) - DataForm: Communicate the timezone in the datetime control (WordPress/gutenberg#82291) - Add more e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82239) - Framework: Error on npm versions older than the required floor (WordPress/gutenberg#82320) - Document every type for DataViews/DataForm/Field API (WordPress/gutenberg#82326) - ESLint plugin: remove usage of Babel parser (WordPress/gutenberg#82144) - DataViews: remove the rich text options from the control config type (WordPress/gutenberg#82330) - Meta Boxes: Move meta box markup with moveBefore to keep classic editors alive (WordPress/gutenberg#82243) - Add more e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82327) - Test: Enforce JavaScript test runner ownership (WordPress/gutenberg#82299) - DataViews: clamp page after delete (WordPress/gutenberg#82244) - Stylelint tools: Resolve test config extends from the workspace (WordPress/gutenberg#82336) - Editor: Deprecate the `as` prop of the plugin menu item components (WordPress/gutenberg#82319) - Icons: Convert Search icon to strokes (WordPress/gutenberg#82338) - DataViews: Document that table column styles do not apply to the primary column (WordPress/gutenberg#82238) - DataViews: add hierarchical levels story (WordPress/gutenberg#82344) - CI: Add "Required changes from trunk" PR check (WordPress/gutenberg#82272) - feat: Improve TypeScript definitions in the getEntityRecord function (WordPress/gutenberg#81863) - Framework: Update Node.js to v24 LTS and npm to v11 (WordPress/gutenberg#80395) - Revert "Framework: Update Node.js to v24 LTS and npm to v11 (WordPress/gutenberg#80395)" (WordPress/gutenberg#82355) - UI: Remove ValidityIndicator outer margin (WordPress/gutenberg#82267) - Span the writing flow focus capture elements over the canvas (WordPress/gutenberg#82354) - Fields: Hide the slug field for posts without a permalink (WordPress/gutenberg#82341) - Fix: Responsive horizontal orientation does not override a vertical layout. (WordPress/gutenberg#82364) - View Config: Move the table column style descriptions to the 7.2 compat layer (WordPress/gutenberg#82372) - Block Library: Allow themes to override the padding added via background color (WordPress/gutenberg#82024) - DataViews: Append an ellipsis to action labels that open a dialog (WordPress/gutenberg#81994) - Pages: require authentication and a capability to render generated standalone pages (WordPress/gutenberg#82254) - Build/Test Tools: Replace npx with npm exec --no (WordPress/gutenberg#82331) - Navigation: restore flex-grow on container when accessible label is present (WordPress/gutenberg#78447) - DOM Ready: Exclude src from published package files (WordPress/gutenberg#77302) - UI: Support custom targets on Link and Menu.LinkItem (WordPress/gutenberg#82347) - Escape HTML: Exclude src from published package files (WordPress/gutenberg#77304) - keycodes: Exclude src from published files (WordPress/gutenberg#77306) - Packages: Exclude src from block-serialization-default-parser published package (WordPress/gutenberg#77307) - A11y: Exclude src from published package files (WordPress/gutenberg#77309) - Packages: Exclude src from autop published package (WordPress/gutenberg#77283) - Blob: Exclude src from published package files (WordPress/gutenberg#77289) - Packages: Exclude src from deprecated published package (WordPress/gutenberg#77303) - fix(list-reusable-blocks): exclude src from published files (WordPress/gutenberg#77305) - Admin UI: Exclude src from published files and sideEffects (WordPress/gutenberg#77285) - Standardize 'Back' and 'Go back' labels (WordPress/gutenberg#79211) - Audio: Update autoplay help text for clarity (WordPress/gutenberg#69978) - Theme JSON: Avoid rebuilding identical block schemas during sanitization (WordPress/gutenberg#82203) - Docs: Improve setAttributes updater function wording (WordPress/gutenberg#82405) - Query Loop: Rename the "Keyword" filter to "Search terms" and add help text (WordPress/gutenberg#82387) - CI: add a per-workflow status check job and filter paths (WordPress/gutenberg#81015) - ESLint: Thin use-recommended-components tests (WordPress/gutenberg#82407) - UI: Fix enabled input placeholder contrast (WordPress/gutenberg#82304) - Tab trap escape hatch: leave/enter the canvas with Escape/Enter (WordPress/gutenberg#82314) - List: preserve client IDs on indent, just like outdent (WordPress/gutenberg#59216) - Templates REST API: prevent fatal error when a null template reaches prepare_item_for_response (WordPress/gutenberg#82374) - Editor: Refactor the View menu to use the Menu component (WordPress/gutenberg#82321) - CSS Styling: Cleanup focus outline override for grid component (WordPress/gutenberg#82337) - E2E: Run the site editor suite against the extensible site editor too (WordPress/gutenberg#82117) - Fields: Remove unused CSS rule from slug field control (WordPress/gutenberg#77961) - Fix: Footnote IDs can start with a digit and break CSS selectors (WordPress/gutenberg#82398) - feat: Introduce 'Add Media' in the block controls for media-text block (WordPress/gutenberg#82420) - fix: Audio element to have it's own name (WordPress/gutenberg#82389) - Docs: Update Playground CLI wording (WordPress/gutenberg#77579) - Upgrade React 19 to 19.2.8, read version from package.json (WordPress/gutenberg#82439) - Tab Panel: Show focus with outline instead of legacy box-shadow ring (WordPress/gutenberg#82421) - Editor: Fix disabled and link items of the more menu adapter (WordPress/gutenberg#82428) - UI: Fix Menu.LinkItem target detection (WordPress/gutenberg#82442) - SearchableSelect: Add form primitive to @wordpress/ui (WordPress/gutenberg#80961) - Validated form controls: Use design token for invalid focus rings (WordPress/gutenberg#82410) - feat: Update layout icons (WordPress/gutenberg#82025) - Widgets: Replace {TODO} placeholder with PR number in changelog entries (WordPress/gutenberg#82450) - UI: Remove ESLint ref suppressions and refactor AlertDialog state (WordPress/gutenberg#82131) - Menu: Align selection indicators and prefix icons with item labels (WordPress/gutenberg#82346) - ToggleGroupControl: Honor the root disabled prop (WordPress/gutenberg#82259) - Block Library: Remove the form blocks experiment (WordPress/gutenberg#82451) - List: indent and outdent multi-selected items with Tab (WordPress/gutenberg#82411) - CodeRabbit: Only review on request, keep PR descriptions untouched (WordPress/gutenberg#82448) - Privacy policy page badge: make it visible in Site Editor > Pages and Editor Inspector (WordPress/gutenberg#82422) - Support `isAny` and `isNone` filter operators for numeric fields. (WordPress/gutenberg#77942) - UI: Keep focus rings visible in overlay content (WordPress/gutenberg#82443) - Menu: Correct alignment documentation and changelog (WordPress/gutenberg#82455) - UI: Name unlabeled form primitive stories (WordPress/gutenberg#82311) - UI: Re-read the native validity on blur in ControlWithError (WordPress/gutenberg#82376) - Media Utils: Preserve arrays in multipart form data (WordPress/gutenberg#82353) - fix: Remove stories from performance tests (WordPress/gutenberg#82459) - Add the template e2e tests for the editor inspector consolidation experiment (WordPress/gutenberg#82394) - UI: Fix Link target detection (WordPress/gutenberg#82447) - Fix privacy policy page setting unit test on multisite (WordPress/gutenberg#82467) - UI, DataViews: Give input and selection controls solid backgrounds (WordPress/gutenberg#82391) - Fix LocationPicker popover alignment with InputGroup (WordPress/gutenberg#82090) - List: indent and outdent a fully selected list item with Tab (WordPress/gutenberg#82460) - UI: Fix Minimal Select popup width (WordPress/gutenberg#82461) - Rich text: resolve owned event listeners once instead of per subscriber (WordPress/gutenberg#80605) - UI: Keep borderless InputLayout chrome when disabled (WordPress/gutenberg#82468) - Theme: Cache luminance for contrast checks (WordPress/gutenberg#82445) - Add promptfoo for testing agent development setup and skills (WordPress/gutenberg#80812) - wp-env: Fix Docker build errors with Debian Bullseye repositories (WordPress/gutenberg#82478) - Query Loop: Fall back to `post` when the query has no `postType` (WordPress/gutenberg#82465) - Block Supports: Bail early in state styles when a block has no style attribute (WordPress/gutenberg#81908) - CSS Styling: Represent focus with outline for list view component (WordPress/gutenberg#82129) - Icons: Remove the obsolete forced colors mode hack (WordPress/gutenberg#82481) - Docs: Remove invalid `@return` tag from the `block_core_social_link_get_services` hook docblock (WordPress/gutenberg#82488) - Site Editor: Add a root error boundary to prevent a blank screen (WordPress/gutenberg#82486) - Writing Flow: Bail out of Enter handling when no block is selected (WordPress/gutenberg#82424) - Docs: Remove the blank line between @PARAM and @return in test docblocks (WordPress/gutenberg#81907) - List View: Disable block icon colors while the block is selected (WordPress/gutenberg#82498) - Fix: Restore layout styles for block style variations (WordPress/gutenberg#82335) - Post slug: prefer server sanitization in the editor (WordPress/gutenberg#78135) - Media Modal Experiment: Allow filtering by attached to the post, or unattached (WordPress/gutenberg#81974) - Media editor: Lock the editing tools while a save is running (WordPress/gutenberg#82417) - DataViews: Restrict the isAll filter operator to array fields (WordPress/gutenberg#82463) - Media Fields: Pass the field's disabled state to the textarea controls (WordPress/gutenberg#82516) - Theme: Make chroma capacity caching deterministic (WordPress/gutenberg#82505) - Global Styles: Remove the color randomizer experiment (WordPress/gutenberg#82452) - DataViews: Fix Field.sort TypeScript type definition (WordPress/gutenberg#82162) - Migrate __experimentalText and __experimentalHeading to @wordpress/ui Text in Inspector Popover Header (WordPress/gutenberg#77449) - Migrate __experimentalText to @wordpress/ui Text in Block switcher bindings hint (WordPress/gutenberg#77366) - UI: Add Radio form primitive (WordPress/gutenberg#82214) - Migrate __experimentalText to @wordpress/ui Text in Allowed Blocks Modal (WordPress/gutenberg#78119) - UI: Add CheckboxControl (WordPress/gutenberg#82213) - Core Data: Scope revisionId to the entity it is provided for (WordPress/gutenberg#82517) - Migrate __experimentalText to @wordpress/ui Text in Pattern Overrides Dropdown (WordPress/gutenberg#77492) - ProgressBar: Respect reduced motion preferences (WordPress/gutenberg#82490) - Theme: Clarify color seed and warning guarantees (WordPress/gutenberg#82526) - Theme: Build default ramps before token artifacts (WordPress/gutenberg#82525) - CodeRabbit: Disable the review status comment (WordPress/gutenberg#82534) - Project Management: Restore CODEOWNERS exclusions for suppression lists (WordPress/gutenberg#82538) - Editor: merge duplicate "Enhancements" changelog sections (WordPress/gutenberg#82533) - UI: Validate compound component context (WordPress/gutenberg#82510) - Docs: Document isolated worktree setup (WordPress/gutenberg#82524) - DataForm: render untyped fields without an edit control that are read-only (WordPress/gutenberg#82514) - API Fetch: Add unregister to remove a registered middleware (WordPress/gutenberg#82408) - Editor: Show revision data in Post Title component (WordPress/gutenberg#82536) - Components: Add compound component composition diagnostics (WordPress/gutenberg#82509) - Fieldset: Fix gap token to match spec (WordPress/gutenberg#75479) - Test: Migrate deterministic JSDOM tests and harden Vitest isolation (WordPress/gutenberg#82212) - Release: Make npm publication verification resumable (WordPress/gutenberg#82089) - Block Library: Use 'useEntityProp' in Site Title and Tagline blocks (WordPress/gutenberg#82518) - Theme: Migrate Terrazzo modes to resolvers (WordPress/gutenberg#82537) - Fix auto-capitalization after Enter on iOS Safari (WordPress/gutenberg#82475) - Update navigation link block name, use a default variation for custom link (WordPress/gutenberg#82375) - API Fetch: Expose defaultFetchHandler so overrides can restore it (WordPress/gutenberg#82553) - Core Data: Return a stable record for equivalent `_fields` queries (WordPress/gutenberg#82552) - API Fetch: Rename defaultFetchHandler parameter to options (WordPress/gutenberg#82588) - Fields: remove unused custom sort from the author fields (WordPress/gutenberg#82559) - Fields: Declare the caption, alt text, description and ping status controls through the Field API (WordPress/gutenberg#82539) - Docs: Align @PARAM tag columns in phpunit/ docblocks (WordPress/gutenberg#81904) - Docs: Align @PARAM tag columns in lib/ docblocks (WordPress/gutenberg#81902) - Docs: Align @PARAM tag columns in packages/ docblocks (WordPress/gutenberg#81903) - Fix help paragraph color contrast ratio in the Connectors page. (WordPress/gutenberg#82378) - DataViews: Declare transitive dependencies imported by the ./wp bundle (WordPress/gutenberg#81843) - DataForm: Add a `showPlaceholderIfEmpty` option to the panel layout (WordPress/gutenberg#82527) - Global Styles UI: migrate revisions Active Badge to UI Badge (WordPress/gutenberg#82560) - UI: Put overflow on Select.List instead of a nested wrapper (WordPress/gutenberg#82470) - Editor: migrate post-card-panel Badge to UI Badge (WordPress/gutenberg#82500) - Fields: migrate page-title Badge to UI Badge (WordPress/gutenberg#82499) - DataViews: Skip table columns for field ids without a field definition (WordPress/gutenberg#82601) - View config: remove stale fields from the wp_template default view (WordPress/gutenberg#82602) - Rich text: restore contenteditable on pointercancel (WordPress/gutenberg#82598) - Components: Add an Emotion-to-SCSS migration skill and guide (WordPress/gutenberg#82567) See #66070. Built from https://develop.svn.wordpress.org/trunk@63538 git-svn-id: http://core.svn.wordpress.org/trunk@62714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
12 of 16 tasks
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Possible fix for:
Alternative to #81804 and #81856.
In the editor package, when the post is being saved or published, iterate over the blocks in the post and attach all unattached images that appear in the post as image blocks.
Why?
The classic editor will auto-attach images when they're selected from the media library. In #66663 there is a discussion about how this should work in the block editor. This is one such approach.
The previous attempts I linked to above were either too greedy or too verbose with too much exposed in the UI for a user to worry about.
The goal here is for this to basically be silent behaviour that roughly matches how things work in the classic editor, without interfering with anything for the user. The side-effect should be that whenever a user saves or publishes, the dynamic gallery block will update in the editor, and the attached images category will update in the inserter, too, to reflect the newly attached images.
How?
Add a step to the
editorpackage'ssavePostaction to perform an update on all unattached images within the post when the post is saved. An alternative could be to use theeditor.savePostaction/hook, however since we're already in the editor package, that isn't really necessary. Instead I've inlined right next to where we call that hook.A quick explanation as to why I went with a JS approach instead of PHP
Also, I've gone with a JS implementation instead of performing this in PHP, because:
Basically, with the above I wanted to ensure that for plugins or sites where they really don't want this behaviour, it's possible to switch it off, while at the same time, ensuring that this PR enables it as default, to try to get the block editor to behave more similarly to the classic editor in this respect.
Testing Instructions
Screenshots or screencast
2026-08-26.16.17.56.mp4
Use of AI Tools
Claude Code Opus 5