Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey 👋 I wanted to give you a heads-up since this pull request adds new files containing JSX. #80123 enables an ESLint rule that requires that files containing JSX must use the What you'll need to do: You'll need to rename any new files containing JSX to use the This comment is automated, based on pull requests with recent activity that contain affected |
d1bae44 to
65dc0df
Compare
Just wanted to note that I've got this implemented. |
…block-in-post-editor
What?
Closes #81941
Why?
As noted in the linked issue, the placeholder attribute for the title block is not working as expected in the Post Editor, while it works in the Site Editor as expected. See testing instructions and images in the issue.
How?
This PR adds checks for the placeholder attribute and applies it if it exists.
Testing Instructions
Either in the WP Playground with this PR, or locally, checkout this branch, build and do the following:
<!-- wp:post-title {"placeholder": "Add a post title", "level":1,"style":{"typography":{"textAlign":"center"}}} /-->Testing Instructions for Keyboard
Repeat the testing instructions from above, using the Code Editor and Visual Editor toggle shortcuts, pasting in the example code:
<!-- wp:post-title {"placeholder": "Add a post title", "level":1,"style":{"typography":{"textAlign":"center"}}} /-->Test suite added
Tests were added for this block in the
/test/edit.jsfile.To run these tests locally, run
npm run test:unit -- packages/block-library/src/post-title/test/edit.jsWhat the tests cover:
All four test pass:
Use of AI Tools
Well I edited the code on my own the test suite that is added for this was generated with AI, specifically using Claude Opus 4.8.