Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ui/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

### Enhancements

- `AlertDialog`, `Dialog`, `Drawer`, `Popover`, and `Tooltip`: Derive Trigger props from the corresponding Base UI components. ([#81824](https://github.com/WordPress/gutenberg/pull/81824))
- `Autocomplete.Status`, `Combobox.Status`: Add a `Status` subcomponent that announces async list status to screen readers. Item popups give Status its own collapsing grid row so a visible result count sits above the list without overlaying items ([#82195](https://github.com/WordPress/gutenberg/pull/82195)).
- `Autocomplete.Popup`, `Combobox.Popup`, `SearchableChipSelect`, `SearchableChipSelectControl`, `Select.Popup`, and `SelectControl`: Add `width` on Popups and `popupWidth` on composites, with preset width constraints (`anchor`, `content`, `sm`, `md`, `lg`, and `available`) for the item popup. `SelectControl` defaults to `content` to preserve prior popup sizing ([#82087](https://github.com/WordPress/gutenberg/pull/82087), [#82193](https://github.com/WordPress/gutenberg/pull/82193)).
- `Menu`: Use `Text` for item labels and descriptions to share typography and apply `text-wrap: pretty`. ([#82237](https://github.com/WordPress/gutenberg/pull/82237))
Expand Down
9 changes: 7 additions & 2 deletions packages/ui/src/alert-dialog/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,17 @@ export interface RootProps
onConfirm?: () => ConfirmResult | Promise< ConfirmResult >;
}

export interface TriggerProps extends ComponentProps< 'button' > {
// Detached triggers require handle and payload APIs that AlertDialog does not
// expose.
export type TriggerProps = Omit<
ComponentProps< typeof _AlertDialog.Trigger >,
'handle' | 'payload'
> & {
/**
* The content to be rendered inside the component.
*/
children?: ReactNode;
}
};

export interface PopupProps
extends ComponentProps< 'div' >,
Expand Down
9 changes: 7 additions & 2 deletions packages/ui/src/dialog/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,17 @@ export interface RootProps
children?: ReactNode;
}

export interface TriggerProps extends ComponentProps< 'button' > {
// Detached triggers require handle and payload APIs that Dialog does not
// expose.
export type TriggerProps = Omit<
ComponentProps< typeof _Dialog.Trigger >,
'handle' | 'payload'
> & {
/**
* The content to be rendered inside the component.
*/
children?: ReactNode;
}
};

export interface PopupProps
extends ComponentProps< 'div' >,
Expand Down
9 changes: 7 additions & 2 deletions packages/ui/src/drawer/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,17 @@ export interface RootProps
children?: ReactNode;
}

export interface TriggerProps extends ComponentProps< 'button' > {
// Detached triggers require handle and payload APIs that Drawer does not
// expose.
export type TriggerProps = Omit<
ComponentProps< typeof _Drawer.Trigger >,
'handle' | 'payload'
> & {
/**
* The content to be rendered inside the component.
*/
children?: ReactNode;
}
};

export interface PopupProps
extends ComponentProps< 'div' >,
Expand Down
11 changes: 7 additions & 4 deletions packages/ui/src/popover/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@ export interface RootProps
children?: ReactNode;
}

export interface TriggerProps
extends ComponentProps< 'button' >,
Pick< _Popover.Trigger.Props, 'openOnHover' | 'delay' | 'closeDelay' > {
// Detached triggers require handle and payload APIs that Popover does not
// expose.
export type TriggerProps = Omit<
ComponentProps< typeof _Popover.Trigger >,
'handle' | 'payload'
> & {
/**
* The content to be rendered inside the component.
*/
children?: ReactNode;
}
};

export interface PopupProps
extends ComponentProps< 'div' >,
Expand Down
9 changes: 7 additions & 2 deletions packages/ui/src/tooltip/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,17 @@ export type RootProps = Pick< _Tooltip.Root.Props, 'disabled' | 'children' >;

export type ProviderProps = _Tooltip.Provider.Props;

export interface TriggerProps extends ComponentProps< 'button' > {
// Detached triggers require handle and payload APIs that Tooltip does not
// expose.
export type TriggerProps = Omit<
ComponentProps< typeof _Tooltip.Trigger >,
'handle' | 'payload'
> & {
/**
* The content to be rendered inside the component.
*/
children?: ReactNode;
}
};

export interface PopupProps extends ComponentProps< 'div' > {
/**
Expand Down
4 changes: 4 additions & 0 deletions storybook/components-manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,10 @@
props:
- children
- className
- closeDelay
- closeOnClick
- delay
- disabled
- render
- style
- name: TreeGrid
Expand Down
Loading