Suggest mode: register the intent shortcuts only where they can be used - #81695

What

Fixes finding F-03 from the Suggest mode guided testing pass: https://github.com/adamsilverstein/gutenberg/blob/docs/suggest-mode-testing-2026-08-14/suggest-mode-testing/README.md

Part of #73411. Stacked on top of #80433 (suggest/inline-wiring), which is the base branch here.

The problem

The three intent shortcuts (core/editor/intent-edit, -suggest, -view) were registered whenever the Suggestion Mode experiment flag was on. Registration is what puts a shortcut in the Keyboard Shortcuts help modal, so the Site Editor listed "Switch to Edit mode.", "Switch to Suggest mode." and "Switch to View mode." under Global shortcuts.

None of them do anything there. wp_template has no editor.notes support, so no Mode menu renders and the handlers in global-keyboard-shortcuts/index.js return early. Pressing the combination gives no snackbar and no mode change.

The doc's diagnosis held up exactly on measurement: three gates for one feature, and the registration gate was the loose one. register-shortcuts.js checked isSuggestionModeEnabled() (the flag), while the Mode menu (PostTypeSupportCheck supportKeys="editor.notes") and the shortcut handlers (useCanSuggest()) both check the flag AND notes support.

The fix

Move the intent registrations into their own effect keyed on useCanSuggest(), the same runtime predicate the menu and the handlers use. editor.notes support arrives with the post type record, so the predicate starts false and flips once that resolves - hence a separate effect rather than a condition inside the existing one-shot registration. If it flips back the set is unregistered again, which is the pattern BlockEditorKeyboardShortcutsRegister already uses for its blockVisibility shortcuts.

One narrow file, packages/editor/src/components/global-keyboard-shortcuts/register-shortcuts.js, which no other open PR in this round touches.

Visible side effect worth calling out: in the post editor the three entries now sit at the end of the Global shortcuts list rather than in the middle of it, because they register on a later pass. Same shortcuts, same key combinations, same behavior.

Screenshots

Site Editor, Keyboard Shortcuts modal, Global shortcuts section. Before, the three intent shortcuts are advertised on a screen that cannot honor them:

After, they are gone and nothing else moved:

The post editor keeps all three. Before:

After, still listed, now at the end of the section:

Testing instructions

Enable the Suggestion Mode experiment (Gutenberg > Experiments) and use a block theme.

Before (on suggest/inline-wiring):

1. Open the Site Editor and edit any template.
2. Press Shift+Alt+Cmd+H (Mac) or Shift+Alt+H to open Keyboard shortcuts.
3. Under Global shortcuts, note "Switch to Edit mode.", "Switch to Suggest mode." and "Switch to View mode.".
4. Close the modal and press Shift+Alt+Cmd+X. Nothing happens: no snackbar, no mode change, and there is no Mode section in the Options menu.

After (this branch):

5. Repeat steps 1-3. The three entries are no longer listed.
6. Open a new post, open Keyboard shortcuts, and confirm the three entries are still listed there.
7. Close the modal and press Shift+Alt+Cmd+X. The "You're suggesting" snackbar appears and the Options menu shows Suggesting selected.

Automated coverage

Unit, packages/editor/src/components/global-keyboard-shortcuts/test/register-shortcuts.js:

• "registers the intent shortcuts when the post type can host suggestions"
• "leaves the intent shortcuts unregistered when the post type has no notes support"
• "leaves the intent shortcuts unregistered when the experiment is off"
• "removes the intent shortcuts when notes support goes away"

Verified red on the unmodified base first: the second and fourth fail there with all three names still registered, while the first and third (the controls) pass on base and after. All four pass with the fix.

E2E, test/e2e/specs/site-editor/suggestion-mode-intent-shortcuts.spec.js:

• "are listed in the post editor, where the Mode menu is offered"
• "still switch the intent in the post editor"
• "are not listed in the Site Editor, where no post type supports notes"

Same story: on a base build the two post editor controls pass and the Site Editor one fails on "Switch to Suggest mode." still being visible; with the fix all three pass, run with --repeat-each=5 for 15/15. The neighbouring suites were run against the fixed build too - shortcut-help.spec.js and suggestion-mode.spec.js give 23 passed with the one known pre-existing failure, "a closed sidebar stays closed when a suggestion is created", which is F-03's neighbour F-17 and is fixed separately in #81671.

AI Use

Claude Code did the typing here, I did the asking. Description too. I will review and test.