Repository navigation
Block Bindings: Don't throw on non-string values bound to a url attribute - #81533
Open
Mayank-Tripathi32 wants to merge 2 commits into
Open
Mayank-Tripathi32 wants to merge 2 commits into
Mayank-Tripathi32 wants to merge 2 commits into
Conversation
…bute isURLLike immediately calls val.includes( ' ' ), so a bound source value that is a truthy non-string threw a TypeError and crashed the block. The preceding falsy check masked this for 0, '', null and false, leaving only truthy non-strings, e.g. post meta registered as integer, array or object. Return false for anything that isn't a string, so such values fall through to the existing 'not a valid URL' branch and null the attribute.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mayank-Tripathi32
added
the
[Type] Code Quality
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A bindings source value bound to a url attribute is passed to isURLLike, which starts with val.includes( ' ' ). When the value isn't a string that throws a TypeError and the block renders the crash warning instead of its content.
Why
Sources return raw values. core/post-meta hands back the meta value untouched, so a field registered as integer, array or object and bound to an image or button url breaks the block. The falsy check before isURLLike hid this for 0, '', null and false, so only truthy non-strings hit it.
The bindings UI only offers fields whose type matches the attribute, but bindings set in block markup, in patterns, or by third-party sources aren't filtered. This is reachable when the binding comes from somewhere other than that UI.
How
Return false from isURLLike for anything that isn't a string. Such values then take the existing "not a valid URL" branch and the attribute is set to null, which is what already happened for the falsy ones.
The guard is in isURLLike rather than at the call site because the rest of that function is already written defensively (val?.startsWith) and the fix covers the other LinkControl callers too. Happy to move it into BlockEdit instead if reviewers would rather the source contract be enforced there.
Testing Instructions
<!-- wp:image {"metadata":{"bindings":{"url":{"source":"core/post-meta","args":{"key":"my_number"}}}}} -->Use Of AI
Yes, Verified with claude opus.