Repository navigation
Show Responsive viewport/state indicator in save confirmation dialog - #81027
shail-mehta wants to merge 20 commits into
Conversation
|
Size Change: +1.62 kB (+0.02%) Total Size: 7.78 MB 📦 View Changed
|
|
Flaky tests detected in 9a3002d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/30708342985
|
|
Hey 👋 I wanted to give you a heads-up since this pull request adds new files containing JSX. #80123 enables an ESLint rule that requires that files containing JSX must use the What you'll need to do: You'll need to rename any new files containing JSX to use the This comment is automated, based on pull requests with recent activity that contain affected |
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🤖 PR meta 🤖🎉 PropsUnlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shailu25@git.wordpress.org. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 📦 Bundle sizeSize Change: +6.23 kB (+0.08%) Total Size: 8.3 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. applies the filtered form to the Quick Edit DataForm (Site Editor v2) in
|
JSX in a .js file fails Vitest parse; new JSX files must use .tsx.
…wport-indicator # Conflicts: # package-lock.json # packages/core-data/CHANGELOG.md # packages/core-data/package.json
The private components Badge is deprecated and warns in unit tests, which fails CI.
What?
Closes #80836
This PR updates the save confirmation modal to indicate which responsive state (e.g. Mobile, Tablet) a style change was made in, when the change comes from a responsive style variation set via
Editor > Styles > Blocks > Title.Why?
When a user edits block styles for a specific viewport (e.g. Mobile only), the save confirmation screen only shows the block style was changed - not which viewport it applies to. This ambiguity can lead users to think the change is global, risking unintended publishes. Making the viewport explicit improves clarity and confidence before saving.
How?
Surface the active viewport/state
(Mobile/Tablet/Default)tied to a style edit in the change-tracking data used by the save panel, and append a viewport indicator to affected entries.Testing Instructions
Editor > Styles > Blocks > TitleScreenshots
Use of AI Tools