Skip to content

Only include icon library SVGs listed as public in the Zip file published to GitHub Container Registry for wordpress-develop #79338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desrosj merged 13 commits into from
Jul 14, 2026
Merged

Only include icon library SVGs listed as public in the Zip file published to GitHub Container Registry for wordpress-develop #79338

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
04f1a21
Icons: Extract shared getPublicIcons helper
desrosj Jun 19, 2026
022a3c5
Icons: Group internal require under Internal dependencies block
desrosj Jun 19, 2026
c546433
Icons: Add prune-non-public-icons build script
desrosj Jun 19, 2026
3db2852
Icons: Assert exact prune log message with toHaveLoggedWith
desrosj Jun 19, 2026
afd0623
Build: Prune non-public icons from wordpress-develop artifact
desrosj Jun 19, 2026
ec99f4a
Adjust inline documentation.
desrosj Jun 22, 2026
ddb6288
Merge branch 'trunk' into fix/prune-non-public-icons-core-build
t-hamano Jul 11, 2026
3a41514
Make use of `jq` to simplify the related logic.
desrosj Jul 13, 2026
cf358d9
Restore non-public icons after creating zip file.
desrosj Jul 13, 2026
cd5f671
Merge branch 'trunk' into fix/prune-non-public-icons-core-build
desrosj Jul 13, 2026
2812470
Output details to the log.
desrosj Jul 13, 2026
828584e
Merge remote-tracking branch 'origin/fix/prune-non-public-icons-core-…
desrosj Jul 13, 2026
26a724d
Remove `jq-node` requirement.
desrosj Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions bin/build-plugin-zip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ if [ -z "$NO_CHECKS" ]; then
exit 1
fi
fi

# WordPress Core builds prune non-public icons using jq, which is expected to be
# present on the system running this script.
if [ "$IS_WORDPRESS_CORE" = "true" ] && ! command -v jq > /dev/null 2>&1; then
error "ERROR: jq is required to build for WordPress Core but was not found. 🫥
Install jq (https://jqlang.org/) and try again."
exit 1
fi
fi

# Run the build.
Expand All @@ -72,6 +80,22 @@ npm ci
status "Generating build... 👷‍♀️"
npm run build -- --skip-types

# Only including public icons when building for WordPress Core.
#
# This runs before creating the archive but after the build so icon collection validation passes as expected. Plugin
# builds keep the full library.
if [ "$IS_WORDPRESS_CORE" = "true" ]; then
status "Pruning non-public icons for WordPress Core... ✂️"
(
cd packages/icons/src
non_public_icons=$(comm -13 \
<(jq -r "map(select(.public) | .filePath)[]" manifest.json | sort) \
<(ls library/*.svg))
echo "$non_public_icons" | sed 's|^| Deleting packages/icons/src/|'
echo "$non_public_icons" | xargs rm
)
fi

# Generate the plugin zip file.
status "Creating archive... 🎁"
zip --recurse-paths --no-dir-entries \
Expand All @@ -87,4 +111,8 @@ zip --recurse-paths --no-dir-entries \
changelog.txt \
README.md

status "Restoring non-public icons... 🔁"
git diff --name-only --diff-filter=D -- packages/icons/src | sed 's|^| Restoring |'
git restore packages/icons/src

success "Done. You've built Gutenberg! 🎉 "
Loading