Repository navigation
Conversation
|
Size Change: 0 B Total Size: 8.59 MB |
|
Flaky tests detected in 5d45dff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27623782229
|
scruffian
force-pushed
the
scruffian/v2-classic-gating
branch
from
June 16, 2026 14:11
52b3ecf to
5d45dff
Compare
4 of 14 tasks
Contributor
|
Need to check what's left but I think, I've landed a fix for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds v2 Site Editor gating so unsupported classic themes do not get the Styles menu or Styles canvas, while classic themes with Style Book support keep access.
Why?
V1 already has classic-theme fallback behavior for Style Book and unsupported screens, but v2 registered the Styles route/menu without the same support checks.
How?
The v2 menu registration now checks block-theme and classic Style Book support, and the v2 Styles route/stage share a support helper that shows the unsupported notice and skips the canvas when unavailable.
Testing Instructions
admin.php?page=site-editor-v2still shows Styles, Navigation, Pages, Templates, Template Parts, and Patterns./stylesaccess shows the unsupported-theme notice.Testing Instructions for Keyboard
Repeat the testing steps using keyboard navigation and confirm focus reaches the available menu items and unsupported notice.
Screenshots or screencast
N/A
Use of AI Tools
Used OpenAI Codex to implement the change, run checks, and prepare this PR.