Repository navigation
Conversation
The `@wordpress/style-runtime` package is declared as a dependency in `packages/theme/package.json` but is not imported anywhere in `packages/theme/src`. Drop the dependency along with the matching TypeScript project reference, and update the lockfile to match. Addresses B5 from #77462.
|
Size Change: 0 B Total Size: 8.16 MB ℹ️ View Unchanged
|
Contributor
Author
|
Closing — see PR #77965 Next steps #2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the declared-but-unused
@wordpress/style-runtimedependency from@wordpress/theme, along with the matching TypeScript project reference. The lockfile and CHANGELOG are updated accordingly.Addresses B5 from #77462.
Why?
@wordpress/style-runtimeis listed underdependenciesinpackages/theme/package.json, but it is not imported anywhere inpackages/theme/src. Keeping the stale dependency:@wordpress/theme,tsconfig.json/tsconfig.src.json,How?
@wordpress/style-runtimefrompackages/theme/package.jsondependencies.{ "path": "../style-runtime" }references frompackages/theme/tsconfig.jsonandpackages/theme/tsconfig.src.json.package-lock.jsonto match.Unreleased > Internalsection.Testing Instructions
npm installshould be a no-op (lockfile is consistent).npx tsc --build packages/theme/tsconfig.json --forceshould succeed.rg "style-runtime" packages/themethat no source file references the package after the change.