Skip to content

Add aria-label to Revisions button in Post Summary sidebar #78140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 10 commits into from
May 12, 2026
Merged

Add aria-label to Revisions button in Post Summary sidebar #78140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
713a1dd
Add aria-label to Revisions button in Post Summary sidebar
vishnupprajapat May 11, 2026
bf5f9a8
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 11, 2026
fe06482
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 11, 2026
559506d
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 11, 2026
ade48b5
Change ariaLabel to aria-label for better standard compliance
vishnupprajapat May 11, 2026
df118bf
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 11, 2026
1772dcc
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 12, 2026
7ae7e6f
Update E2E tests to match the new revisions button aria-label
vishnupprajapat May 12, 2026
c07f326
Update E2E tests to match new Revisions button aria-label
vishnupprajapat May 12, 2026
ef8111c
Merge branch 'trunk' into fix/revisions-button-a11y
vishnucmsminds May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update E2E tests to match the new revisions button aria-label
  • Loading branch information
@vishnupprajapat
vishnupprajapat committed May 12, 2026
commit 7ae7e6f8527a1b0d5ab00f000bdb27ed3061388b
4 changes: 3 additions & 1 deletion test/e2e/specs/editor/various/footnotes-revisions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ test.describe( 'Footnotes in Revisions UI', () => {
} );
await settingsSidebar.getByRole( 'tab', { name: 'Post' } ).click();
await settingsSidebar
.getByRole( 'button', { name: '2', exact: true } )
.getByRole( 'button', {
name: 'Open revisions screen: 2 revisions',
} )
.click();

// Wait for the revisions mode to be active.
Expand Down
8 changes: 6 additions & 2 deletions test/e2e/specs/editor/various/revision-block-diff.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ test.describe( 'Revision Block Diff Panel', () => {
} );
await settingsSidebar.getByRole( 'tab', { name: 'Post' } ).click();
await settingsSidebar
.getByRole( 'button', { name: '2', exact: true } )
.getByRole( 'button', {
name: 'Open revisions screen: 2 revisions',
} )
.click();

// Wait for revisions mode.
Expand Down Expand Up @@ -112,7 +114,9 @@ test.describe( 'Revision Block Diff Panel', () => {
} );
await settingsSidebar.getByRole( 'tab', { name: 'Post' } ).click();
await settingsSidebar
.getByRole( 'button', { name: '2', exact: true } )
.getByRole( 'button', {
name: 'Open revisions screen: 2 revisions',
} )
.click();

await expect(
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/specs/editor/various/revision-fields-diff.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ test.describe( 'Revision Fields Diff Panel', () => {
} );
await settingsSidebar.getByRole( 'tab', { name: 'Post' } ).click();
await settingsSidebar
.getByRole( 'button', { name: '2', exact: true } )
.getByRole( 'button', {
name: 'Open revisions screen: 2 revisions',
} )
.click();
await expect(
page.getByRole( 'button', { name: 'Restore' } )
Expand Down
Loading