Repository navigation
Fix missing custom duotone creation menu in duotone controls - #77649
Open
prachigarg19 wants to merge 2 commits into
Open
prachigarg19 wants to merge 2 commits into
prachigarg19 wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
prachigarg19
changed the title
t-hamano
added
[Type] Bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #58548
Fixes the missing custom duotone creator in the block sidebar by making FiltersPanel read customDuotone and custom (color) settings instead of always passing hardcoded disableCustomColors and disableCustomDuotone to DuotonePicker.
Removed the custom duotone creator at Global block settings level as per the comment: #58548 (comment)
Why?
When editing an Image or Cover block, the custom duotone creator (the color picker that lets you build a two-tone filter from scratch) appeared in the block toolbar but was completely absent from the block sidebar. This was a regression caused by a hardcoded disableCustomColors and disableCustomDuotone in FiltersPanel, originally added with a TODO comment noting it should be re-enabled when block-level custom colors were supported.
How?
In filters-panel.js:
Extracted a getCustomDuotoneFlags( settings, colorPalette, enableCustomDuotone ) helper that derives disableCustomColors and disableCustomDuotone from the actual block settings, matching the logic already used in the toolbar path (DuotonePanelPure in duotone.js).
Added an enableCustomDuotone prop on FiltersPanel (defaults to true) to allow callers to opt out if needed.
Removed the hardcoded disableCustomColors and disableCustomDuotone from DuotonePicker, replacing them with the values computed from settings.
Testing Instructions
Screenshots or screencast
Use of AI Tools
This PR was developed with assistance from Claude for code generation and iteration. All changes were reviewed and verified manually.