Repository navigation
Media inserter: Add pagination, and consolidate component with pattern inserter and global styles revisions - #77176
Closed
andrewserong wants to merge 1 commit into
Closed
andrewserong wants to merge 1 commit into
andrewserong wants to merge 1 commit into
Conversation
…, pattern inserter, and media inserter
|
Size Change: -233 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 3ee9a4f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24176377045
|
Member
|
Reckon this one is still valid or can we close it? I see #80038 was merged
|
Contributor
Author
|
Oh thank you! I'd forgotten about this one. Yes, the ideas I had here originally were superseded by #80038 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Part of:
Add pagination to the media inserter in the inserter sidebar.
Note
This isn't ready for testing or review just yet, it's mostly vibe coded and I haven't looked over it yet.
At this stage, it's mostly a proof of concept to try out the idea. I'll see how this feels before polishing.
Why?
As described in the linked issue, media insertion in the sidebar is pretty basic at the moment and it only shows the latest results. I think we can make this area a little more usable, with pagination for example.
At the same time, I noticed we had a different implementation for pagination in the pattern inserter and in the global styles revisions UI. Since we're adding a third place where pagination needs to occur, this PR also proposes consolidating them into the one thing.
How?
To-do
Testing Instructions
TBC but basically we'll be testing:
Screenshots or screencast
Patterns pagination (before)
Patterns pagination (after)
Media pagination
Note this uses a slightly different UI because in code we don't (yet) know how many items or pages are available. That's a "to-do"