Repository navigation
[WIP] Add icon support for Breadcrumbs separator in block editor - #77059
Infinite-Null wants to merge 3 commits into
Conversation
…s and rendering logic
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Before we move forward with this PR, a crucial point is how we maintain backward compatibility. My understanding is that this PR will discard text that users have already configured.
Perhaps we need something like a "mode" selector, such as a text input mode or an icon selection mode 🤔
| import HtmlRenderer from '../utils/html-renderer'; | ||
|
|
||
| const separatorDefaultValue = '/'; | ||
| import { CustomInserterModal } from '../icon/components'; |
There was a problem hiding this comment.
Let's avoid directly referencing other blocks. CustomInserterModal is intended for the Icon block, and its changes should not propagate to other blocks.
Perhaps we should address #76787 before moving forward with this PR.
There was a problem hiding this comment.
Thank you @t-hamano, Noted! For now, I’ll add a toggle for mode selection (e.g., text input vs icon selection) to preserve backward compatibility, and will hold off on further changes until the above PR is addressed.
t-hamano
added
[Type] Enhancement
…n and text options
Part of: #75715 (Icon block enhancements)
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools