Style Book: Fix missing styles for classic themes in stylebook route#76843
Merged
Style Book: Fix missing styles for classic themes in stylebook route#76843
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
[Package] Editor
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 7.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eabd397. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23603667509
|
ntsekouras
reviewed
Mar 26, 2026
| <StyleBookPreview isStatic /> | ||
| <StyleBookPreview | ||
| isStatic | ||
| settings={ siteData.editorSettings } |
Contributor
There was a problem hiding this comment.
I'm wondering if it would be better to update editor settings (dispatch( editorStore ).updateEditorSettings( settings );) below the edit site settings update. 🤔
Contributor
Author
There was a problem hiding this comment.
That approach might also be possible, but it could have a significant impact and be risky to implement during the RC phase 🤔
ntsekouras
reviewed
Mar 27, 2026
| const editorSettings = useSelect( | ||
| ( select ) => select( editorStore ).getEditorSettings(), | ||
| [] | ||
| ( select ) => settingsProp ?? select( editorStore ).getEditorSettings(), |
Contributor
There was a problem hiding this comment.
Do we gain anything by doing the check inside the useSelect and not outside? 🤔
Contributor
Author
There was a problem hiding this comment.
This is to avoid unnecessary subscriptions to the editorStore when settingsProp exists.
ntsekouras
approved these changes
Mar 27, 2026
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
I think this approach is fine too and we already have siteData available to pass. Thanks!
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 27, 2026
…76843) * Style Book: Fix missing styles for classic themes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Avoid unnecessary subscription --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 57ca43e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76826
What?
Fix the Style Book not applying any styles when opened via the stylebook route with a classic theme
Why?
When
StyleBookPreviewwas moved fromedit-sitetoeditorpackage in #72681, the settings source changed fromsiteEditorStore.getSettings()toeditorStore.getEditorSettings(). For the classic theme stylebook route, no post is being edited, soEditorProvideris not rendered andeditorStore.editorSettingsis never initialized with the theme's styles — resulting in a completely unstyled Style Book.How?
settingsprop toStyleBookPreviewthat takes precedence overeditorStore.getEditorSettings()when provided.siteData.editorSettings(fromeditSiteStore.getSettings(), which contains the theme styles) toStyleBookPreview.Testing Instructions
Screenshots
Before
After
Use of AI Tools
Claude Code was used to investigate the regression and implement the fix.