Commands: Fix useSelect warning in command palette#76822
Merged
Conversation
Move the `?? []` fallback outside of `useSelect` to avoid creating a new array reference on every call when the preference is undefined. Use a module-level `EMPTY_ARRAY` constant as a stable default instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
changed the title
useSelect return value for recentlyUsedNames
|
Size Change: +8 B (0%) Total Size: 7.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 174ad64. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23584418957
|
senadir
approved these changes
Mar 26, 2026
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 26, 2026
…s` (#76822) Move the `?? []` fallback outside of `useSelect` to avoid creating a new array reference on every call when the preference is undefined. Use a module-level `EMPTY_ARRAY` constant as a stable default instead. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #75691
What?
Fix the browser console warning that appears when opening the command palette:
Why?
The
?? []fallback insideuseSelectcreates a new empty array reference on every call when therecentlyUsedpreference isundefined. This causesuseSelect's shallow equality check to fail, triggering unnecessary re-renders and the warning above.How?
useSelectby using a module-levelEMPTY_ARRAYconstant as a stable default value in the destructuring assignment.Testing Instructions
First, execute the following code in the browser console.
Use of AI Tools
This PR was authored with assistance from Claude Code (Claude Opus 4.6).