Open
Conversation
github-actions
bot
added
[Package] Block library
|
Size Change: +25 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bf942e7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23528491327
|
Contributor
|
Did you investigate trying to hook into the duplicate action and using it to also duplicate the corresponding tab menu item/tab panel block. This would mean that we can keep duplicate as an action, but we'd still solve the duplication issue. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
reviewed
Mar 25, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
This works as advertised and solves the problem, but I'm a bit reluctant to add a new block support if we don't need it. If there's no clean/simple way to handle duplication in the block then this seems like the best alternative.
15 tasks
Member
Author
|
I think adding a new block support is the simplest way to remove this button, without introducing any block-specific logic or other side effects. We could also hide the button by setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #76449
Follow-up to #75954
Adds an
__experimentalDuplicateblock support flag and uses it to disable the "Duplicate" block action for Tabs-related blocks (tab,tab-panel,tabs-menu,tabs-menu-item).I'm not sure if we need to include "experimental" in the name of this property, maybe just "duplicate" would be better. This would be similar to the "multiple" property (which controls whether more than one block instance can exist).
Why?
Duplicating individual Tabs inner blocks (tabs, tab panels, menu items) in isolation breaks the synchronised relationship between those components, i.e. a duplicated tab panel won't have a corresponding tab menu item, and vice versa. Disabling "Duplicate" for these blocks prevents an inconsistent state.
How?
__experimentalDuplicateblock support (defaults to true)BlockActionsto check this support flag before offering the duplicate action"__experimentalDuplicate": falsein block.json fortab,tab-panel,tabs-menu, andtabs-menu-itemTesting Instructions
Use of AI Tools
This PR was written with assistance from Claude Code. All code changes were reviewed by the author.