Skip to content
Draft
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
fc945bb
Add normalizeCSSFontFaceFontFamily function
sirreal Mar 6, 2026
3be8281
Move normalizeCSSFontFaceFontFamily and add null replacement
sirreal Mar 24, 2026
5d8ac8d
Rework font uploads to construct CSS string @font-face font-family
sirreal Mar 24, 2026
baf8bfd
Fix fontfacemetadata passing
sirreal Mar 24, 2026
a1ac8df
sketching migration to CSSStyleSheet instead of FontFace
sirreal Mar 24, 2026
18d4f77
Work on rule add/remove
sirreal Mar 25, 2026
b3b16c8
fix iframe font loading
sirreal Mar 25, 2026
97df7db
Fix rule iteration for on unload
sirreal Mar 25, 2026
1276ddf
Fix unicode-range descriptor
sirreal Mar 25, 2026
0cce556
clean up comments
sirreal Mar 25, 2026
85bb3eb
Remove setProperty, unsupported in FireFox
sirreal Mar 25, 2026
ef7b6f5
Push stylesheets
sirreal Mar 25, 2026
f1eda18
DROPME: debug logging
sirreal Mar 25, 2026
b1ea1a2
Revert "DROPME: debug logging"
sirreal Mar 25, 2026
543fa3a
loadFontFaceInBrowser no longer async
sirreal Mar 25, 2026
24eb5da
Fix rule break logic
sirreal Mar 25, 2026
7ce98b8
Avoid throwing on CSS rule errors
sirreal Mar 25, 2026
4e01a58
Improve rule failure handling
sirreal Mar 25, 2026
a0b932e
Rename createCssString`
sirreal Mar 25, 2026
7d00215
Improve cssString documentation and escape more CSS characters
sirreal Mar 25, 2026
0d11805
Document new functions
sirreal Mar 25, 2026
9ae810f
Ignore debug console errors
sirreal Mar 25, 2026
dab12fc
Document fontface browser function params
sirreal Mar 25, 2026
fb83a84
Do not trim in CSS string method. Trim font name
sirreal Mar 26, 2026
5538490
Improve css string documentation
sirreal Mar 26, 2026
2ba07cd
Remove redundant await
sirreal Mar 26, 2026
0fff3fa
Remove file from fontFace passed to loadFontFaceInBrowser
sirreal Mar 26, 2026
7343eb0
Disallow "" font names
sirreal Mar 26, 2026
3f2f883
Move createCssString to its own file
sirreal Mar 26, 2026
8cfe64f
Add createCssString unit tests
sirreal Mar 26, 2026
3f64732
Add e2e
sirreal Mar 26, 2026
4efc38a
Use Jest markdown table format
sirreal Mar 26, 2026
56a1cca
Add schema to tsconfig
sirreal Mar 26, 2026
2544d14
Fix test typescript
sirreal Mar 26, 2026
16ad91d
Unload _all_ font versions when unloading
sirreal Mar 26, 2026
e37dcd9
Add debug logging to font load/unload/revoke
sirreal Mar 26, 2026
cca4d9e
Revert "Add debug logging to font load/unload/revoke"
sirreal Mar 26, 2026
a3dbafb
Fix typo in comment.
sirreal Mar 26, 2026
eb004f4
Prevent possible possible error on undefined font values
sirreal Mar 27, 2026
e58ed1e
Check for font loaded in e2e
sirreal Mar 27, 2026
aff1960
Fix rule style descriptor iteration
sirreal Mar 27, 2026
f07ca4d
Use descriptive loop variable names
sirreal Mar 27, 2026
9c20593
Revoke blob URLs on rule creation failure
sirreal Mar 27, 2026
32ce747
Improve source/src variable names
sirreal Mar 27, 2026
7e232bb
Auto-escape list of characters
sirreal Mar 27, 2026
6802f39
Fix createCssString return description
sirreal Mar 27, 2026
5ef2081
Add code comments
sirreal Mar 27, 2026
8e2b770
Ensure fontFace exists in accumulator type
sirreal Mar 27, 2026
cd9773a
Revert "Auto-escape list of characters"
sirreal Mar 27, 2026
702b90e
Improve comment
sirreal Mar 27, 2026
a90a20c
Align with php-side implementation test cases
sirreal Mar 30, 2026
e9f66c5
Align examples with PHP implementation
sirreal Mar 30, 2026
45adc19
Fix Playwright font asset path
Copilot Jul 8, 2026
f833df3
Merge branch 'trunk' into trac-63568/uploaded-font-name-minimal-fix
sirreal Aug 18, 2026
a3f8372
Merge branch 'trunk' into trac-63568/uploaded-font-name-minimal-fix
sirreal Aug 18, 2026
bbe07e7
Remove import headers (lint)
sirreal Aug 18, 2026
4cebb35
Add @jest/globals dev dep
sirreal Aug 18, 2026
d8d3bd6
Merge branch 'trunk' into trac-63568/uploaded-font-name-minimal-fix
sirreal Aug 18, 2026
993d133
Merge branch 'trunk' into trac-63568/uploaded-font-name-minimal-fix
sirreal Aug 19, 2026
137c721
Merge branch 'trunk' into trac-63568/uploaded-font-name-minimal-fix
matiasbenedetto Oct 2, 2026
315167d
Reject font face rules without a font family
matiasbenedetto Oct 5, 2026
ef0e98f
Keep the upload changes close to trunk
matiasbenedetto Oct 5, 2026
346d863
Simplify the font face rule and remove formatFontFaceName
matiasbenedetto Oct 5, 2026
86cf7ba
Rename the createCssString test to a JavaScript file
matiasbenedetto Oct 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure fontFace exists in accumulator type
  • Loading branch information
sirreal committed Jul 9, 2026
commit 8e2b7707c7c7c2efe4c87c7a43725ff14b63c6ea
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ export default function makeFamiliesFromFaces(
): FontFamilyToUpload[] {
const fontFamiliesObject = faces.reduce(
(
acc: Record< string, FontFamilyToUpload >,
acc: Record<
string,
FontFamilyToUpload & {
fontFace: NonNullable< FontFamilyToUpload[ 'fontFace' ] >;
}
>,
item: FontFileMetadata
) => {
const cssFontFamily = createCssString( item.fontDisplayName );
Expand All @@ -29,7 +34,7 @@ export default function makeFamiliesFromFaces(
fontFace: [],
};
}
acc[ item.fontDisplayName ].fontFace!.push( {
acc[ item.fontDisplayName ].fontFace.push( {
fontFamily: cssFontFamily,
fontStyle: item.fontStyle,
fontWeight: item.fontWeight,
Expand Down