Connectors: Improve AI plugin button#76759
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1220747 to
e06d38d
Compare
|
Size Change: 0 B Total Size: 7.66 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in f9882bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23438847953
|
gziolo
left a comment
There was a problem hiding this comment.
Thank you for taking care of it. I had one minor note.
|
On this scenario where there is no connector connected the banner says: "The AI plugin is installed. Connect a provider below to generate featured images, alt text, titles, excerpts, and more. " but then we include a button "Enable features in the AI plugin". I think the button should only appear after a connector is connected otherwise we have to calls to action one to enable AI features another to connect. We could also apply the @gziolo suggestion as if we say Control, the issue is not as prominient. |
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Thank you for working on this @t-hamano, I think it is something we should merge before the next release.
But I think the ideal UX would be to enable some features by default, and not force users to go to yet another settings page to get a feature working. Going to cc @shaunandrews, @jasmussen as it relates to UX in case they have some insights.
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
We're not enabling RTC by default in this release, so I don't see why we should enable something by default from a plugin either. |
|
Thanks for the review! Is there anything I should update in this PR before merging? |
It would still not be enable by default for WordPress users, user would explicitly press a button to install activate ai features, and connect a provider to get AI features. I think pressing the button and connection some provider is already enough optin, I don't see the reason to besides doing that also need to go to a settings page and enable the AI features. Like people already pressed install to get them, connected a provider why make then need to go to a other place? |
|
In that case, I'd want VERY SPECIFIC copy on the button label noting what's going to be enabled. We cannot break user trust here, especially for sites with more than 1 user where their AI usage costs would jump noticeably if lots of users started generating images etc. |
|
We definitely have to land it today. We can always follow up if there is agreement to change wording. |
|
Okay, for now let's merge this and consider it again in the follow-up. |
* Connectors: Improve AI plugin button * Move learn more link * Restore effect * Remove unnecessary div * Fix e2e test * Add ts-ignore * Update button text Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: jonathanbossenger <psykro@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 17ed7be |
This updates the pinned hash from the `gutenberg` from `2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d` to `3edafcc90fc4520939d69279e26ace69390582be`. The following changes are included: - RTC: Use activation hook to enable RTC by default (WordPress/gutenberg#76736) - Connectors: Align client-side registration API with server-side (WordPress/gutenberg#76737) - Connectors: Support non-AI provider types and add JS extensibility e2e test (WordPress/gutenberg#76722) - RTC: Add E2E "stress test" with complex interactions (WordPress/gutenberg#76055) - Button: restore specificity of high-contrast mode focus ring (WordPress/gutenberg#76719) (WordPress/gutenberg#76770) - Connectors: Improve AI plugin button (WordPress/gutenberg#76759) - RTC: Use prepared queries instead of `*_post_meta` functions (WordPress/gutenberg#76779) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d…3edafcc90fc4520939d69279e26ace69390582be. Log created with: git log --reverse --format="- %s" 2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d..3edafcc90fc4520939d69279e26ace69390582be | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62102 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d` to `3edafcc90fc4520939d69279e26ace69390582be`. The following changes are included: - RTC: Use activation hook to enable RTC by default (WordPress/gutenberg#76736) - Connectors: Align client-side registration API with server-side (WordPress/gutenberg#76737) - Connectors: Support non-AI provider types and add JS extensibility e2e test (WordPress/gutenberg#76722) - RTC: Add E2E "stress test" with complex interactions (WordPress/gutenberg#76055) - Button: restore specificity of high-contrast mode focus ring (WordPress/gutenberg#76719) (WordPress/gutenberg#76770) - Connectors: Improve AI plugin button (WordPress/gutenberg#76759) - RTC: Use prepared queries instead of `*_post_meta` functions (WordPress/gutenberg#76779) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d…3edafcc90fc4520939d69279e26ace69390582be. Log created with: git log --reverse --format="- %s" 2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d..3edafcc90fc4520939d69279e26ace69390582be | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/trunk@62102 git-svn-id: http://core.svn.wordpress.org/trunk@61384 1a063a9b-81f0-0310-95a4-ce76da25c4cd



What?
AI Experimentsto justAIai#287Why?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Plugin not installed
Installing Plugin
Plugin Disabled
Plugin Enabled